Patch #31355

Bookmarks and recently used projects for the project jump box

Added by Jens Krämer 3 months ago. Updated 3 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:UI
Target version:4.1.0

Description

This patch aims to make the project jump box (project selector in top right corner) more useful especially for installations / users with many projects.

  • adds a bookmarking feature to the project overview page
    • users can bookmark any project they have access to
    • bookmarked projects will be rendered in a separate section in the jump box, on the top.
  • the 3 most recently used projects will be rendered in a second section of the jump box. That number may be changed in the user's account preferences
    • bookmarked projects are excluded from that list
  • the last section of the jump box holds any other projects that would have been rendered in the jump box originally but are not already shown in one of the previous sections.
  • all 3 sections will be filtered according to a given query string in the search box
  • favorites and other projects lists are rendered as trees, recently used projects as a flat list ordered by time of last use
  • recently used and bookmarked projects are stored as serialized arrays of project IDs in the user preferences.

0001-adds-favorites-and-recently-used-projects-lists-to-p.patch Magnifier (22.6 KB) Jens Krämer, 2019-05-13 09:32

jumpbox.png (10.3 KB) Jens Krämer, 2019-05-13 09:35

addbookmark.png (5.17 KB) Jens Krämer, 2019-05-13 09:35

tag_blue_add.png (671 Bytes) Go MAEDA, 2019-05-20 07:39

tag_blue_delete.png (701 Bytes) Go MAEDA, 2019-05-20 07:39


Related issues

Related to Redmine - Patch #31356: replace icon-fav with icon-user for 'my projects' Closed
Related to Redmine - Defect #31411: Internal Error (r18182) Closed
Related to Redmine - Defect #31508: Add missing frozen strings and copyrights Closed
Duplicated by Redmine - Feature #7339: Add a favorites Project list. Closed 2011-01-15

Associated revisions

Revision 18181
Added by Go MAEDA 3 months ago

Adds favorites and recently used projects lists to project jump box (#31355).

Patch by Jens Krämer.

Revision 18182
Added by Go MAEDA 3 months ago

Update locales (#31355).

Revision 18183
Added by Go MAEDA 3 months ago

Fix an error "uninitialized constant Redmine::ProjectJumpBox" in the production environment (#31355).

History

#1 Updated by Go MAEDA 3 months ago

  • Target version set to Candidate for next major release

#2 Updated by Go MAEDA 3 months ago

  • Related to Patch #31356: replace icon-fav with icon-user for 'my projects' added

#3 Updated by Go MAEDA 3 months ago

I like this change. Users generally be a member of many projects, but the projects they usually use is not so many. With this change, they can quickly go to the project they are currently working on.

#4 Updated by Bernhard Rohloff 3 months ago

I've tried the patch and it makes project switching very fast and easy. A really great improvement for Redmine!
+1

#5 Updated by Bernhard Rohloff 3 months ago

Oh, one thing I forgot is, the patch doesn't contain the two new icons referenced by the stylesheet changes.

.icon-bookmark { background-image: url(../images/tag_blue_delete.png); }

.icon-bookmark-off { background-image: url(../images/tag_blue_add.png); }

#6 Updated by Go MAEDA 3 months ago

Bernhard Rohloff wrote:

Oh, one thing I forgot is, the patch doesn't contain the two new icons referenced by the stylesheet changes.

[...]

The icons are included in the patch. You can get them by using git apply instead of patch command.

#7 Updated by Marius BALTEANU 3 months ago

The patch looks very good to me. I'm in favour of delivering this feature in 4.1.0.

#8 Updated by Go MAEDA 3 months ago

  • Target version changed from Candidate for next major release to 4.1.0

I am sure that no one will dislike or oppose this feature. Let's deliver this feature in 4.1.0.

#9 Updated by Go MAEDA 3 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patches. Thank you for contributing the great improvement.

#10 Updated by Go MAEDA 3 months ago

  • Status changed from Closed to Reopened

It does not work in production mode.

Started GET "/" for 127.0.0.1 at 2019-05-21 09:26:20 +0900
Processing by WelcomeController#index as HTML
  Current user: anonymous
  Rendering welcome/index.html.erb within layouts/base
  Rendered collection of news/_news.html.erb [2 times] (66.0ms)
  Rendered welcome/index.html.erb within layouts/base (134.1ms)
Completed 500 Internal Server Error in 423ms (ActiveRecord: 14.2ms)

ActionView::Template::Error (uninitialized constant Redmine::ProjectJumpBox):
    79:         <%= hidden_field_tag(controller.default_search_scope, 1, :id => nil) if controller.default_search_scope %>
    80:         <label for='q'>
    81:           <%= link_to l(:label_search), {:controller => 'search', :action => 'index', :id => @project, :scope => default_search_project_scope}, :accesskey => accesskey(:search) %>:
    82:         </label>
    83:         <%= text_field_tag 'q', @question, :size => 20, :class => 'small', :accesskey => accesskey(:quick_search) %>
    84:         <% end %>
    85:         <%= render_project_jump_box %>

app/helpers/application_helper.rb:428:in `render_projects_for_jump_box'
app/helpers/application_helper.rb:478:in `render_project_jump_box'
app/views/layouts/base.html.erb:82:in `_app_views_layouts_base_html_erb__3861390146296937614_70221623652380'
lib/redmine/sudo_mode.rb:65:in `sudo_mode'

#11 Updated by Go MAEDA 3 months ago

The following change fixes #31355#note-10.

diff --git a/lib/redmine.rb b/lib/redmine.rb
index 805418d3d..7c06ac344 100644
--- a/lib/redmine.rb
+++ b/lib/redmine.rb
@@ -43,6 +43,7 @@ require 'redmine/field_format'
 require 'redmine/menu_manager'
 require 'redmine/notifiable'
 require 'redmine/platform'
+require 'redmine/project_jump_box'
 require 'redmine/mime_type'
 require 'redmine/search'
 require 'redmine/syntax_highlighting'

#12 Updated by Go MAEDA 3 months ago

  • Status changed from Reopened to Closed

Committed the fix in #31355#note-10.

#13 Updated by Go MAEDA 3 months ago

#14 Updated by Go MAEDA 2 months ago

  • Related to Defect #31508: Add missing frozen strings and copyrights added

#15 Updated by Go MAEDA 5 days ago

  • Duplicated by Feature #7339: Add a favorites Project list. added

Also available in: Atom PDF