Project

General

Profile

Actions
Copy link

Patch #14402

closed

Plugin migration directory should use plugin directory

Added by Florian Schwab almost 11 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Plugin API
Target version:
3.1.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Currently the plugin migrate directory is fixed to "plugins/<plugin_name>/db/migrate" but the plugin API allows setting a custom directory.
I attached a patch to use the plugin directory instead. Because the default value for the plugin directory is "plugins/<plugin_name>" this should be compatible with existing plugins.

Files

migration_directory.patch (511 Bytes) migration_directory.patch Florian Schwab, 2013-07-05 23:58

Related issues

Related to Redmine - Patch #13927: Reduce coupling between plugins and the "plugins/" directoryNewJean-Baptiste Barth

Actions
Actions
Copy link
 #1

Updated by Toshi MARUYAMA over 10 years ago

  • Related to Patch #13927: Reduce coupling between plugins and the "plugins/" directory added
Actions
Copy link
 #2

Updated by Mischa The Evil almost 9 years ago

  • Target version set to 3.1.0

Florian Schwab wrote:

Currently the plugin migrate directory is fixed to "plugins/<plugin_name>/db/migrate" [...]

Indeed, source:/trunk/lib/redmine/plugin.rb@14359#L428.

[...] but the plugin API allows setting a custom directory.

Right, which is implemented in r11766 and first shipped with Redmine 2.4.0.

I attached a patch to use the plugin directory instead. Because the default value for the plugin directory is "plugins/<plugin_name>" this should be compatible with existing plugins.

Can this little fix still be included in 3.1.0?

Actions
Copy link
 #3

Updated by Jean-Philippe Lang almost 9 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed in r14364.

Actions
Copy link

Also available in: Atom PDF