Patch #20632
closed
Tab left/right buttons for project menu
Added by Felix Gliesche over 10 years ago. Updated almost 10 years ago.
Description
On small screens with many tabs in the project navigation the tabs of the far right are not visible. It would be nice if the tabs can be scrolled left / right like in the second level navigation (e.g. project settings).
This patch introduces this feature. It uses the same javascript as the second level navigation.
In order for this to work, you need the the patch attached to #20271
Files
| Settings - Project A - Redmine 2015-08-28 17-34-26.png (127 KB) Settings - Project A - Redmine 2015-08-28 17-34-26.png | Jan from Planio www.plan.io, 2015-08-28 17:35 | ||
| 0001-Apply-existing-tab-functionality-to-main-menu.patch (4.56 KB) 0001-Apply-existing-tab-functionality-to-main-menu.patch | Felix Gliesche, 2015-09-01 19:18 | ||
| 0002-Tab-buttons-add-some-user-feedback.patch (4.04 KB) 0002-Tab-buttons-add-some-user-feedback.patch | Daniel Ritz, 2016-01-25 22:39 | ||
| tabbuttons-left-not-possbile.png (17.8 KB) tabbuttons-left-not-possbile.png | Screenshot | Daniel Ritz, 2016-01-25 22:45 |
Related issues
Updated by Jan from Planio www.plan.io over 10 years ago
- Blocked by Patch #20271: Fix for multiple tabs on the same page added
Updated by Jan from Planio www.plan.io over 10 years ago
- File Settings - Project A - Redmine 2015-08-28 17-34-26.png Settings - Project A - Redmine 2015-08-28 17-34-26.png added
Here's a screenshot to illustrate this.
Updated by Felix Gliesche over 10 years ago
- File 0001-Apply-existing-tab-functionality-to-main-menu.patch 0001-Apply-existing-tab-functionality-to-main-menu.patch added
For this patch to work, we need inline-block elements instead of left floating elements. I am uploading a little update to the initial patch, that fixes the problem of space between inline-block elements (see problem and solutions to it here: https://css-tricks.com/fighting-the-space-between-inline-block-elements/) by removing new lines between the project menu's list elements.
Updated by Jan from Planio www.plan.io over 10 years ago
- File deleted (
0001-Apply-existing-tab-functionality-to-main-menu.patch)
Updated by Jan from Planio www.plan.io over 10 years ago
Just removed the old patch version
Updated by Go MAEDA over 10 years ago
- Target version set to 3.3.0
The patch can be applied cleanly to the current trunk (r14989) and works fine.
Maybe overflowed main menu have annoyed many users. Let's include this feature in Redmine 3.3.0.
Updated by Go MAEDA about 10 years ago
- Related to Patch #13892: Wraping Mainmenu on long menus added
Updated by Jean-Philippe Lang about 10 years ago
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
Patch committed, thanks.
Updated by Daniel Ritz about 10 years ago
- File 0002-Tab-buttons-add-some-user-feedback.patch 0002-Tab-buttons-add-some-user-feedback.patch added
- File tabbuttons-left-not-possbile.png tabbuttons-left-not-possbile.png added
- Hover color
- Enable/disable buttons (visually at least) when no more change is possible
- Width calculation with jQuery only, no longer hard-coded
- Remove ugly blue outline on buttons in Chrome (at least on Mac)
It's only lightly tested. Please see screenshot (and ignore the collapse-sidebar button, that's from #21808..too lazy to un-apply :)
Updated by Go MAEDA about 10 years ago
- Related to Defect #9275: If the number of modules spans over 2 lines, ugly overlapping of controls may occur. added
Updated by Toshi MARUYAMA about 10 years ago
- Status changed from Closed to Reopened
Daniel Ritz wrote:
I really like that one! One thing though: how about some user feedback by enabling/disabling the buttons? I hacked together something:
Reopened.
Updated by Jean-Philippe Lang about 10 years ago
- Status changed from Reopened to Closed
Patch by Daniel committed, thanks.
Updated by Olivier Houdas almost 10 years ago
Tabs buttons are now visible on the home page after logging in, when using Redmine 3.3.0 released yesterday. This is a bit confusing, as there are no tabs in the home page.
Updated by Go MAEDA almost 10 years ago
Olivier Houdas wrote:
Tabs buttons are now visible on the home page after logging in, when using Redmine 3.3.0 released yesterday. This is a bit confusing, as there are no tabs in the home page.
Since 3.3.0 have been released, please create a new issue to report a defect.
Updated by Olivier Houdas almost 10 years ago
Sorry, this is due to RedmineCRM contact_helpdesk plugin. I will file a bug directly to them.
Updated by Go MAEDA over 9 years ago
- Related to Defect #6624: Project horizontal menu layout doesn't wrap added