Patch #21487

Larger font for email notifications

Added by Go MAEDA over 2 years ago. Updated over 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Email notifications
Target version:3.2.1

Description

Current font size 0.8em is too small and a little bit hard to read.
Please use larger font.

larger-font-for-email-notifications.diff Magnifier (784 Bytes) Go MAEDA, 2015-12-11 10:11

japanese-text-sample.png (3.81 KB) Go MAEDA, 2015-12-14 02:35

larger-font-for-email-notifications-v2.diff Magnifier - updated patch (2015-12-19) (910 Bytes) Go MAEDA, 2015-12-19 04:38

redmine-3.1.2-thunderbird.png (102 KB) Hugues C., 2016-02-08 19:39

redmine-3.1.2-zimbra.png (140 KB) Hugues C., 2016-02-08 19:39

redmine-3.2.0-zimbra.png (94.7 KB) Hugues C., 2016-02-08 19:39

redmine-3.2.0-thunderbird-patch21487.png (121 KB) Hugues C., 2016-02-08 19:39

redmine-3.2.0-zimbra-patch21487.png (144 KB) Hugues C., 2016-02-08 19:39


Related issues

Related to Redmine - Defect #22006: Fonts too small in version 3.2.0 Closed

Associated revisions

Revision 15026
Added by Jean-Philippe Lang over 2 years ago

Larger font for email notifications (#21487).

Patch by Go MAEDA.

Revision 15228
Added by Jean-Philippe Lang over 2 years ago

Set font size in email notifications (#21487).

History

#1 Updated by Go MAEDA over 2 years ago

GMail users see notifications without any style Before Redmine 3.2.0 (#8335). But with styles (Redmine 3.2.0), fonts are very small.

I usually use Japanese characters. We use thousands of characters and many of them have intricate shape so characters which are displayed in small font and light gray are illegible.

Please see the following example (That means "This is an example of Japanese text"). Some characters(11px) are obscured.

example:

#2 Updated by Maxim KruĊĦina over 2 years ago

+1 and... thanx! :)

#3 Updated by Go MAEDA over 2 years ago

Updated the patch.

  • darker black for text color.
  • line-height for h1.

#4 Updated by Jean-Philippe Lang over 2 years ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang

Committed in r15026.

#5 Updated by Hide MATSUTANI over 2 years ago

+1 thank you Maeda-san

#6 Updated by Jean-Philippe Lang over 2 years ago

  • Status changed from Resolved to Closed

#7 Updated by Hugues C. over 2 years ago

It seems that this patch (r15026) results in fonts too big in some email clients (tested in latest Zimbra Web Client 8.6.0 and latest Thunderbird 38.5.1). Could this issue be related to r14541 or r14540 or some other changes in 3.2.0?

#8 Updated by Toshi MARUYAMA over 2 years ago

  • Status changed from Closed to Reopened

#9 Updated by Toshi MARUYAMA over 2 years ago

  • Related to Defect #22006: Fonts too small in version 3.2.0 added

#10 Updated by Go MAEDA over 2 years ago

Hugues C. wrote:

It seems that this patch (r15026) results in fonts too big in some email clients (tested in latest Zimbra Web Client 8.6.0 and latest Thunderbird 38.5.1). Could this issue be related to r14541 or r14540 or some other changes in 3.2.0?

Confirmed in Thunderbird. The following patch fixes the problem.

Index: app/views/layouts/mailer.html.erb
===================================================================
--- app/views/layouts/mailer.html.erb    (revision 15225)
+++ app/views/layouts/mailer.html.erb    (working copy)
@@ -3,6 +3,7 @@
 <style>
 body {
   font-family: Verdana, sans-serif;
+  font-size: 14px;
   line-height: 1.45em;
   color: #222;
 }

#11 Updated by Jean-Philippe Lang over 2 years ago

  • Status changed from Reopened to Closed

I've committed this change and also reduced the heading font size a bit. Thanks.

Also available in: Atom PDF