Patch #21487
closed
Larger font for email notifications
Added by Go MAEDA about 10 years ago. Updated almost 10 years ago.
Description
Current font size 0.8em is too small and a little bit hard to read.
Please use larger font.
Files
| larger-font-for-email-notifications.diff (784 Bytes) larger-font-for-email-notifications.diff | Go MAEDA, 2015-12-11 10:11 | ||
| japanese-text-sample.png (3.81 KB) japanese-text-sample.png | Go MAEDA, 2015-12-14 02:35 | ||
| larger-font-for-email-notifications-v2.diff (910 Bytes) larger-font-for-email-notifications-v2.diff | updated patch (2015-12-19) | Go MAEDA, 2015-12-19 04:38 | |
| redmine-3.1.2-thunderbird.png (102 KB) redmine-3.1.2-thunderbird.png | Hugues C., 2016-02-08 19:39 | ||
| redmine-3.1.2-zimbra.png (140 KB) redmine-3.1.2-zimbra.png | Hugues C., 2016-02-08 19:39 | ||
| redmine-3.2.0-zimbra.png (94.7 KB) redmine-3.2.0-zimbra.png | Hugues C., 2016-02-08 19:39 | ||
| redmine-3.2.0-thunderbird-patch21487.png (121 KB) redmine-3.2.0-thunderbird-patch21487.png | Hugues C., 2016-02-08 19:39 | ||
| redmine-3.2.0-zimbra-patch21487.png (144 KB) redmine-3.2.0-zimbra-patch21487.png | Hugues C., 2016-02-08 19:39 |
Related issues
Updated by Go MAEDA about 10 years ago
- File japanese-text-sample.png japanese-text-sample.png added
- Target version set to 3.2.1
GMail users see notifications without any style Before Redmine 3.2.0 (#8335). But with styles (Redmine 3.2.0), fonts are very small.
I usually use Japanese characters. We use thousands of characters and many of them have intricate shape so characters which are displayed in small font and light gray are illegible.
Please see the following example (That means "This is an example of Japanese text"). Some characters(11px) are obscured.
example:
Updated by
Updated by Go MAEDA about 10 years ago
Updated the patch.
- darker black for text color.
- line-height for h1.
Updated by Jean-Philippe Lang about 10 years ago
- Status changed from New to Resolved
- Assignee set to Jean-Philippe Lang
Committed in r15026.
Updated by 
Updated by Jean-Philippe Lang about 10 years ago
- Status changed from Resolved to Closed
Updated by Hugues C. almost 10 years ago
- File redmine-3.1.2-thunderbird.png redmine-3.1.2-thunderbird.png added
- File redmine-3.1.2-zimbra.png redmine-3.1.2-zimbra.png added
- File redmine-3.2.0-thunderbird-patch21487.png redmine-3.2.0-thunderbird-patch21487.png added
- File redmine-3.2.0-zimbra.png redmine-3.2.0-zimbra.png added
- File redmine-3.2.0-zimbra-patch21487.png redmine-3.2.0-zimbra-patch21487.png added
It seems that this patch (r15026) results in fonts too big in some email clients (tested in latest Zimbra Web Client 8.6.0 and latest Thunderbird 38.5.1). Could this issue be related to r14541 or r14540 or some other changes in 3.2.0?
- With Redmine 3.1.2 everything was fine in all clients (see redmine-3.1.2-thunderbird.png and redmine-3.1.2-zimbra.png)
- With vanilla Redmine 3.2.0 everything is too small in Zimbra even though
mailer.html.erbis the same as in 3.1.2 (see redmine-3.2.0-zimbra.png) - With the patch r15026 to
mailer.html.erbin 3.2.0 everything is too big in all clients (see redmine-3.2.0-thunderbird-patch21487.png and redmine-3.2.0-zimbra-patch21487.png)
Updated by Toshi MARUYAMA almost 10 years ago
- Status changed from Closed to Reopened
Updated by Toshi MARUYAMA almost 10 years ago
- Related to Defect #22006: Fonts too small in version 3.2.0 added
Updated by Go MAEDA almost 10 years ago
Hugues C. wrote:
It seems that this patch (r15026) results in fonts too big in some email clients (tested in latest Zimbra Web Client 8.6.0 and latest Thunderbird 38.5.1). Could this issue be related to r14541 or r14540 or some other changes in 3.2.0?
Confirmed in Thunderbird. The following patch fixes the problem.
Index: app/views/layouts/mailer.html.erb
===================================================================
--- app/views/layouts/mailer.html.erb (revision 15225)
+++ app/views/layouts/mailer.html.erb (working copy)
@@ -3,6 +3,7 @@
<style>
body {
font-family: Verdana, sans-serif;
+ font-size: 14px;
line-height: 1.45em;
color: #222;
}
Updated by Jean-Philippe Lang almost 10 years ago
- Status changed from Reopened to Closed
I've committed this change and also reduced the heading font size a bit. Thanks.