Project

General

Profile

Actions

Feature #24568

closed

Show locked users in 'Users' filter for 'Spent time' report

Added by Sergey User over 7 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Time tracking
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

It is not possible to select a locked user for 'Spent time' report using 'User' filter option (only Active users are shown). While this behavior is correct for other places where users are selected (only active users can do something), it is not correct for this particular report, as it still contains workload data for locked users. In other words, the data (workload entries for locked users) is visible in the report, but it is not possible to filter it properly for these particular users.

It is suggested to resolve it as follows:
1. Make it a default behavior to show ALL users in the 'Users' filter for this particular report;
2. Separate locked users in the list from active, for instance:

<<me>>
--- Active users ---
<List of active users>
--- Locked users ---
<List of locked users>

3. (Optional, in case of backward compatibility is required) Add Administrative option to disable this default behavior (default: Off): 'Hide locked users from Spent time report'.


Files

timelog_report.png (159 KB) timelog_report.png Marius BĂLTEANU, 2017-10-26 00:45
timelog_report_before.png (158 KB) timelog_report_before.png Marius BĂLTEANU, 2017-10-26 00:46
24568_show_locked_users_in_timelog_report.patch (2.74 KB) 24568_show_locked_users_in_timelog_report.patch Marius BĂLTEANU, 2017-10-26 00:59

Related issues

Related to Redmine - Feature #11069: Ability to search tasks of Locked UsersClosed

Actions
Related to Redmine - Feature #15201: Filter "Assignee" should contain locked usersClosedGo MAEDA

Actions
Related to Redmine - Feature #29042: Add links to Users, Projects and Versions (at least) in timelog reportClosedGo MAEDA

Actions
Actions #1

Updated by Go MAEDA over 7 years ago

  • Related to Feature #11069: Ability to search tasks of Locked Users added
Actions #2

Updated by Go MAEDA over 7 years ago

  • Category set to Time tracking
Actions #3

Updated by Esteve Navas about 7 years ago

I would want to second this, and I will explain why:

Where I work we should do tracking of past workers, because they contact with customers and when they are not in the company anymore we lock them, but new issues with customers can involve old workers since we have to track any activity of the issue from the start.

So, for us locked users appearing in the custom-field type user is necessary, otherwise we have to create a custom field type list and keep it updated everytime any worker is not here anymore, and that is annoying.

I've been looking inside the code but I don't know much about Ruby, so I don't want to mess around :(

Thank you.

Actions #4

Updated by Jürgen Depicker almost 7 years ago

This is related to #15201. See #15201-13.

Actions #5

Updated by Marius BĂLTEANU almost 7 years ago

I've added a patch to #15201 that implements this feature.

Actions #6

Updated by Toshi MARUYAMA almost 7 years ago

  • Related to Feature #15201: Filter "Assignee" should contain locked users added
Actions #7

Updated by Marius BĂLTEANU over 6 years ago

  • Assignee set to Marius BĂLTEANU
Actions #8

Updated by Marius BĂLTEANU over 6 years ago

I made a patch that adds the usual links to Users, Projects and Versions (at least) in the timelog report. In this way, the locked users will have the grey out style and can be differentiated by the active users.

Before

After

I think that it'll be useful to deliver this change together with #15201.

Actions #9

Updated by Marius BĂLTEANU over 6 years ago

  • File deleted (24568_show_locked_users_in_timelog_report.patch)
Actions #11

Updated by Go MAEDA almost 6 years ago

  • Target version set to Candidate for next major release
Actions #12

Updated by Go MAEDA almost 6 years ago

The patch #24568#note-10 looks good.

But I think it would be better to create a new issue for the patch. The reasons are as follows:

  • The feature requested in this issue has already been implemented by #15201.
  • Your patch brings an improvement differ from the original request.

Marius, could you create a new issue for the patch?

Actions #13

Updated by Marius BĂLTEANU almost 6 years ago

  • Status changed from New to Closed
  • Assignee deleted (Marius BĂLTEANU)
  • Target version deleted (Candidate for next major release)
  • Resolution set to Fixed

Go MAEDA wrote:

The patch #24568#note-10 looks good.

But I think it would be better to create a new issue for the patch. The reasons are as follows:

  • The feature requested in this issue has already been implemented by #15201.
  • Your patch brings an improvement differ from the original request.

Marius, could you create a new issue for the patch?

Done (#29042).

In this case, I'm closing this one as fixed by r17371 in #15201.

Actions #14

Updated by Marius BĂLTEANU almost 6 years ago

  • Related to Feature #29042: Add links to Users, Projects and Versions (at least) in timelog report added
Actions

Also available in: Atom PDF