QueriesController can not handle subclass of IssueQuery
|Assignee:||Jean-Philippe Lang||% Done:|
I have a PivotQuery, it's a subclass of IssueQuery.
But Query don't think it is subclass of himself.
So, r15635 let my plugin down.
I changed QueriesController to fix it.
def query_class Query.get_subclass(params[:type] || 'IssueQuery') end
def query_class get_query_class(params[:type] || 'IssueQuery') end def get_query_class(class_name) klass = nil begin klass = class_name.to_s.classify.constantize rescue # invalid class name end unless klass && klass.new.is_a?(Query) klass = nil end klass end
#2 Updated by Jean-Philippe Lang almost 3 years ago
We should be able to fix
Index: lib/redmine/subclass_factory.rb =================================================================== --- lib/redmine/subclass_factory.rb (revision 16379) +++ lib/redmine/subclass_factory.rb (working copy) @@ -29,7 +29,7 @@ rescue # invalid class name end - unless subclasses.include? klass + unless descendants.include? klass klass = nil end klass
Would it work for you?
#7 Updated by Marius BALTEANU 1 day ago
Alexander Meindl wrote:
This change is only available in trunk, but not in Branch 4.1-stable - as this issue shows. Can we get this to 4.1-stable branch?
It is already on 4.1-stable branch, pleasee source:branches/4.1-stable/lib/redmine/subclass_factory.rb#L34.