Project

General

Profile

Actions
Copy link

Patch #25265

closed

QueriesController can not handle subclass of IssueQuery

Added by Haihan Ji about 7 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Issues filter
Target version:
4.1.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

I have a PivotQuery, it's a subclass of IssueQuery.
But Query don't think it is subclass of himself.
So, r15635 let my plugin down.

I changed QueriesController to fix it.

OLD CODE:

def query_class
  Query.get_subclass(params[:type] || 'IssueQuery')
end

New Code
def query_class
  get_query_class(params[:type] || 'IssueQuery')
end

def get_query_class(class_name)
  klass = nil
  begin
    klass = class_name.to_s.classify.constantize
  rescue
    # invalid class name
  end
  unless klass && klass.new.is_a?(Query)
    klass = nil
  end
  klass    
end

Actions
Copy link

Also available in: Atom PDF