Patch #26030

Like issues and news comments, want to specify the display order of the forum's reply.

Added by Minoru Maeda 7 months ago. Updated 5 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Forums
Target version:4.1.0

Description

This patch also applies the setting order of comments in "My account" to the forum.

reply_order.patch Magnifier (2.82 KB) Minoru Maeda, 2017-05-24 11:23

reply_display_order_with_pre_page.patch Magnifier (3.87 KB) Minoru Maeda, 2017-05-25 08:51


Related issues

Related to Redmine - Feature #26033: Respect "Objects per page" option when displaying forum r... New
Related to Redmine - Patch #11120: Order replies of messages boards based on user preference New

History

#1 Updated by Go MAEDA 7 months ago

Thank you for posting the patch.
But I think it would be better not to assume that the value of REPLIES_PER_PAGE constant is always 25. The test in your patch may fail if #26033 is implemented.

#2 Updated by Minoru Maeda 7 months ago

Hello, Go MAEDA. Thank you for your advice.
I improved it in order of reply display considering "per_page".

#3 Updated by Toshi MARUYAMA 6 months ago

  • Related to Feature #26033: Respect "Objects per page" option when displaying forum replies added

#4 Updated by Toshi MARUYAMA 6 months ago

  • Related to Patch #11120: Order replies of messages boards based on user preference added

#5 Updated by Go MAEDA 6 months ago

  • Target version set to 4.1.0

The patch works fine for me. And it also implements #26033.
Setting target version to 3.5.0.

Also available in: Atom PDF