Patch #26655

Additional icon for contextmenu

Added by Felix Gliesche over 1 year ago. Updated 7 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:UI
Target version:4.0.0

Description

The contextmenu is a very helpful feature that can increase the productivity while working with redmine. Many people don't know of this great feature because it is only triggered by a right mouse click, which is not a common user interaction on the web. In order to make this feature more prominent this patch adds an icon to table rows that have a contextmenu, which allows to trigger the appearance of the contextmenu with a regular mouse click.

As there was no icon with three dots available in the famfamfam available, we created our own by using an existing icon with a dot.

This gif shows this new icon in action on the issues table:

contextmenu.gif (71.4 KB) Felix Gliesche, 2017-08-09 12:37

vertical.png (109 KB) Marius BALTEANU, 2017-08-14 21:58

mastodon-context-menu-button@2x.png (35.8 KB) Go MAEDA, 2017-08-16 02:52

26555-list_html_erb-for-r16971.diff Magnifier (1.55 KB) Go MAEDA, 2018-01-28 02:35

3_bullets.png - Icon for context menu (1.22 KB) Go MAEDA, 2018-01-28 02:35

icon-for-subtasks@2x.png (18 KB) Go MAEDA, 2018-01-28 05:28

0001-Use-button-as-additional-option-for-contextmenu.patch Magnifier (18.9 KB) Felix Gliesche, 2018-04-19 16:05


Related issues

Related to Redmine - Feature #5711: Make Bulk Edit menu more apparent... New 2010-06-18
Related to Redmine - Feature #28829: Add right-click context menu to the contextual area of an... Reopened
Duplicated by Redmine - Feature #1590: Awkward way of accessing shortcut menu in issue list Closed 2008-07-06
Duplicated by Redmine - Defect #5739: Direct access to Issue update from issue list Closed 2010-06-23
Duplicated by Redmine - Feature #29074: Add "Edit" function to entries in "Spent Time" block appr... Closed

Associated revisions

Revision 17252
Added by Go MAEDA 8 months ago

Use button as additional option for contextmenu (#26655).

Patch by Felix Gliesche.

Revision 17253
Added by Go MAEDA 8 months ago

Add button_actions string to locales (#26655).

Revision 17254
Added by Go MAEDA 8 months ago

Reverted r17252 and r17253 (#26655).

The change breaks the test suite.

Revision 17298
Added by Go MAEDA 7 months ago

Use button as additional option for contextmenu (#26655).

Patch by Felix Gliesche.

Revision 17302
Added by Go MAEDA 7 months ago

Add button_actions string to locales (#26655).

History

#1 Updated by Jan from Planio www.plan.io over 1 year ago

  • Target version set to Candidate for next minor release

#2 Updated by Jan from Planio www.plan.io over 1 year ago

  • File deleted (contextmenu.gif)

#3 Updated by Felix Gliesche over 1 year ago

#4 Updated by Jan from Planio www.plan.io over 1 year ago

  • Tracker changed from Defect to Patch

#5 Updated by Go MAEDA over 1 year ago

+1

Felix Gliesche wrote:

Many people don't know of this great feature because it is only triggered by a right mouse click, which is not a common user interaction on the web.

I think it is exactly right. It is very good idea to make the context menu obvious.

#6 Updated by Luis Blasco over 1 year ago

You're absolutely right. Context menu is not used, too "hidden". This is a very good solution.

#7 Updated by Jan from Planio www.plan.io over 1 year ago

The patch is based on user research we did for Planio Redmine Hosting. We also surveyed a number of other platforms which use item list representations and context menus (Dropbox, Nextcloud, box.net, etc.). A horizontal three dotted icon seems by far to be the most common trigger for a context menu these days. Right click without alternative was only present in a few examples (e.g. Google Drive). The feature will be rolling out at Planio soon and I would love for this to become part of Redmine as well!

#8 Updated by Go MAEDA over 1 year ago

  • Target version changed from Candidate for next minor release to 4.1.0

The icon greatly improves usability.
Setting target version to 4.1.0.

#9 Updated by Marius BALTEANU over 1 year ago

Very nice feature, especially that it will make the context menu available on the mobile.

It looks good also with a vertical three dotted icon.

#10 Updated by Felix Schäfer over 1 year ago

Marius BALTEANU wrote:

It looks good also with a vertical three dotted icon.

This would be confusing as the vertical dots are already used as drag and drop handlers for trackers, enumerations, statuses and so on.

#11 Updated by Marius BALTEANU over 1 year ago

Felix Schäfer wrote:

Marius BALTEANU wrote:

It looks good also with a vertical three dotted icon.

This would be confusing as the vertical dots are already used as drag and drop handlers for trackers, enumerations, statuses and so on.

From my knowledge, the drag and drop handlers have a green arrow as icon. Anyway, it is not so important how the dots are displayed, both options look good to me and also, the dots can be easily rotated only from CSS. I just wanted to point out this alternative.

#12 Updated by Felix Schäfer over 1 year ago

Marius BALTEANU wrote:

From my knowledge, the drag and drop handlers have a green arrow as icon.

You are right, I am sorry, the 3 dots are used in a theme, and vertical dots are used as drag and drop handlers in Gmail for example too.

#13 Updated by Felix Gliesche over 1 year ago

  • File 0001-Use-button-as-additional-option-for-contextmenu.patch added

I am attaching an updated patch, that sets correct colspan when grouping issue lists.

#14 Updated by Jan from Planio www.plan.io over 1 year ago

  • File deleted (0001-Use-button-as-additional-option-for-contextmenu.patch)

#15 Updated by Go MAEDA over 1 year ago

FYI:
Mastodon (social network server) uses horizontal three dots button for context menu.

#16 Updated by Toshi MARUYAMA about 1 year ago

  • Description updated (diff)

#17 Updated by Go MAEDA about 1 year ago

  • Duplicated by Feature #1590: Awkward way of accessing shortcut menu in issue list added

#18 Updated by Mischa The Evil about 1 year ago

  • Related to Feature #5711: Make Bulk Edit menu more apparent... added

#19 Updated by Go MAEDA 10 months ago

I made a slight change to the patch because I couldn't apply to the current trunk (r16971 and later).

And the patch doesn't include 3_bullets.png, so I stole the icon from Planio :)

#20 Updated by Go MAEDA 10 months ago

I found a small problem that the context menu icon is displayed in a wrong position for subtasks. No problem for related issues. I also confirmed the very similar problem in my Planio account.

Felix Gliesche, could you fix this?

#21 Updated by Felix Gliesche 10 months ago

Go MAEDA wrote:

I found a small problem that the context menu icon is displayed in a wrong position for subtasks. No problem for related issues. I also confirmed the very similar problem in my Planio account.

Felix Gliesche, could you fix this?

Sure, I'll have a look into it.

#22 Updated by Felix Gliesche 10 months ago

  • File 0001-Use-button-as-additional-option-for-contextmenu.patch added

I am uploading a patch, that should apply to the current trunk. The problem, you are referencing to is related to missing mobile optimiziation. I added missing styles to public/stylesheets/responsive.css as you can see in the updated version of the patch.

#23 Updated by Felix Gliesche 10 months ago

  • File 0001-Use-button-as-additional-option-for-contextmenu.patch added

I had to update the patch (see attached). Could you please delete the previous one, to avoid confusion?

#24 Updated by Felix Gliesche 10 months ago

  • File 0001-Use-button-as-additional-option-for-contextmenu.patch added

I found, that the text shines through, due to right padding, which is not necessary on mobile devices. I removed this, whit this updated patch. Please use this one ;)

#25 Updated by Marius BALTEANU 10 months ago

  • File deleted (0001-Use-button-as-additional-option-for-contextmenu.patch)

#26 Updated by Marius BALTEANU 10 months ago

  • File deleted (0001-Use-button-as-additional-option-for-contextmenu.patch)

#27 Updated by Marius BALTEANU 10 months ago

  • File deleted (0001-Use-button-as-additional-option-for-contextmenu.patch)

#28 Updated by Go MAEDA 10 months ago

  • Status changed from Needs feedback to New

Thank you for updating the patch. Now it works perfectly. I think this feature should be a part of Redmine 4.0 / 4.1.

#29 Updated by Go MAEDA 8 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version changed from 4.1.0 to 4.0.0

Committed. Thank you for sharing this great improvement.

#30 Updated by Go MAEDA 8 months ago

  • Status changed from Closed to Reopened
  • Assignee deleted (Go MAEDA)
  • Target version changed from 4.0.0 to 4.1.0

Reverted r17252 and r17253 because the patch breaks the test suite.

#31 Updated by Go MAEDA 7 months ago

  • Assignee set to Felix Gliesche

After applying the patch, an exception is raised if a user who does not have "Manage related issues" permission opens an issue with one or more related issues. You can also confirm the problem by running test/functional/issues_controller_test.rb.

But I noticed that this bug has already fixed in Planio. Could you kindly provide a patch based on the current Planio's code base?

#32 Updated by Felix Gliesche 7 months ago

Go MAEDA wrote:

After applying the patch, an exception is raised if a user who does not have "Manage related issues" permission opens an issue with one or more related issues. You can also confirm the problem by running test/functional/issues_controller_test.rb.

But I noticed that this bug has already fixed in Planio. Could you kindly provide a patch based on the current Planio's code base?

Sure, I will have a look into it. Already working on the patch, so that it does not break the test suite.

#33 Updated by Felix Gliesche 7 months ago

Go MAEDA wrote:

Committed. Thank you for sharing this great improvement.

I am uploading the updated patch. It does not break the test suite and fixes the problem for users without the "manage related issues" permission that you mentioned.

#34 Updated by Jan from Planio www.plan.io 7 months ago

  • File deleted (0001-Use-button-as-additional-option-for-contextmenu.patch)

#35 Updated by Go MAEDA 7 months ago

  • Status changed from Reopened to Resolved

Committed. Thank you so much for updating the patch.

#36 Updated by Go MAEDA 7 months ago

  • Status changed from Resolved to Closed

#37 Updated by Go MAEDA 7 months ago

  • Target version changed from 4.1.0 to 4.0.0

#38 Updated by Go MAEDA 7 months ago

  • Assignee changed from Felix Gliesche to Go MAEDA

#39 Updated by Go MAEDA 6 months ago

  • Related to Feature #28829: Add right-click context menu to the contextual area of an issue added

#40 Updated by Go MAEDA 5 months ago

  • Duplicated by Defect #5739: Direct access to Issue update from issue list added

#41 Updated by Marius BALTEANU 5 months ago

  • Duplicated by Feature #29074: Add "Edit" function to entries in "Spent Time" block appropriately added

Also available in: Atom PDF