Defect #27122
closed
Filter for version name should be case-insensitive
Added by Nastya Fedorova over 6 years ago. Updated almost 6 years ago.
0%
Description
Search for version name does not work for case sensitive names
Files
| Case_sensitive_filter_for_version_name_.patch (622 Bytes) Case_sensitive_filter_for_version_name_.patch | Nastya Fedorova, 2017-10-04 15:17 | ||
| case_sensitive_filter_for_version_name_2.patch (1.29 KB) case_sensitive_filter_for_version_name_2.patch | Mizuki ISHIKAWA, 2018-03-22 01:31 | ||
| case_sensitive_filter_for_version_name_3.patch (1.13 KB) case_sensitive_filter_for_version_name_3.patch | Mizuki ISHIKAWA, 2018-04-24 10:20 | ||
| case_sensitive_filter_for_version_name_4.patch (1.17 KB) case_sensitive_filter_for_version_name_4.patch | Mizuki ISHIKAWA, 2018-04-24 10:29 |
Updated by Anonymous
Updated by Holger Just over 6 years ago
There is a database-agnostic helper method for a case-insensititive LIKE. You should be able to just use this:
where([Redmine::Database.like("Version.table_name}.name", '?'), pattern])
MySQL is case-insensitive by default. Searching on Postgres should work with this method. As for the other supported databases: I'm not fully sure whether they do the right thing there. If they don't show the correct behavior then the Redmine::Database.like method should be fixed.
Updated by Mischa The Evil over 6 years ago
- File deleted (
photo_2017-09-01_22-08-39.jpg)
Updated by Toshi MARUYAMA over 6 years ago
- Category changed from Search engine to Roadmap
- Target version set to 4.1.0
Updated by Mizuki ISHIKAWA about 6 years ago
- File case_sensitive_filter_for_version_name_2.patch case_sensitive_filter_for_version_name_2.patch added
Attach the patch that added the test to the code written by Holger Just ( #27122#note-2 ).
Updated by Mizuki ISHIKAWA about 6 years ago
- File case_sensitive_filter_for_version_name_3.patch case_sensitive_filter_for_version_name_3.patch added
I fixed the test code.
Updated by Mizuki ISHIKAWA about 6 years ago
- File case_sensitive_filter_for_version_name_4.patch case_sensitive_filter_for_version_name_4.patch added
There was also a problem with the test of case_sensitive_filter_for_version_name_3.patch, so I fixed it.
Updated by Go MAEDA about 6 years ago
- Tracker changed from Patch to Defect
- Subject changed from Case insensitive filter for version name to Filter for version name should be case-insensitive
- Category changed from Roadmap to Project settings
- Target version changed from 4.1.0 to 3.4.6
This is a defect rather than a feature. I am setting target version to 3.4.6.
Updated by Go MAEDA about 6 years ago
- Status changed from New to Resolved
- Assignee set to Go MAEDA
Updated by Go MAEDA about 6 years ago
- Status changed from Resolved to Closed
- Resolution set to Fixed
Committed. Thank you all for detecting and fixing this issue.