Redmine

It is a nice idea. Many people have requested to add more columns to the list of subtasks and related issues. It will be the solution to the request if we can move to the issues list with one click.

+1 - I would dearly love this.

Specofically whjen I am in the Roadmap I can jump from the simple list of issues in a target verson such as:

http://www.redmine.org/versions/127

To a query on either All Issues:

http://www.redmine.org/projects/redmine/issues?fixed_version_id=127&set_filter=1&status_id=%2A

Or just Open or Closed. This is hugely useful as I can then sort, group and filter to get the answers I need.

However when subtasks are grouped under a parent task there is no shortcut. I can search all issues by Parent (which is often enough) but:

1. I would like to see this as a shortcut on the issue page (just above subtasks)
2. I often have nested groups of tasks and so really want to see all subtasks and not just those that are a direct child of the current task.

SELECT i.* 
FROM issues i
JOIN issues p 
    ON p.root_id = i.root_id 
    AND p.lft<i.lft 
    AND p.rgt>i.rgt
WHERE p.id = @PARENT_ID;

+1, it's a green light from me ;-)

IMHO, it looks like a nice improvement. :-)

Maybe #28471#note-11 can be fixed by using "contains" operator instead of "is" operator.

Here's some test code. Since I'm not very used to rails testing, I'm not sure if it's sufficient enough.

Index: test/functional/issues_controller_test.rb
===================================================================
--- test/functional/issues_controller_test.rb   (Revision 20333)
+++ test/functional/issues_controller_test.rb   (Arbeitskopie)
@@ -2299,6 +2299,49 @@
     end
   end

+  def test_show_should_show_subtasks_links_to_queries
+    child = Issue.
+      create!(
+        :project_id => 1, :author_id => 1, :tracker_id => 1,
+        :parent_issue_id => 1, :subject => 'Child issue'
+      )
+    get(:show, :params => {:id => 1})
+    assert_response :success
+    assert_select 'div#issue_tree' do
+      assert_select 'p' do
+        assert_select 'a', :text => '1 issue'
+        assert_select 'a', :text => '1 open'
+      end
+    end
+    Issue.
+      create!(
+        :project_id => 1, :author_id => 1, :tracker_id => 1,
+        :parent_issue_id => child.id, :subject => 'Child of child'
+    )
+    get(:show, :params => {:id => 1})
+    assert_response :success
+    assert_select 'div#issue_tree' do
+      assert_select 'p' do
+        assert_select 'a', :text => '2 issues'
+        assert_select 'a', :text => '2 open'
+      end
+    end
+    Issue.
+      create!(
+        :project_id => 1, :author_id => 1, :tracker_id => 1,
+        :parent_issue_id => 1, :status_id => 5, :subject => 'Closed child issue'
+    )
+    get(:show, :params => {:id => 1})
+    assert_response :success
+    assert_select 'div#issue_tree' do
+      assert_select 'p' do
+        assert_select 'a', :text => '3 issues'
+        assert_select 'a', :text => '2 open'
+        assert_select 'a', :text => '1 closed'
+      end
+    end
+  end
+
   def test_show_should_list_parents
     issue = Issue.
               create!(

Marius BALTEANU wrote:

I've fixed the issue by casting the values returned from the database to boolean. Now the tests pass on all three database types: https://gitlab.com/redmine-org/redmine/-/pipelines/225982433

Thank you for posting the 0001-Include-only-visible-issues-in-subtasks-stats.patch but the test fails if you run it with Ruby 2.4.

$ ruby test/functional/issues_controller_test.rb 
Run options: --seed 49701

# Running:

......................F

Failure:
IssuesControllerTest#test_show_should_show_subtasks_stats [test/functional/issues_controller_test.rb:2354]:
Expected at least 1 element matching "span.open a[href="/issues?parent_id=~1&set_filter=true&status_id=o"]", found 0..
Expected 0 to be >= 1.

bin/rails test test/functional/issues_controller_test.rb:2343

....................................S..............................................................................................................................................S.....................................................................................................................................................S....................................F

Failure:
IssuesControllerTest#test_show_subtasks_stats_should_not_link_if_issue_has_zero_open_or_closed_subtasks [test/functional/issues_controller_test.rb:2367]:
Expected at least 1 element matching "span.open a[href="/issues?parent_id=~1&set_filter=true&status_id=o"]", found 0..
Expected 0 to be >= 1.

bin/rails test test/functional/issues_controller_test.rb:2361

..............................

This is because issue_path method returns a different value depending on the version of Ruby.

# Ruby 2.4
(byebug) issues_path(parent_id: "~1", set_filter: true)
"/issues?parent_id=%7E1&set_filter=true" 

# Ruby 2.5 or later
(byebug) issues_path(parent_id: "~1", set_filter: true)
"/issues?parent_id=~1&set_filter=true"