Project

General

Profile

Actions

Patch #30435

closed

Replace float rules with flexbox for content and sidebar block

Added by Anonymous about 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

What this patch does:
1. It moves the sidebar to be rendered after the content block in base.html.erb, since natural flow of HTML should be from left to right, so no point in rendering sidebar before the content block, because it doesn't match our base layout.

2. It sets the #main block to a flexbox and removes a redundant background color definition rule from it.

3. It changes the % based width of the sidebar to a fixed 220px (if you think it should be wider, feedback is welcome), because on wide screens 22% is quite a lot of space!

4. #content block is the only one that will stretch now.


Files

main-block-fixes.diff (2.46 KB) main-block-fixes.diff Anonymous, 2019-01-15 12:41
main-block-fixes-no-swap.diff (1.57 KB) main-block-fixes-no-swap.diff Anonymous, 2019-01-17 07:45
sidebar.png (289 KB) sidebar.png Marius BĂLTEANU, 2019-01-17 21:28
main-block-fixes-no-swap-min-max.diff (1.67 KB) main-block-fixes-no-swap-min-max.diff Anonymous, 2019-02-09 00:34
main-block-fixes-no-swap-min-max_no_shrink.diff (1.68 KB) main-block-fixes-no-swap-min-max_no_shrink.diff Max J.'s patch with flexbox constraints Bernhard Rohloff, 2019-02-14 18:28
30435-screenshot-20190225.png (29.9 KB) 30435-screenshot-20190225.png Go MAEDA, 2019-02-25 07:23
current.png (421 KB) current.png Marius BĂLTEANU, 2019-03-27 23:46
after.png (455 KB) after.png Marius BĂLTEANU, 2019-03-27 23:46
flex_for_content_and_sidebar.patch (1.8 KB) flex_for_content_and_sidebar.patch Marius BĂLTEANU, 2019-03-27 23:50
table-bug@2x.png (79.7 KB) table-bug@2x.png Go MAEDA, 2019-04-28 12:46
responsive-multiresolution-sidebar.patch (1.12 KB) responsive-multiresolution-sidebar.patch Anonymous, 2019-09-04 19:23

Related issues

Related to Redmine - Patch #32037: Constrain sidebar width on different resolutionsClosedGo MAEDA

Actions
Actions

Also available in: Atom PDF