Patch #30448

Remove wrapper2 and wrapper3 wrapping containers

Added by Max Johansson about 1 month ago. Updated about 1 month ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI
Target version:4.1.0

Description

I think maybe it would be good to remove the two wrappers (wrapper2 and wrapper3), as there is really no purpose in them, other than making the need to add specific extra rules just for these containers, because children containers often behave depending on the rules set to their parent. And so, wrappers can spawn a blocking behaviour for the rules applied to their far inner children in one way or another.

I think it will be good to leave only the top wrapper (at least for now) which would wrap everything except for the footer container, this is to achieve sticky footer design later which will be more easily achievable like this, or else footer winds up in the middle of the screen when there is little to no content on pages (I have quite a big display). The method I'm suggesting is to stretch the html, body and wrapper 100% in height, by setting height:100% rule to them, and then apply margin-top: -25px to both the footer and margin-bottom: -25px to the wrapper.

Then #content containers also will not need min-height: 600px rule in the future.

wrapper2-wrapper3-removal.patch Magnifier (1.91 KB) Max Johansson, 2019-01-16 18:26


Related issues

Related to Redmine - Patch #30231: Operation: "Unwraping The Mine" or conerns about how elem... Closed

History

#1 Updated by Marius BALTEANU about 1 month ago

  • Related to Patch #30231: Operation: "Unwraping The Mine" or conerns about how elements are wrapped added

#2 Updated by Max Johansson about 1 month ago

Update: while developing quick html concept layouts for #30451 (#30451#note-3 and #30451#note-5), I came to conclusion that maybe we don't need even the first #wrapper as well, things could just be rerouted to body tag and sticky footer feature is also achievable without the wrapper.

#3 Updated by Go MAEDA about 1 month ago

  • Assignee set to Jean-Philippe Lang
  • Target version set to 4.1.0

div.wrapper2 and div.wrapper3 were added in r3429 and r10794 by Jean-Philippe Lang. We can remove those elements if he is OK.

Also available in: Atom PDF