Patch #31278
Change Delete button name to Delete issue
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | Issues | |||
| Target version: | 5.0.0 |
Description
I noticed some users would click on the edit button to edit a commentary, and then on the delete issue button on the bottom of the page (on the action menu), and then confirm. It happens sometimes, most of our users don't have the permission to delete an issue, but I've had project managers doing this from time to time when they are tired.
The patch is very trivial, it changes the name of the button from "Delete" to "Delete Issue". So as it is not mistaken for "Delete what is selected", which is the expected behavior for some users.
button-delete-patch.patch 
(1.78 KB)
0021-Change-Delete-issue-button-behaviour.patch
- For Redmine 4.1 (and others)
(2.49 KB)
31278.patch
(7.04 KB)
Related issues
Associated revisions
Change Delete button name to Delete issue (#31278).
Contributed by Frederico Camara.
History
#1
Updated by Frederico Camara over 2 years ago
BTW: I probably am forgetting the tests.
#2
Updated by Frederico Camara over 2 years ago
Tests checked. No tests for this.
#3
Updated by Marius BALTEANU over 2 years ago
Which version of Redmine do you use?
#4
Updated by Go MAEDA 11 months ago
- Related to Feature #34494: Rename the save, edit and delete buttons on the query form to clarify the scope added
#6
Updated by Frederico Camara 11 months ago
Slightly different Patch (for Redmine 4.1), renames button to Delete Issue and shows the button only on top menu (hides it from the menu near the issue history).
#7
Updated by Marius BALTEANU 11 months ago
Frederico Camara wrote:
Slightly different Patch (for Redmine 4.1), renames button to Delete Issue and shows the button only on top menu (hides it from the menu near the issue history).
Frederico, another solution to avoid the confusion was posted as part of #34703, please take a look.
#8
Updated by Frederico Camara 11 months ago
Marius BALTEANU wrote:
Frederico Camara wrote:
Slightly different Patch (for Redmine 4.1), renames button to Delete Issue and shows the button only on top menu (hides it from the menu near the issue history).
Frederico, another solution to avoid the confusion was posted as part of #34703, please take a look.
Marius, your patch addresses a different problem. My problem is the user sometimes mistakes the "delete this comment" icon for the "delete this issue icon". Both have the same caption and depending on how you configurer your redmine, can sometimes be close on the bottom part of the interface. That I know, it happened three times where I work, with different users. And it was a pain restoring the data from the logs, and the attachments from the backups.
My patch mostly addresses the delete issue icon on the bottom part of the interface, I don't mind the non destructive actions:- it changes the caption to differentiate between the two actions
- it changes the actions menu behaviour at the bottom part of the interface:
- at first I was removing the actions menu entirely, because it was a repeat. But it is very helpful there
- now I am removing just the delete issue from the bottom actions menu. If the user wants to delete the issue, he can use the button on the actions menu on the top.
#9
Updated by Go MAEDA 16 days ago
- File 31278.patch added
+1
I have seen so many accidents that people accidentally delete an issue. In my observation, such accidents often occur in the following situations. I believe that the suggested change greatly reduces such accidents.
- When trying to delete an issue comment which is displayed at the bottom, they misunderstand the "Delete" in the action menu at the bottom as a button to delete a comment
- When trying to remove a relation to another issue, they misunderstand the "Delete" in the context menu as a menu item to remove the relation
I am attaching an updated patch. It uses an existing i18n string button_delete_object added by #34494 instead of adding a new string. Also, it updates tests.