Patch #31278

Change Delete button name to Delete Issue

Added by Frederico Camara over 2 years ago. Updated 6 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Issues
Target version:-

Description

I noticed some users would click on the edit button to edit a commentary, and then on the delete issue button on the bottom of the page (on the action menu), and then confirm. It happens sometimes, most of our users don't have the permission to delete an issue, but I've had project managers doing this from time to time when they are tired.

The patch is very trivial, it changes the name of the button from "Delete" to "Delete Issue". So as it is not mistaken for "Delete what is selected", which is the expected behavior for some users.

button-delete-patch.patch Magnifier (1.78 KB) Frederico Camara, 2019-04-29 21:38

0021-Change-Delete-issue-button-behaviour.patch Magnifier - For Redmine 4.1 (and others) (2.49 KB) Frederico Camara, 2021-02-08 14:20


Related issues

Related to Redmine - Patch #34494: Rename the save, edit and delete buttons on the query form New

History

#1 Updated by Frederico Camara over 2 years ago

BTW: I probably am forgetting the tests.

#2 Updated by Frederico Camara over 2 years ago

Tests checked. No tests for this.

#3 Updated by Marius BALTEANU over 2 years ago

Which version of Redmine do you use?

#4 Updated by Go MAEDA 6 months ago

  • Related to Patch #34494: Rename the save, edit and delete buttons on the query form added

#5 Updated by Go MAEDA 6 months ago

Another solution has been posted as #34494.

#6 Updated by Frederico Camara 6 months ago

Slightly different Patch (for Redmine 4.1), renames button to Delete Issue and shows the button only on top menu (hides it from the menu near the issue history).

#7 Updated by Marius BALTEANU 6 months ago

Frederico Camara wrote:

Slightly different Patch (for Redmine 4.1), renames button to Delete Issue and shows the button only on top menu (hides it from the menu near the issue history).

Frederico, another solution to avoid the confusion was posted as part of #34703, please take a look.

#8 Updated by Frederico Camara 6 months ago

Marius BALTEANU wrote:

Frederico Camara wrote:

Slightly different Patch (for Redmine 4.1), renames button to Delete Issue and shows the button only on top menu (hides it from the menu near the issue history).

Frederico, another solution to avoid the confusion was posted as part of #34703, please take a look.

Marius, your patch addresses a different problem. My problem is the user sometimes mistakes the "delete this comment" icon for the "delete this issue icon". Both have the same caption and depending on how you configurer your redmine, can sometimes be close on the bottom part of the interface. That I know, it happened three times where I work, with different users. And it was a pain restoring the data from the logs, and the attachments from the backups.

My patch mostly addresses the delete issue icon on the bottom part of the interface, I don't mind the non destructive actions:
  • it changes the caption to differentiate between the two actions
  • it changes the actions menu behaviour at the bottom part of the interface:
    • at first I was removing the actions menu entirely, because it was a repeat. But it is very helpful there
    • now I am removing just the delete issue from the bottom actions menu. If the user wants to delete the issue, he can use the button on the actions menu on the top.

Also available in: Atom PDF