Patch #31433
closed
Use "icon icon-*" classes for sort-handler, collapsible fieldsets and collapsible versions
Added by Marius BĂLTEANU almost 7 years ago. Updated over 6 years ago.
Files
Related issues
Updated by Go MAEDA almost 7 years ago
- Assignee set to Marius BĂLTEANU
Could you write the intention of this change?
Updated by Marius BĂLTEANU almost 7 years ago
- Related to Patch #24313: Use the regular "icon icon-*" classes for all elements with icons added
Updated by Marius BĂLTEANU almost 7 years ago
- Related to Patch #28605: Add the missing icon class to the items with icons from the contextual menu added
Updated by Marius BĂLTEANU almost 7 years ago
Updated by Go MAEDA almost 7 years ago
- Status changed from New to Closed
- Assignee changed from Marius BĂLTEANU to Go MAEDA
Committed the patch. Thanks.
Updated by Marius BĂLTEANU almost 7 years ago
- Status changed from Closed to Reopened
- Assignee changed from Go MAEDA to Marius BĂLTEANU
I broke something, I'll add a patch to fix it later.
Updated by Marius BĂLTEANU almost 7 years ago
- File 0001-Fix-missing-icons.patch 0001-Fix-missing-icons.patch added
- File 0002-Use-icon-icon-classes-for-expandable-elements.patch 0002-Use-icon-icon-classes-for-expandable-elements.patch added
- File 0003-Use-icon-icon-classes-for-sort-elements.patch 0003-Use-icon-icon-classes-for-sort-elements.patch added
Here are three more patches:
- 0001-Fix-missing-icons.patch fixes an issue introduced by me (r18204)
- 0002-Use-icon-icon-classes-for-expandable-elements.patch and 0003-Use-icon-icon-classes-for-sort-elements.patch add the "icon icon-*" classes to more elements.
Updated by Go MAEDA almost 7 years ago
- Status changed from Reopened to Closed
- Assignee changed from Marius BĂLTEANU to Go MAEDA
Marius BALTEANU wrote:
Here are three more patches:
- 0001-Fix-missing-icons.patch fixes an issue introduced by me (r18204)
- 0002-Use-icon-icon-classes-for-expandable-elements.patch and 0003-Use-icon-icon-classes-for-sort-elements.patch add the "icon icon-*" classes to more elements.
Committed the patches. Thanks.
Updated by Marius BĂLTEANU almost 7 years ago
Go MAEDA wrote:
Marius BALTEANU wrote:
Here are three more patches:
- 0001-Fix-missing-icons.patch fixes an issue introduced by me (r18204)
- 0002-Use-icon-icon-classes-for-expandable-elements.patch and 0003-Use-icon-icon-classes-for-sort-elements.patch add the "icon icon-*" classes to more elements.Committed the patches. Thanks.
Thanks! I'll take a look again to check if it's everything ok.
Updated by Marius BĂLTEANU almost 7 years ago
- Related to Defect #31496: Switch between toggle plus and minus icons for toggle multi select added
Updated by Yuichi HARADA over 6 years ago
Collapsed/Expanded of filters and options in "Issues list, Spent time, Gantt, Calendar" do not worked using for IE11.
I think that maybe the toggleClass is the cause.
source:trunk/public/javascripts/application.js@18204#L75
Updated by Marius BĂLTEANU over 6 years ago
- Assignee changed from Go MAEDA to Marius BĂLTEANU
Updated by Marius BĂLTEANU over 6 years ago
- Status changed from Reopened to Closed
- Assignee changed from Marius BĂLTEANU to Go MAEDA
The problem is caused by #3058 and it'll be fixed by the patch from #3058#note-96.
Updated by Marius BĂLTEANU over 6 years ago
- File 0001-Fix-missing-icon-classes.patch 0001-Fix-missing-icon-classes.patch added
- File projects_list.png projects_list.png added
- File permissions_report.png permissions_report.png added
- Status changed from Closed to Reopened
I've just found 2 small issues where the expander icon is missing.
Project list:
Permissions report:
Attached the fix.
Updated by Go MAEDA over 6 years ago
- Status changed from Reopened to Closed
Marius BALTEANU wrote:
I've just found 2 small issues where the expander icon is missing.
Confirmed the issues and committed the patch in r18897. Thanks.