Patch #31573

Show each journal entry from issue history in a box

Added by Marius BALTEANU about 1 year ago. Updated about 1 year ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:Marius BALTEANU% Done:

0%

Category:UI
Target version:-

Description

IMHO, the issue history doesn't have a clear structure, you need to look after each Gravatar or "Updated by" line to see where the journal starts/ends. In top, there is a border applied on the entire block (left, right and bottom) in order to prevent accidental deletion of an issue (#26662), but for me, even if fixes the confusion with delete buttons, it makes the journal entries harder to be distinguished.

I would like to propose the following design changes for the issue history:

1. Show each journal entry in a box (like projects)
2. Connect each journal entry with a small line
3. Apply the red border for the private journals on the entire journal, not only on the text.

I'm attaching the patches and the screenshots with before and after.

Current:

After

If you like the changes, I think it will be nice to deliver them in 4.1.0, together with the other UI changes.

new_issue_history.png (371 KB) Marius BALTEANU, 2019-06-16 16:32

issue_history.png (351 KB) Marius BALTEANU, 2019-06-16 16:32

0001-Wrap-each-entry-in-a-box.patch Magnifier (6.93 KB) Marius BALTEANU, 2019-06-21 00:03

0003-Show-red-border-on-journal-entry.patch Magnifier (1.16 KB) Marius BALTEANU, 2019-06-21 00:03

0002-Connect-journal-boxes.patch Magnifier (9.8 KB) Marius BALTEANU, 2019-06-21 00:03

Screenshot 2019-06-21 at 01.04.22.png (134 KB) Marius BALTEANU, 2019-06-21 00:04

Screenshot 2019-06-21 at 01.04.07.png (227 KB) Marius BALTEANU, 2019-06-21 00:04

Screenshot 2019-06-21 at 01.04.15.png (131 KB) Marius BALTEANU, 2019-06-21 00:04

History

#1 Updated by Marius BALTEANU about 1 year ago

  • File deleted (0001-Wrap-each-journal-in-a-box.patch)

#2 Updated by Marius BALTEANU about 1 year ago

  • File deleted (0002-Connect-journal-boxes.patch)

#3 Updated by Marius BALTEANU about 1 year ago

  • File deleted (0003-Show-red-border-on-journal-entry.patch)

#4 Updated by Marius BALTEANU about 1 year ago

I broke something with my initial patches, I'll upload them again.

#5 Updated by Marius BALTEANU about 1 year ago

  • File 0001-Wrap-each-journal-in-a-box.patch added
  • File 0002-Connect-journal-boxes.patch added
  • File 0003-Show-red-border-on-journal-entry.patch added

#6 Updated by Marius BALTEANU about 1 year ago

  • Assignee set to Marius BALTEANU

I need to update these patches now that #3058 was committed .

#7 Updated by Marius BALTEANU about 1 year ago

  • File deleted (0001-Wrap-each-journal-in-a-box.patch)

#8 Updated by Marius BALTEANU about 1 year ago

  • File deleted (0002-Connect-journal-boxes.patch)

#9 Updated by Marius BALTEANU about 1 year ago

  • File deleted (0003-Show-red-border-on-journal-entry.patch)

#11 Updated by Dmitry Makurin about 1 year ago

I would keep journal h4 bottom border since it clearly separates h4' text/contextual with notes content.

Also available in: Atom PDF