Patch #36429

Make issue tabs DOM more consistent

Added by Felix Schäfer 13 days ago. Updated 9 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:UI
Target version:5.0.0

Description

It is currently difficult to consistently style the tabs in the issue history because the DOMs are different.

36429-more_consistent_issue_tab_dom.patch Magnifier (2.82 KB) Felix Schäfer, 2022-01-13 17:08


Related issues

Related to Redmine - Patch #31573: Show each journal entry from issue history in a box New

Associated revisions

Revision 21367
Added by Go MAEDA 9 days ago

Make issue tabs DOM more consistent (#36429).

Patch by Felix Schäfer.

History

#1 Updated by Felix Schäfer 13 days ago

The attached patch makes the DOM for the time spent and change sets tabs more consistent with the history tabs.

#2 Updated by Bernhard Rohloff 12 days ago

Patch looks good to me...
+1

#3 Updated by Go MAEDA 12 days ago

  • Target version set to 5.0.0

Setting the target version to 5.0.0.

#4 Updated by Dmitry Makurin 12 days ago

Marius did a great job in #31573. I guess this and #31573 could be done in one series of patches since both issues have the same purpose.

#5 Updated by Go MAEDA 11 days ago

Dmitry Makurin wrote:

Marius did a great job in #31573. I guess this and #31573 could be done in one series of patches since both issues have the same purpose.

I would like to commit this patch first without waiting for the result of the discussion on #31573.

This patch just fixes the consistency of DOM and makes it easy for theme developers to apply styles. This is a necessary fix regardless of whether we merge #31573 or not. And this patch does not have a significant negative impact on #31573.

#6 Updated by Go MAEDA 9 days ago

  • Subject changed from Make issue tabs more consistent to Make issue tabs DOM more consistent
  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you.

#7 Updated by Marius BALTEANU 9 days ago

  • Related to Patch #31573: Show each journal entry from issue history in a box added

Also available in: Atom PDF