Defect #32765

##123 syntax for linking to issues: Title cannot be distinguished from following text

Added by Robert Schneider 10 months ago. Updated 7 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Text formatting
Target version:4.1.1
Resolution:Fixed Affected version:4.1.0

Description

Relates to #29488.

The displayed title of the linked issue has the same style as the normal text, what could lead to confusing information. A minimal fix would be to add the link color also to the title (bold or not bold).

highlight.png (108 KB) Marius BALTEANU, 2020-01-12 21:05

link.png (105 KB) Marius BALTEANU, 2020-01-12 21:05

fix_32765.patch Magnifier (4.7 KB) Marius BALTEANU, 2020-01-21 21:50

fix_32765_v2.patch Magnifier (4.57 KB) Marius BALTEANU, 2020-04-05 11:07


Related issues

Related to Redmine - Patch #29488: ##123 syntax for linking to issues with tracker name and ... Closed

Associated revisions

Revision 19663
Added by Jean-Philippe Lang 7 months ago

##123 syntax for linking to issues: Title cannot be distinguished from following text (#32765).

Patch by Marius BALTEANU.

Revision 19668
Added by Jean-Philippe Lang 7 months ago

Merged r19663 to 4.1-stable (#32765).

History

#1 Updated by Go MAEDA 10 months ago

  • Related to Patch #29488: ##123 syntax for linking to issues with tracker name and subject added

#2 Updated by Marius BALTEANU 9 months ago

I agree that we should have different styles.

Attached two screenshots:
1. Subject as link (as Robert proposed)

2. Highlight the entire text using the style from inline code:

#3 Updated by Bernhard Rohloff 9 months ago

I think formatting the subject as link is more consistent and fits better than the inline code style.
+1 for the link variant.

#4 Updated by Go MAEDA 9 months ago

I prefer the first option (render subject as link). It is consistent with links to other objects such as message and user.

#5 Updated by Jean-Philippe Lang 9 months ago

  • Target version set to 4.1.1

#6 Updated by Marius BALTEANU 9 months ago

Here is a patch that includes the subject in the linked text, but I think that we should change the title as well because right now we show the entire subject and the title shows the subject truncated at 100 characters and the status. Maybe it is enough to show "label_status: status".

#7 Updated by Go MAEDA 7 months ago

Marius BALTEANU wrote:

but I think that we should change the title as well because right now we show the entire subject and the title shows the subject truncated at 100 characters and the status. Maybe it is enough to show "label_status: status".

I agree.

#8 Updated by Marius BALTEANU 7 months ago

Go MAEDA wrote:

Marius BALTEANU wrote:

but I think that we should change the title as well because right now we show the entire subject and the title shows the subject truncated at 100 characters and the status. Maybe it is enough to show "label_status: status".

I agree.

Updated the patch.

#9 Updated by Jean-Philippe Lang 7 months ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Patch committed, thanks!

#10 Updated by Jean-Philippe Lang 7 months ago

  • Status changed from Resolved to Closed

Merged.

Also available in: Atom PDF