Redmine

Redmine 3.4:

Issue,2007-3,2007-4,Total time
[none],"",7.65,7.65
Bug #1: Cannot print recipes,154.25,"",154.25
Bug #3: Error 281 when updating a recipe,"",1.00,1.00
Total time,154.25,8.65,162.90

trunk:

Issue,2007-3,2007-4,Total time
[none],"",7.65,7.65
#1,154.25,"",154.25
#3,"",1.00,1.00
Total time,154.25,8.65,162.90

I added a test to cover for this regressions and a possible fix for the issue in my first patch.
I'm not sure if a change in a place that central will have negative side effects.
I checked the few places where format_object was used outside of HTML templates and helpers and ran all unit tests locally and it seemed fine to me. What do you think?

My second patch just contains a minor source code improvement: Redmine::Helpers::TimeReport currently never uses the issue argument (which doesn't seem to be set to any value in that controller anyways), so I removed it to prevent confusion.

Oh sorry I realized I included an unnecessary line in the unit test.... this is the updated patch

Kevin Fischer wrote:

I added a test to cover for this regressions and a possible fix for the issue in my first patch.
I'm not sure if a change in a place that central will have negative side effects.
I checked the few places where format_object was used outside of HTML templates and helpers and ran all unit tests locally and it seemed fine to me. What do you think?

Thanks Kevin for writing the patch. I think it's safer to fix this in timelog_helper.rb as it was before #29042, please find attached a slightly modified patch. Test results here

My second patch just contains a minor source code improvement: Redmine::Helpers::TimeReport currently never uses the issue argument (which doesn't seem to be set to any value in that controller anyways), so I removed it to prevent confusion.

Please open a new ticket with this patch.

Committed the patch. Thank you.