Project

General

Profile

Actions

Defect #35090

closed

Permission check of the setting button on the issues page mismatches button semantics

Added by Felix Schäfer about 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

In source:/tags/4.2.0/app/views/issues/index.html.erb#L16 the link goes to the issues tab of the project settings. The button is only shown if the user has the manage_categories permission but the permission required for this tab is edit_project source:/tags/4.2.0/app/helpers/projects_helper.rb#L28

Note that this is only a UI issue, the button might be shown to users that cannot see the tab that it links to or the button might not be shown to users that would be able to see the tab that it links too, but upon following the link the correct permission is checked. There also is no information disclosure associated with this issue.


Files

fix-35090.patch (1.76 KB) fix-35090.patch Takenori TAKAKI, 2021-10-07 06:46

Related issues

Related to Redmine - Feature #22090: Make project settings more accessibleClosedJean-Philippe Lang

Actions
Actions #1

Updated by Holger Just about 3 years ago

  • Description updated (diff)
Actions #2

Updated by Takenori TAKAKI over 2 years ago

I made a patch to fix & test the issue #35090, and attach it.

Actions #3

Updated by Go MAEDA over 2 years ago

  • Related to Feature #22090: Make project settings more accessible added
Actions #4

Updated by Go MAEDA over 2 years ago

  • Status changed from New to Confirmed
  • Target version set to 4.1.5

Setting the target version to 4.1.5.

Actions #5

Updated by Go MAEDA over 2 years ago

  • Target version changed from 4.1.5 to 4.1.6
Actions #6

Updated by Go MAEDA over 2 years ago

  • Subject changed from Permission check mismatches button semantics to Permission check of the setting button on the issues page mismatches button semantics
  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for your contribution.

Actions #7

Updated by Go MAEDA over 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF