Project

General

Profile

Actions

Feature #35189

closed

New email notification option "For any event on my bookmarked projects"

Added by Yoann AMICHAUD about 3 years ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Category:
Email notifications
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Wont fix

Description

For now, if you want to be informed about all events of a huge projects portfolio, I have to update the list behind "For any events of the selected projects only..." quite often.
It would be really great if we can receive all notifications of the bookmarked projects adding a new option in the notification option list : "For any events of my bookmarked projects only..."


Files

feature-35189.patch (9.89 KB) feature-35189.patch Mizuki ISHIKAWA, 2021-06-17 06:56
screenshot.png (135 KB) screenshot.png Mizuki ISHIKAWA, 2021-06-17 06:59
feature-35189-v2.patch (9.39 KB) feature-35189-v2.patch Go MAEDA, 2023-10-21 09:30
feature-35189-v3.patch (9.91 KB) feature-35189-v3.patch Go MAEDA, 2023-11-02 07:54
feature-35189-v4.patch (8.1 KB) feature-35189-v4.patch Marius BĂLTEANU, 2023-11-05 10:50

Related issues

Related to Redmine - Defect #39854: "For any event on my bookmarked projects" option not sending notifications for non-member bookmarked projectsClosed

Actions
Has duplicate Redmine - Feature #15542: "For any event on the selected projects only" as a star on project overviewClosed

Actions
Actions #1

Updated by Marius BĂLTEANU about 3 years ago

  • Target version set to Candidate for next major release

Nice ideea, indeed.

Actions #2

Updated by Mizuki ISHIKAWA about 3 years ago

I wrote a patch to add this feature.

Actions #3

Updated by Go MAEDA almost 2 years ago

  • Target version changed from Candidate for next major release to 5.1.0

Setting the target version to 5.1.0.

Actions #4

Updated by Go MAEDA 8 months ago

I think the most similar existing notification option to the new option that the patch implement is "For any event on the selected projects only..." (internal name: "selected"), so I suggest changing the internal name of the option from "only_bookmarked_projects" to "bookmarked".

Here is an updated patch.

Actions #5

Updated by Go MAEDA 8 months ago

Updated the patch to remove repeated code from User#update_notified_project_ids.

Actions #6

Updated by Marius BĂLTEANU 8 months ago

  • File feature-35189-v3.patch added

@Go Maeda, what do you think about the reworked attached patch? I tried to simplify the code a little bit.

Actions #7

Updated by Marius BĂLTEANU 8 months ago

  • File deleted (feature-35189-v3.patch)
Actions #9

Updated by Marius BĂLTEANU 7 months ago

  • Assignee set to Go MAEDA

@Go MAEDA, I'm assign you to review the patch and to commit it if the changes are ok.

Actions #10

Updated by Go MAEDA 7 months ago

  • Subject changed from New email notification option - events of my bookmarked projects to New email notification option "For any event on my bookmarked projects"
  • Status changed from New to Closed
  • Resolution set to Fixed

Committed the patch. Thank you.

Marius BALTEANU wrote in #note-6:

@Go Maeda, what do you think about the reworked attached patch? I tried to simplify the code a little bit.

Thank you for improving the patch!

Actions #11

Updated by Marius BĂLTEANU 6 months ago

  • Related to Defect #39854: "For any event on my bookmarked projects" option not sending notifications for non-member bookmarked projects added
Actions #12

Updated by Marius BĂLTEANU 5 months ago

  • Assignee changed from Go MAEDA to Marius BĂLTEANU
  • Target version deleted (6.0.0)
  • Resolution changed from Fixed to Wont fix

I've reverted the changes added here after we agreed that handling notifications based on the bookmarked flag is not the best ideea (please see the discussions from #39854).

We will improve the notification settings to allow users to easier watch projects (including public projects).

Actions #13

Updated by Holger Just 3 months ago

  • Has duplicate Feature #15542: "For any event on the selected projects only" as a star on project overview added
Actions

Also available in: Atom PDF