Project

General

Profile

Actions

Defect #37730

closed

Missing copyright headers in source files

Added by Mischa The Evil over 1 year ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

The source files in the following list are missing proper copyright headers:

View file list...

Given that all these files are distributed as part of the Redmine core, I'd say that it would be correct if each of them would contain appropriate copyright headers (even the plugin initialization, rake task and CSS files).

1 since the content of this file is derived from DotClear, it might be correct to add the original DotClear copyright headers (like e.g. source:/trunk/public/javascripts/jstoolbar) to this file.


Files

copyright.diff (51.2 KB) copyright.diff Karel Pičman, 2023-10-10 14:48
Actions #1

Updated by Go MAEDA over 1 year ago

  • Target version set to 5.1.0
Actions #2

Updated by Go MAEDA 5 months ago

  • Target version changed from 5.1.0 to 6.0.0
Actions #3

Updated by Karel Pičman 5 months ago

Here is a patch covering missing copyright headers.

Actions #4

Updated by Marius BĂLTEANU 3 months ago

  • Status changed from New to Closed
  • Assignee set to Marius BĂLTEANU
  • Resolution set to Fixed

Committed, thanks!

Actions #5

Updated by Mischa The Evil 3 months ago

  • Status changed from Closed to Reopened

Thanks for fixing this. However, given our current asset serving mechanism, I'd have chosen to only add a short copyright notice to the CSS and JS assets instead.
With the current change we increase bandwidth usage more than necessary IMHO and as such we might want to (re-)consider this...

Actions #6

Updated by Mischa The Evil 3 months ago

Additionally, r22482 also adds a header to acts_as_tree plugin files, which is obviously incorrect (it's in fact a vendored third-party core component, see source:/trunk/lib/plugins/acts_as_tree/README).

Actions #7

Updated by Marius BĂLTEANU about 2 months ago

Thanks Mischa for review the changes, I have fixed now all the reported issues.

Actions #8

Updated by Marius BĂLTEANU about 2 months ago

  • Status changed from Reopened to Closed
Actions #9

Updated by Go MAEDA about 2 months ago

  • Status changed from Closed to Reopened

I think we should not add Redmine's copyright header to source:trunk/public/stylesheets/tribute-5.1.3.css because the file is a part of Tribute distribution.

https://github.com/zurb/tribute/blob/master/dist/tribute.css

Actions #10

Updated by Marius BĂLTEANU about 2 months ago

  • Status changed from Reopened to Closed

Go MAEDA wrote in #note-9:

I think we should not add Redmine's copyright header to source:trunk/public/stylesheets/tribute-5.1.3.css because the file is a part of Tribute distribution.

https://github.com/zurb/tribute/blob/master/dist/tribute.css

Agree, fixed, thanks!

Actions

Also available in: Atom PDF