Project

General

Profile

Actions

Defect #41714

closed

Replace search and magnifier icons with SVG icon

Defect #41714: Replace search and magnifier icons with SVG icon

Added by Bernhard Rohloff about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Category:
UI
Target version:
Resolution:
Fixed
Affected version:

Description

There's also the checkmark showing the current project. It's different from the normal checkmark already so I think it's not that big of a deal.


Files


Related issues 2 (0 open — 2 closed)

Related to Redmine - Feature #23980: Replace icon images with Tabler SVG iconsClosedMarius BĂLTEANUActions
Has duplicate Redmine - Defect #41877: Add 'Related Issue' icon in Issue page is still the old one.ClosedActions

Updated by Bernhard Rohloff about 2 years ago Actions #1

  • Related to Feature #23980: Replace icon images with Tabler SVG icons added

Updated by Marius BĂLTEANU about 2 years ago Actions #2

  • Target version set to 6.0.1

Updated by Marius BĂLTEANU about 2 years ago Actions #3

  • Target version changed from 6.0.1 to 6.0.2

Updated by Marius BĂLTEANU about 2 years ago Actions #4

I've attached a patch that replaces the legacy search magnifier in project jump and also in the search file on mobile view.

Updated by Takenori TAKAKI about 2 years ago Actions #5

I've confirmed that the quick-jump menu icon has been updated to an SVG using the patch attached in #note-4.
Additionally, I noticed that the legacy search magnifier icon still appears in the parent_issue field on the Issue edit screen, so I created an additional patch to update it to an SVG as well.

→→

I've attached the additional patch here.

Updated by Takenori TAKAKI almost 2 years ago Actions #6

As reported in Issue #41877, the Add 'Related Issue' icon also appears to be an old icon.

I suggest an additional patch to be added to #note-5.

Updated by Mischa The Evil almost 2 years ago Actions #7

@takenory: This issue (use of legacy search magnifier icon) seems to be affecting several more places within the UI as well:
  1. user/group search in 'Add watchers dialog'
  2. user/group search in 'New Member dialog'
  3. issue search in 'Add related issue to changeset form'

1 and 2 can be seen in the screenshots you have posted in #41853#note-1 and 3 is based on the actual code itself (source:/trunk/app/views/repositories/_related_issues.html.erb@23352#L35).
Most likely there are more throughout the whole system..

Updated by Marius BĂLTEANU almost 2 years ago Actions #8

  • Subject changed from The search icon in the quick-jump menu still shows the old icon. to Replace search and magnifier icons with SVG icon
  • Status changed from New to Resolved
  • Resolution set to Fixed

For now I've changed only from CSS the background image for autocomplete fields to the new SVG icon. The proper implementation requires to many changes.

Updated by Marius BĂLTEANU almost 2 years ago Actions #9

  • Has duplicate Defect #41877: Add 'Related Issue' icon in Issue page is still the old one. added

Updated by Marius BĂLTEANU almost 2 years ago Actions #10

  • Status changed from Resolved to Closed
Actions

Also available in: PDF Atom