Feature #9634: Show locked badge for locked wiki pages - Redmine

Actions

Copy link

Feature #9634

closed

Show locked badge for locked wiki pages

Added by Shlomi Fish over 13 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Go MAEDA

Category:

Wiki

Target version:

4.1.0

Start date:

2011-11-22

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Description

At the moment, wiki pages (such as the http://redmine.org/ homepage), for users without editing privileges, don't display any visible control for editing the page that indicate that this is the case. As a result, one wonders why they cannot be edited and what to do about it. This is the greyed-out-menu-items issue in UI usability all over again, only worse.

Please give a visible indicator for: 1. Why it cannot be done. 2. What to do about it.

Regards,

— Shlomi Fish

Files

Download all files

locked-version@2x.png (23 KB) locked-version@2x.png		Go MAEDA, 2019-04-10 06:05
without_title.png (126 KB) without_title.png		Marius BĂLTEANU, 2019-04-15 23:01
bottom.png (125 KB) bottom.png		Marius BĂLTEANU, 2019-04-15 23:05
locked-badge-bottom@2x.png (43.6 KB) locked-badge-bottom@2x.png		Go MAEDA, 2019-04-25 09:52
0001-Show-locked-badge-for-protected-pages.patch (2.02 KB) 0001-Show-locked-badge-for-protected-pages.patch		Marius BĂLTEANU, 2019-04-26 12:59

Related issues

Actions

Copy link

Updated by Felix Dominguez over 13 years ago

Can you take a screenshot or two detailing what you see. I don't see controls for editing on the redmine homepage under IE.

Actions

Copy link

Updated by Shlomi Fish over 13 years ago

Felix Dominguez wrote:

Can you take a screenshot or two detailing what you see. I don't see controls for editing on the redmine homepage under IE.

That's the point - there aren't any, while there should be. I wondered how to edit the page (because it is indicated to be a wiki page), but they don't know.

Actions

Copy link

Updated by Mischa The Evil over 13 years ago

In this case the wiki page you were trying to edit (overview) is locked.

IMHO it would be good to have that "state" publicly visible with some sort of indicator. Perhaps re-use of the already available unlock icon can help here...

Actions

Copy link

Updated by Jean-Philippe Lang over 13 years ago

Tracker changed from Defect to Feature

Actions

Copy link

Updated by Jean-Philippe Lang over 13 years ago

Subject changed from Wiki Pages without Editing Permissions/Privileges Should Still Explain that this is the case to Locked wiki pages should still explain why they can't be edited

Actions

Copy link

Updated by Go MAEDA over 6 years ago

Related to Defect #30312: Cannot know whether a wiki page is locked unless clicking the drop-down menu added

Actions

Copy link

Updated by Marius BĂLTEANU over 6 years ago

Assignee set to Marius BĂLTEANU

Actions

Copy link

Updated by Go MAEDA about 6 years ago

File locked-version@2x.png locked-version@2x.png added
Target version set to Unplanned backlogs

I think it would be nice if the locked status of a wiki page is shown next to the title, as already implemented for versions by #29391.

Actions

Copy link

Updated by Marius BĂLTEANU about 6 years ago

File without_title.png without_title.png added
File bottom.png bottom.png added

We cannot implement this using the solution with the badge because the title is part of the wiki page content and not a required property (sorry for my wrong proposal). It will look very weird when the user doesn't addd a title to the page, please see the below example:

What do you think if we add the information to the bottom of the page, next to "Updated by ... ago" ?

Actions

Copy link

#10

Updated by Go MAEDA about 6 years ago

File locked-badge-bottom@2x.png locked-badge-bottom@2x.png added

Marius BALTEANU wrote:

What do you think if we add the information to the bottom of the page, next to "Updated by ... ago" ?

I think it is one of the ideas. But I really like the badge style you made.

IMHO it will be even nicer if the badge is used like the following. What do you think?

Actions

Copy link

#11

Updated by Marius BĂLTEANU about 6 years ago

Go MAEDA wrote:

I think it is one of the ideas. But I really like the badge style you made.

IMHO it will be even nicer if the badge is used like the following. What do you think?

Totally agree.

Actions

Copy link

#12

Updated by Marius BĂLTEANU about 6 years ago

File 0001-Show-locked-badge-for-protected-pages.patch added

Here is a first version of the patch, but I'm not sure regarding the permissions.

@Go Maeda, when we should show the badge?

Actions

Copy link

#13

Updated by Marius BĂLTEANU about 6 years ago

Related to deleted (Defect #30312: Cannot know whether a wiki page is locked unless clicking the drop-down menu)

Actions

Copy link

#14

Updated by Marius BĂLTEANU about 6 years ago

Has duplicate Defect #30312: Cannot know whether a wiki page is locked unless clicking the drop-down menu added

Actions

Copy link

#15

Updated by Go MAEDA about 6 years ago

Target version changed from Unplanned backlogs to Candidate for next major release

Marius BALTEANU wrote:

Here is a first version of the patch, but I'm not sure regarding the permissions.

@Go Maeda, when we should show the badge?

I don't think we have to care about permissions because the information about whether a wiki page is protected is not confidential. I think the badge should always be displayed.

Actions

Copy link

#16

Updated by Marius BĂLTEANU about 6 years ago

File deleted (~~0001-Show-locked-badge-for-protected-pages.patch~~)

Actions

Copy link

#17

Updated by Marius BĂLTEANU about 6 years ago

File 0001-Show-locked-badge-for-protected-pages.patch 0001-Show-locked-badge-for-protected-pages.patch added

Go MAEDA wrote:

Marius BALTEANU wrote:

Here is a first version of the patch, but I'm not sure regarding the permissions.

@Go Maeda, when we should show the badge?

I don't think we have to care about permissions because the information about whether a wiki page is protected is not confidential. I think the badge should always be displayed.

Here is the updated patch that always shows the locked badge.

Actions

Copy link

#18