Feature #9634
Show locked badge for locked wiki pages
Status: | Closed | Start date: | 2011-11-22 | |
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | % Done: | 0% | ||
Category: | Wiki | |||
Target version: | 4.1.0 | |||
Resolution: | Fixed |
Description
At the moment, wiki pages (such as the http://redmine.org/ homepage), for users without editing privileges, don't display any visible control for editing the page that indicate that this is the case. As a result, one wonders why they cannot be edited and what to do about it. This is the greyed-out-menu-items issue in UI usability all over again, only worse.
Please give a visible indicator for: 1. Why it cannot be done. 2. What to do about it.
Regards,
— Shlomi Fish
Related issues
Associated revisions
Show locked badge for protected pages (#9634).
Patch by Marius BALTEANU.
History
#1
Updated by Felix Dominguez over 10 years ago
Can you take a screenshot or two detailing what you see. I don't see controls for editing on the redmine homepage under IE.
#2
Updated by Shlomi Fish over 10 years ago
Felix Dominguez wrote:
Can you take a screenshot or two detailing what you see. I don't see controls for editing on the redmine homepage under IE.
That's the point - there aren't any, while there should be. I wondered how to edit the page (because it is indicated to be a wiki page), but they don't know.
#3
Updated by Mischa The Evil over 10 years ago
#4
Updated by Jean-Philippe Lang over 10 years ago
- Tracker changed from Defect to Feature
#5
Updated by Jean-Philippe Lang over 10 years ago
- Subject changed from Wiki Pages without Editing Permissions/Privileges Should Still Explain that this is the case to Locked wiki pages should still explain why they can't be edited
#6
Updated by Go MAEDA over 3 years ago
- Related to Defect #30312: Cannot know whether a wiki page is locked unless clicking the drop-down menu added
#7
Updated by Marius BALTEANU over 3 years ago
- Assignee set to Marius BALTEANU
#8
Updated by Go MAEDA over 3 years ago
- File locked-version@2x.png added
- Target version set to Unplanned backlogs
I think it would be nice if the locked status of a wiki page is shown next to the title, as already implemented for versions by #29391.
#9
Updated by Marius BALTEANU over 3 years ago
- File without_title.png added
- File bottom.png added
We cannot implement this using the solution with the badge because the title is part of the wiki page content and not a required property (sorry for my wrong proposal). It will look very weird when the user doesn't addd a title to the page, please see the below example:
What do you think if we add the information to the bottom of the page, next to "Updated by ... ago" ?
#10
Updated by Go MAEDA over 3 years ago
- File locked-badge-bottom@2x.png added
Marius BALTEANU wrote:
What do you think if we add the information to the bottom of the page, next to "Updated by ... ago" ?
I think it is one of the ideas. But I really like the badge style you made.
IMHO it will be even nicer if the badge is used like the following. What do you think?
#11
Updated by Marius BALTEANU over 3 years ago
Go MAEDA wrote:
I think it is one of the ideas. But I really like the badge style you made.
IMHO it will be even nicer if the badge is used like the following. What do you think?
Totally agree.
#12
Updated by Marius BALTEANU over 3 years ago
- File 0001-Show-locked-badge-for-protected-pages.patch added
Here is a first version of the patch, but I'm not sure regarding the permissions.
@Go Maeda, when we should show the badge?
#13
Updated by Marius BALTEANU over 3 years ago
- Related to deleted (Defect #30312: Cannot know whether a wiki page is locked unless clicking the drop-down menu)
#14
Updated by Marius BALTEANU over 3 years ago
- Duplicated by Defect #30312: Cannot know whether a wiki page is locked unless clicking the drop-down menu added
#15
Updated by Go MAEDA over 3 years ago
- Target version changed from Unplanned backlogs to Candidate for next major release
Marius BALTEANU wrote:
Here is a first version of the patch, but I'm not sure regarding the permissions.
@Go Maeda, when we should show the badge?
I don't think we have to care about permissions because the information about whether a wiki page is protected is not confidential. I think the badge should always be displayed.
#16
Updated by Marius BALTEANU over 3 years ago
- File deleted (
0001-Show-locked-badge-for-protected-pages.patch)
#17
Updated by Marius BALTEANU over 3 years ago
Go MAEDA wrote:
Marius BALTEANU wrote:
Here is a first version of the patch, but I'm not sure regarding the permissions.
@Go Maeda, when we should show the badge?
I don't think we have to care about permissions because the information about whether a wiki page is protected is not confidential. I think the badge should always be displayed.
Here is the updated patch that always shows the locked badge.
#18
Updated by Go MAEDA over 3 years ago
- Target version changed from Candidate for next major release to 4.1.0
Marius BALTEANU wrote:
Here is the updated patch that always shows the locked badge.
Thanks. Setting the target version to 4.1.0.
#19
Updated by Go MAEDA over 3 years ago
- Status changed from New to Closed
- Assignee changed from Marius BALTEANU to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thanks.
#20
Updated by Go MAEDA over 3 years ago
- Related to Defect #31269: Fix Japanese translation for status_locked added
#21
Updated by Go MAEDA over 3 years ago
- Subject changed from Locked wiki pages should still explain why they can't be edited to Show locked badge for locked wiki pages