Activity
From 2018-08-12 to 2018-08-14
2018-08-14
-
17:53 Patch #29359: Switch to mini_mime from mime-types
- my results (ruby 2.5.0):
with the patch (mini_mime) -
17:19 Patch #29359: Switch to mini_mime from mime-types
- Pavel Rosický wrote:
> 29359-remove-known-types-hash.patch - .downcase shouldn't be removed, both EXTENSIONS[] and lookup_by_extension expect lower-case
Fixed.
> ...
You are right. Maybe I pasted a wrong result. The following resu... -
13:18 Patch #29359: Switch to mini_mime from mime-types
- 29359-remove-known-types-hash.patch - .downcase shouldn't be removed, both EXTENSIONS[] and lookup_by_extension expect lower-case
and the benchmark looks odd, in r17467 both known/unknown scenarios were cached in a class var, so I wou... -
12:09 Patch #29359 (Reopened): Switch to mini_mime from mime-types
- mini_mime 1.0.1 supports @lookup_by_extension@. We can remove the cache mechanism using @known_types@ hash by making use of the new method. Attaching a patch to remove the hash.
Even without the cache mechanism, @Redmine::MimeTypes.of... -
11:58 Patch #29383: Update mini_mime gem (~> 1.0.1)
- Pavel Rosický wrote:
> mini_mime 1.0.1 was released
> ...
Great! I will reopen #29359 and attach a new patch. -
11:09 Patch #29383 (Closed): Update mini_mime gem (~> 1.0.1)
- mini_mime 1.0.1 was released
as discussed in #29359, now we can use lookup_by_extension directly -
11:14 Defect #29365: MailHandlerTest#test_add_issue_with_localized_attributes fails with mail gem 2.7.0
- I would recommend to wait until 2.7.1 is out.
btw 2.7.1.rc1 passed the test.
2018-08-13
-
16:27 Defect #668: Date input fields don't respect date format settings
- +1.
We're currently upgrading from Redmine 2.4.3 to 3.4.6.stable, and it strikes me that this input date formatting problem is around for so long. So for us, it got worse:
* Our output date formatting is dd/MM/yyyy
* In 2.4.3 you ... -
14:49 Patch #29378: More call_hooks for projects, issue statusses, time entries, etc.
- Do you strictly need these controller hooks to distinguish updates done by the controller from other updates?
Most of the time, people are interested in e.g. any update of wiki pages or projects. Here, it is already possible to use Ac... -
14:33 Patch #29378 (Needs feedback): More call_hooks for projects, issue statusses, time entries, etc.
- Currently there are only functional call_hooks for issues, and with that, i mean the 'controller_issues_edit_after_save' etc.
Because i'm working on a seperate app, connected with redmine on the backend, i need more hooks to hook my 'up... -
13:39 Patch #29359 (Closed): Switch to mini_mime from mime-types
- Pavel Rosický wrote:
> please also remove
> ...
Committed. Thanks. -
11:28 Patch #29359 (Reopened): Switch to mini_mime from mime-types
-
11:18 Patch #29359: Switch to mini_mime from mime-types
- please also remove
-
01:37 Patch #29359 (Closed): Switch to mini_mime from mime-types
- Committed. Thank you for your contribution.
-
13:38 Revision 17470 (svn): Don't require mime-types (#29359).
-
03:53 Defect #25727 (Closed): Interface not responsive to mobile device
- Redmine supports responsive layout since 3.2. See #19097.
-
03:43 Defect #24915: Activity shows issues and text of issues which should not
- I could not reproduce the problem with 3.4.6.devel.17468. All activities on a user's profile page are visible issues for the current user.
-
01:55 Defect #29365 (Closed): MailHandlerTest#test_add_issue_with_localized_attributes fails with mail gem 2.7.0
-
01:40 Patch #29363 (Closed): Use String#tr instead of String#gsub
- Committed.
-
01:40 Revision 17469 (svn): Replace String#gsub with faster String#tr (#29363).
- Patch by Go MAEDA.
-
01:37 Revision 17468 (svn): Replace mime-types gem with more efficient mini_mime gem (#29359).
- Contributed by Pavel Rosický.
2018-08-12
-
11:25 Patch #26747: Use find_by instead of where.first to remove unnecessary sorting
- @find_by@ is significantly faster than @where.first@.
-
09:24 Patch #29359: Switch to mini_mime from mime-types
- It's ok, thanks
-
09:10 Patch #29359: Switch to mini_mime from mime-types
- Pavel Rosický wrote:
> @known_types is a class variable. There're two problems:
> ...
Although the patch still has the same problem with the current implementation, simply replacing mime-types with mini_mime will reduce memory usage an... -
06:07 Patch #29363 (Closed): Use String#tr instead of String#gsub
- String#tr is more than 3 times faster than String#gsub when replacing a single character in a string with another single character.
https://github.com/JuanitoFatas/fast-ruby#stringgsub-vs-stringtr-code