Project

General

Profile

Activity

From 2018-10-27 to 2018-10-29

2018-10-29

18:21 Defect #26442: CSS formating classes like p(box). prepended with wiki-class-
Is there a way to patch issues with the current system to get the site wide CSS p(box) and p(conflict) to work again with wiki-class prefixes added to them? Would it be appropriate to add that to our current theme's style sheet to regain... Hal Glenn
11:03 Feature #5262: Different priority levels for different trackers
+1 Bob Green
08:03 Feature #29449: Filter out issues from closed projects in My Page blocks
Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
Thanks.
Marius BĂLTEANU
08:02 Feature #29449 (Closed): Filter out issues from closed projects in My Page blocks
Marius BALTEANU wrote:
> Go Maeda, please apply the attached patch in order to use the @Project::STATUS_ACTIVE@ instead of harcoded 1.
Done (r17612).
Go MAEDA
07:34 Feature #29449 (Reopened): Filter out issues from closed projects in My Page blocks
Go Maeda, please apply the attached patch in order to use the @Project::STATUS_ACTIVE@ instead of harcoded 1. Marius BĂLTEANU
07:25 Feature #29449 (Closed): Filter out issues from closed projects in My Page blocks
Committed the patch posted by Marius. Thanks. Go MAEDA
07:22 Feature #12066 (New): Don't show issues for closed projects in all issues list
Go MAEDA wrote:
> Committed the patch posted by Marius. Thanks.
Sorry, I updated the wrong issue.
Go MAEDA
07:20 Feature #12066 (Closed): Don't show issues for closed projects in all issues list
Committed the patch posted by Marius. Thanks. Go MAEDA
05:27 Feature #20081 (Closed): Filter issues and time entries by project status
Committed. Thank you for improving Redmine. Go MAEDA
02:50 Defect #29730: Previous/Next link on repository page disappear when switching to "View differences" tab
Go MAEDA wrote:
> The patch breaks some tests. Reverted the change.
I'm sorry, I missed the result of the test.
If you add the following code to the patch of #29730#note-2 , the tests should succeed.
Mizuki ISHIKAWA
01:11 Defect #29730 (Reopened): Previous/Next link on repository page disappear when switching to "View differences" tab
The patch breaks some tests. Reverted the change.
{{collapse
Go MAEDA
01:17 Feature #29872 (New): REST API - Timesheet - Allow ability to Include issue details for the timesheet api
When using /time_entries.json api allows the ability to include issue details.
e.g. /time_entries.json?include=issues
Sukhpal Singh

2018-10-28

22:17 Feature #29712: Preview and wiki toolbar for full width custom fields
Marius BALTEANU wrote:
> 2. Add 'wiki-edit' class to field from @custom_fields_helper.rb@
> ...
I'm blind, sorry. We should use the existing method @full_width_layout?@ instead of the 4 conditions.
In the end, it could look something...
Marius BĂLTEANU
21:46 Feature #29712: Preview and wiki toolbar for full width custom fields
Mizuki ISHIKAWA wrote:
> I wrote a patch to add a Wiki toolbar in other custom fields.
> ...
Thanks again for working on this. Today I had some time to look over the proposed patch and I am almost sure that we should not touch the Fiel...
Marius BĂLTEANU
21:57 Feature #28085 (Closed): Wiki Toolbar on Full Width Custom Fields
I'm closing this in favour of #29712 where we started the discussions to implement this feature.
Marius BĂLTEANU
21:50 Patch #29459 (Closed): Add admin flag to users API
Holger Just wrote:
> Thank you for committing the patch.
> ...
I've created a new ticket to track the documentation update. Please see #29871.
Marius BĂLTEANU
21:49 Feature #29871 (New): Add admin flag to REST Users API documentation
From #29459#note-5:
Holger Just wrote:
>
> ...
Marius BĂLTEANU
20:38 Feature #13307: Start date and due date in email notifications
Attached the patch uploaded by Senya Senya in #29254. Marius BĂLTEANU
20:38 Feature #29254 (Closed): Start date and due date in issue email notification
I'm closing this in favour of #13307 (I'll move the patch). Marius BĂLTEANU
20:32 Feature #29817: MailHandler ignores "Default notification option" setting
Go MAEDA wrote:
> FYI: Jean-Philippe Lang wrote in #13341#note-2 as follows:
> ...
I think we should change the current behaviour and use the default notification option.
Marius BĂLTEANU
06:34 Feature #29817: MailHandler ignores "Default notification option" setting
FYI: Jean-Philippe Lang wrote in #13341#note-2 as follows:
> It can be usefull to disable email notifications when we don't want the user to receive any emails but being able to choose between all the options is not so usefull IMO. I've...
Go MAEDA
16:39 Feature #20081: Filter issues and time entries by project status
Fixed in the attached patch.
Sorry for not catching this test fail from the beginning.
Marius BĂLTEANU
13:00 Defect #29730 (Closed): Previous/Next link on repository page disappear when switching to "View differences" tab
Committed. Thank you for fixing this issue. Go MAEDA
12:05 Defect #29756 (Closed): \f or \v character in Textile markup may cause RegexpError exception
Committed. Go MAEDA
12:02 Defect #29756 (Resolved): \f or \v character in Textile markup may cause RegexpError exception
Go MAEDA
09:25 Feature #29824: Add user initials when Gravatar is disabled
While libraries are amazing, I'm a fan of implementing native solutions, unless I need to implement something very quick. I believe that libs are bad for performance, so I'll add the improved code soon, and also, in addition, alternative... Anonymous
07:00 Patch #29781 (Closed): Prevent users from getting stuck with an expired password recovery token in their session
Committed. Thank you for your contribution. Go MAEDA
06:13 Defect #29819 (Needs feedback): 3.4.6, SQLSERVER 2014. Incorrect syntax near 'OFFSET'
Does using the latest tiny_tds solve the problem? Could you try the steps below?
1. Update the version of tiny_tds from 1.0.5 to 2.1.2.
Go MAEDA
02:53 Defect #29855 (Confirmed): add_working_days may return wrong date when the start date is a non-working day
I have confirmed that 3.3-stable and 3.4-stable are also affected. Go MAEDA
02:27 Defect #29852: Cannot use Wiki link with a different name in the table of markdown
Taiki I wrote:
> Sorry I could not find it...
No problem. It is sometimes difficult to find similar issues from about 5000 issues. Please don't hesitate to post a new issue.
Go MAEDA

2018-10-27

19:37 Feature #442: Add a description for trackers
+1
Yuuki NARA
09:36 Feature #29824: Add user initials when Gravatar is disabled
I agree with the privacy concern, and would certainly much prefer this was done natively by Redmine than off to a third party service.
The implementation above in JS also doesn’t compute the foreground colour to ensure contrast is mai...
Kit Grose
05:06 Feature #29824: Add user initials when Gravatar is disabled
Although it is a nice feature, I think that implementing ui-avatars.com in Redmine has a privacy issue. To get an image of initial from ui-avatars.com, Redmine has to send a user's name or an initial to the external site. Some people pro... Go MAEDA
08:46 Defect #29855 (Closed): add_working_days may return wrong date when the start date is a non-working day
@Redmine::Util::DateCalculation#add_working_days(date, n)@ returns wrong date when @date@ is holiday and @n@ is a multiple of 5.
Example:
Yutaka Hara
05:48 Feature #20081: Filter issues and time entries by project status
Marius, thank you for writing the patch.
It seems working fine but I came across the following error while running tests after applying
0001-Filter-issues-after-project-status.patch. Could you look into this?
Go MAEDA
05:27 Defect #29852: Cannot use Wiki link with a different name in the table of markdown
Thank you for your advice!
Sorry I could not find it...
Anonymous
03:17 Defect #29852 (Closed): Cannot use Wiki link with a different name in the table of markdown
I have confirmed the issue with the current trunk (3.4.6.devel.17596) and found that it was already reported as #23341.
Thank you for reporting this issue.
Go MAEDA
04:08 Defect #29848: Query to determine role ids is incorrect
I could not reproduce the problem.
Could you try without plugins if you are using any plugins?
Go MAEDA
03:43 Defect #29849: Display order of Redmine parent/child tickets are not correct
Could you describe details why you think the order is incorrect? Go MAEDA
 

Also available in: Atom