Project

General

Profile

Activity

From 2020-12-02 to 2020-12-04

2020-12-04

21:00 Defect #34397 (Closed): PDF thumbnail to PNG failing on ruby 2.5
We have Redmine 4.1.1 hosted on an ubuntu server but whenever we attach PDFs, the thumbnails show up as 404 broken li... Zee Prime
15:00 Revision 20575 (svn): use with_settings at MailHandlerControllerTest#test_should_not_allow_with_wrong_key
Toshi MARUYAMA
14:59 Revision 20574 (svn): add empty line after guard clause to lib/redmine/twofa/base.rb
Toshi MARUYAMA
14:59 Revision 20573 (svn): add empty line after guard clause to lib/redmine/menu_manager.rb
Toshi MARUYAMA
14:59 Revision 20572 (svn): add empty line after guard clause to lib/redmine/i18n.rb
Toshi MARUYAMA
14:59 Revision 20571 (svn): add empty line after guard clause to lib/redmine/helpers/gantt.rb
Toshi MARUYAMA
14:59 Revision 20570 (svn): shorten long line of Query#add_custom_fields_filters
Toshi MARUYAMA
14:59 Revision 20569 (svn): shorten long line of lib/redmine/database.rb
Toshi MARUYAMA
14:59 Revision 20568 (svn): fix source indent of lib/redmine/default_data/loader.rb
Toshi MARUYAMA
14:58 Revision 20567 (svn): fix source indent of test/unit/lib/redmine/unified_diff_test.rb
Toshi MARUYAMA
14:58 Revision 20566 (svn): fix source indent of test/unit/repository_bazaar_test.rb
Toshi MARUYAMA
14:58 Revision 20565 (svn): fix source indent of test/unit/project_nested_set_concurrency_test.rb
Toshi MARUYAMA
14:58 Revision 20564 (svn): add Layout/ClosingParenthesisIndentation excluding files to .rubocop.yml
Toshi MARUYAMA
08:02 Feature #34303: Allow to add subtask from context menu
The concept proposed by Maeda worked fine on my environment (trunk@20562).
I have made the test code for 34303-poc.p...
Takenori TAKAKI
07:57 Defect #34326: CSV import raises an exception if CSV header has empty columns
Setting the target version to 4.2.0. Go MAEDA
01:11 Defect #34326: CSV import raises an exception if CSV header has empty columns
Go MAEDA wrote:
> Yuichi HARADA wrote:
> > I created a patch. No exception is raised if there are blank columns in ...
Yuichi HARADA
01:56 Feature #34307: Create custom field by copy
The patch for #note-1 was incomplete and I will reattach it. Takenori TAKAKI
01:03 Feature #34307: Create custom field by copy
I made a patch to copy the custom field and attach it.
I confirmed that this patch works fine on latest trunk@20562.
Takenori TAKAKI
01:40 Defect #33355 (Closed): TypeError when attempting to update a user with a blank email address
Go MAEDA
01:40 Revision 20563 (svn): Merged r20562 from trunk to 4.1-stable (#33355).
Go MAEDA

2020-12-03

16:14 Defect #33355 (Resolved): TypeError when attempting to update a user with a blank email address
Committed the patch. Go MAEDA
16:14 Revision 20562 (svn): TypeError when attempting to update a user with a blank email address (#33355).
Patch by Go MAEDA. Go MAEDA
16:06 Defect #33952: Spent time details are displayed in incorrect order when sorted by week and date
I have slightly updated the test code.
Setting the target version to 4.1.2.
Go MAEDA
15:12 Defect #34326: CSV import raises an exception if CSV header has empty columns
Yuichi HARADA wrote:
> I created a patch. No exception is raised if there are blank columns in the CSV header.
>
...
Go MAEDA
14:20 Revision 20561 (svn): use with_settings at MailHandlerControllerTest#test_should_not_allow_with_api_disabled
Toshi MARUYAMA
14:20 Revision 20560 (svn): add space after comma to lib/redmine/export/pdf/issues_pdf_helper.rb
Toshi MARUYAMA
14:20 Revision 20559 (svn): shorten long line of ApplicationHelperTest
Toshi MARUYAMA
14:20 Revision 20558 (svn): shorten long line of test/unit/mailer_test.rb
Toshi MARUYAMA
14:20 Revision 20557 (svn): shorten long line of test/unit/lib/redmine/notifiable_test.rb
Toshi MARUYAMA
14:19 Revision 20556 (svn): shorten long line of test/unit/workflow_transition_test.rb
Toshi MARUYAMA
14:19 Revision 20555 (svn): fix source indent of test/integration/account_test.rb
Toshi MARUYAMA
14:19 Revision 20554 (svn): fix source indent of test/integration/admin_test.rb
Toshi MARUYAMA
14:19 Revision 20553 (svn): fix source indent of test/unit/mailer_test.rb
Toshi MARUYAMA
14:19 Revision 20552 (svn): fix source indent of test/unit/mail_handler_test.rb
Toshi MARUYAMA
14:19 Revision 20551 (svn): fix source indent of test/integration/api_test/issues_test.rb
Toshi MARUYAMA
14:19 Revision 20550 (svn): fix source indent of test/integration/api_test/projects_test.rb
Toshi MARUYAMA
11:20 Feature #8568: add ability to designate default watchers by tracker/project
Would it be interesting to close (reject?) the issue and redirect the users/reporters to a Redmine plugin, or another... R Pommier
09:20 Defect #34297: Subprojects issues are not displayed on main project when all subprojects are closed
Go MAEDA wrote:
> I have confirmed the reported behavior. If there are one or more open subprojects, issues in close...
Yuichi HARADA
09:15 Feature #34369: Implementation of great added value for the Redmine System
+1000 Luis Blasco
08:35 Defect #34375: "is not" operator for Subproject filter incorrectly excludes closed subprojects
The issue is caused at source:branches/4.1-stable/app/models/query.rb#L886 Go MAEDA
06:58 Defect #34375 (Closed): "is not" operator for Subproject filter incorrectly excludes closed subprojects
"is not" operator for Subproject is expected to exclude only given projects, however, it actually excludes closed pro... Go MAEDA

2020-12-02

23:00 Feature #34369 (New): Implementation of great added value for the Redmine System
Without this impelmentation. The system is compromised. A simple matter to resolve. I am not a Ruby programmer but th... Carlos Miguel
22:48 Patch #34119 (Closed): Fix selenium chrome options so files are downloaded to tmp/downloads in system tests
Committed the fix. Thank you. Go MAEDA
09:48 Patch #34119: Fix selenium chrome options so files are downloaded to tmp/downloads in system tests
Updated the patch for the current trunk. Go MAEDA
22:48 Revision 20549 (svn): Fix selenium chrome options so files are downloaded to tmp/downloads in system tests (#34119).
Patch by Jens Krämer. Go MAEDA
16:52 Feature #9059: Custom fields should be editable based on role not only for admin
I need it too! John Bolthouse
15:13 Defect #34367 (Closed): Allowed filename extensions of attachments can be circumvented
In #20008, Redmine introduced the ability to restrict the allowed extensions of attachment filenames.
This check i...
Holger Just
15:07 Revision 20548 (svn): RuboCop: Fix Layout/SpaceInsideBlockBraces due to r20547 (#34071).
Go MAEDA
15:00 Feature #33658: robots.txt: disallow crawling login, register, and lost password form
Looks good to me, thanks! Holger Just
09:34 Feature #33658: robots.txt: disallow crawling login, register, and lost password form
Holger Just wrote:
> Redmine already generates a @robots.txt@ in @welcome#robots@. Wouldn't this be better suited th...
Go MAEDA
14:56 Patch #34071 (Closed): Handle AuthSourceExceptions in User.try_to_login
Committed the patch. Thank you for your contribution. Go MAEDA
14:56 Revision 20547 (svn): Changes User.try_to_login to catch and log AuthSourceExceptions, and introduces User.try_to_login! replicating the original behavior (#34071).
Patch by Jens Krämer. Go MAEDA
14:32 Revision 20546 (svn): use with_settings at MailHandlerControllerTest#test_should_respond_with_422_if_not_created
Toshi MARUYAMA
14:32 Revision 20545 (svn): shorten long line of QueriesHelper
Toshi MARUYAMA
14:32 Revision 20544 (svn): fix source indent of test/integration/api_test/api_test.rb
Toshi MARUYAMA
14:31 Revision 20543 (svn): fix source indent of test/integration/api_test/attachments_test.rb
Toshi MARUYAMA
14:31 Revision 20542 (svn): fix source indent of AttachmentFieldFormatTest
Toshi MARUYAMA
14:31 Revision 20541 (svn): fix source indent of test/unit/repository_git_test.rb
Toshi MARUYAMA
14:31 Revision 20540 (svn): fix source indent of GitAdapterTest
Toshi MARUYAMA
14:31 Revision 20539 (svn): fix source indent of test/integration/repositories_git_test.rb
Toshi MARUYAMA
14:31 Revision 20538 (svn): fix source indent of MercurialAdapterTest
Toshi MARUYAMA
14:31 Revision 20537 (svn): fix source indent of lib/redmine/scm/adapters/mercurial_adapter.rb
Toshi MARUYAMA
14:30 Revision 20536 (svn): fix source indent of test/unit/repository_mercurial_test.rb
Toshi MARUYAMA
14:30 Revision 20535 (svn): fix source indent of lib/redmine/access_keys.rb
Toshi MARUYAMA
09:37 Feature #24766: Custom fields grouping
+1 Gianni Cavallotto
08:57 Defect #34338 (Closed): issue export button disappear
Thank you for your feedback. Closing. Go MAEDA
04:33 Feature #34258 (Closed): Create tracker by copy
Go MAEDA wrote:
> The test randomly fails due to r20492.
Committed the fix in r20534.
Go MAEDA
04:32 Revision 20534 (svn): Fix random test failure due to r20492 (#34258).
Go MAEDA
04:28 Defect #34357 (Closed): Fix Capybara::Ambiguous: Ambiguous match, found 2 elements matching visible link or button "eCookbook"
Committed the fix as a part of #32944. Thank you. Go MAEDA
04:27 Revision 20533 (svn): Fix Capybara::Ambiguous: Ambiguous match, found 2 elements matching visible link or button "eCookbook" (#32944, #34357).
Patch by Marius BALTEANU. Go MAEDA
 

Also available in: Atom