Redmine

2020-12-05

22:39 Feature #28471: Query links for subtasks on issue page

Thanks Bernhard for the tests.
Reviewing them, I found out that the current implementation has two issues:
* issu... Marius BĂLTEANU

19:27 Feature #7842: Creation new users by non-admin user

+1
Needed feature for "registrar" role, which could manage users. And you could allow this role to create/edit/delet... Igor Rybak

19:06 Defect #34397 (Resolved): PDF thumbnail to PNG failing on ruby 2.5

Go MAEDA wrote:
> I found the following page. Maybe ImageMagick's @policy.yml@ in your environment does not allow co... Zee Prime

00:37 Defect #34397: PDF thumbnail to PNG failing on ruby 2.5

I found the following page. Maybe ImageMagick's @policy.yml@ in your environment does not allow converting PDF files.... Go MAEDA

18:03 Defect #33846: Inline issue auto complete doesn't sanitize HTML tags

Attached is a test for this issue that can be applied only after #34123 is committed. Marius BĂLTEANU

16:50 Feature #34123: System tests for inline auto complete feature

I've added a first version of the tests. I preferred to have all the tests related to inline autocomplete in the same... Marius BĂLTEANU

09:55 Feature #34303: Allow to add subtask from context menu

+1 Sounds quite handy. :-) Bernhard Rohloff

08:11 Feature #33658 (Closed): robots.txt: disallow crawling login, register, and lost password form

Committed patch #33658#note-6. Go MAEDA

08:10 Revision 20577 (svn): Use robots.txt instead of robots meta tag to prevent web crawlers from indexing login, register, and lost password form (#33658).

Patch by Go MAEDA. Go MAEDA

07:23 Defect #34398 (Closed): Tracker filter shows subprojects trackers even when "Display subprojects issues on main projects by default" is disabled

Currently, the tracker filter shows all trackers enabled in the current projects and subprojects. However, it makes n... Go MAEDA

03:17 Defect #34326 (Closed): CSV import raises an exception if CSV header has empty columns

Go MAEDA

01:21 Defect #34326: CSV import raises an exception if CSV header has empty columns

Committed the fix as a part of #22913. Thank you. Go MAEDA

03:15 Defect #10084: Disabled trackers of subprojects are listed in project overview

The patch fixes an issue that trackers that are enabled only in subprojects are displayed in the issue tracking box i... Go MAEDA

01:52 Feature #8875: Allow manually fetching changesets

I have been considering who should be allowed to fetch manually changesets. As a result, I came to the conclusion tha... Go MAEDA

01:21 Revision 20576 (svn): CSV import raises an exception if CSV header has empty columns (#22913, #34326).

Go MAEDA

2020-12-04

21:00 Defect #34397 (Closed): PDF thumbnail to PNG failing on ruby 2.5

We have Redmine 4.1.1 hosted on an ubuntu server but whenever we attach PDFs, the thumbnails show up as 404 broken li... Zee Prime

15:00 Revision 20575 (svn): use with_settings at MailHandlerControllerTest#test_should_not_allow_with_wrong_key

Toshi MARUYAMA

14:59 Revision 20574 (svn): add empty line after guard clause to lib/redmine/twofa/base.rb

Toshi MARUYAMA

14:59 Revision 20573 (svn): add empty line after guard clause to lib/redmine/menu_manager.rb

Toshi MARUYAMA

14:59 Revision 20572 (svn): add empty line after guard clause to lib/redmine/i18n.rb

Toshi MARUYAMA

14:59 Revision 20571 (svn): add empty line after guard clause to lib/redmine/helpers/gantt.rb

Toshi MARUYAMA

14:59 Revision 20570 (svn): shorten long line of Query#add_custom_fields_filters

Toshi MARUYAMA

14:59 Revision 20569 (svn): shorten long line of lib/redmine/database.rb

Toshi MARUYAMA

14:59 Revision 20568 (svn): fix source indent of lib/redmine/default_data/loader.rb

Toshi MARUYAMA

14:58 Revision 20567 (svn): fix source indent of test/unit/lib/redmine/unified_diff_test.rb

Toshi MARUYAMA

14:58 Revision 20566 (svn): fix source indent of test/unit/repository_bazaar_test.rb

Toshi MARUYAMA

14:58 Revision 20565 (svn): fix source indent of test/unit/project_nested_set_concurrency_test.rb

Toshi MARUYAMA

14:58 Revision 20564 (svn): add Layout/ClosingParenthesisIndentation excluding files to .rubocop.yml

Toshi MARUYAMA

08:02 Feature #34303: Allow to add subtask from context menu

The concept proposed by Maeda worked fine on my environment (trunk@20562).
I have made the test code for 34303-poc.p... Takenori TAKAKI

07:57 Defect #34326: CSV import raises an exception if CSV header has empty columns

Setting the target version to 4.2.0. Go MAEDA

01:11 Defect #34326: CSV import raises an exception if CSV header has empty columns

Go MAEDA wrote:
> Yuichi HARADA wrote:
> > I created a patch. No exception is raised if there are blank columns in ... Yuichi HARADA

01:56 Feature #34307: Create custom field by copy

The patch for #note-1 was incomplete and I will reattach it. Takenori TAKAKI

01:03 Feature #34307: Create custom field by copy

I made a patch to copy the custom field and attach it.
I confirmed that this patch works fine on latest trunk@20562. Takenori TAKAKI

01:40 Defect #33355 (Closed): TypeError when attempting to update a user with a blank email address

Go MAEDA

01:40 Revision 20563 (svn): Merged r20562 from trunk to 4.1-stable (#33355).

Go MAEDA

2020-12-03

16:14 Defect #33355 (Resolved): TypeError when attempting to update a user with a blank email address

Committed the patch. Go MAEDA

16:14 Revision 20562 (svn): TypeError when attempting to update a user with a blank email address (#33355).

Patch by Go MAEDA. Go MAEDA

16:06 Defect #33952: Spent time details are displayed in incorrect order when sorted by week and date

I have slightly updated the test code.
Setting the target version to 4.1.2. Go MAEDA

15:12 Defect #34326: CSV import raises an exception if CSV header has empty columns

Yuichi HARADA wrote:
> I created a patch. No exception is raised if there are blank columns in the CSV header.
>
... Go MAEDA

14:20 Revision 20561 (svn): use with_settings at MailHandlerControllerTest#test_should_not_allow_with_api_disabled

Toshi MARUYAMA

14:20 Revision 20560 (svn): add space after comma to lib/redmine/export/pdf/issues_pdf_helper.rb

Toshi MARUYAMA

14:20 Revision 20559 (svn): shorten long line of ApplicationHelperTest

Toshi MARUYAMA

14:20 Revision 20558 (svn): shorten long line of test/unit/mailer_test.rb

Toshi MARUYAMA

14:20 Revision 20557 (svn): shorten long line of test/unit/lib/redmine/notifiable_test.rb

Toshi MARUYAMA

14:19 Revision 20556 (svn): shorten long line of test/unit/workflow_transition_test.rb

Toshi MARUYAMA

14:19 Revision 20555 (svn): fix source indent of test/integration/account_test.rb

Toshi MARUYAMA

14:19 Revision 20554 (svn): fix source indent of test/integration/admin_test.rb

Toshi MARUYAMA

14:19 Revision 20553 (svn): fix source indent of test/unit/mailer_test.rb

Toshi MARUYAMA

14:19 Revision 20552 (svn): fix source indent of test/unit/mail_handler_test.rb

Toshi MARUYAMA

14:19 Revision 20551 (svn): fix source indent of test/integration/api_test/issues_test.rb

Toshi MARUYAMA

14:19 Revision 20550 (svn): fix source indent of test/integration/api_test/projects_test.rb

Toshi MARUYAMA

11:20 Feature #8568: add ability to designate default watchers by tracker/project

Would it be interesting to close (reject?) the issue and redirect the users/reporters to a Redmine plugin, or another... R Pommier

09:20 Defect #34297: Subprojects issues are not displayed on main project when all subprojects are closed

Go MAEDA wrote:
> I have confirmed the reported behavior. If there are one or more open subprojects, issues in close... Yuichi HARADA

09:15 Feature #34369: Implementation of great added value for the Redmine System

+1000 Luis Blasco

08:35 Defect #34375: "is not" operator for Subproject filter incorrectly excludes closed subprojects

The issue is caused at source:branches/4.1-stable/app/models/query.rb#L886 Go MAEDA

06:58 Defect #34375 (Closed): "is not" operator for Subproject filter incorrectly excludes closed subprojects

"is not" operator for Subproject is expected to exclude only given projects, however, it actually excludes closed pro... Go MAEDA