Activity
From 2021-04-16 to 2021-04-18
2021-04-18
-
07:39 Revision 20950 (svn): Merged r20949 from trunk to 4.2-stable (#35087).
-
2021-04-17
-
20:40 Defect #35115: Time entries are broken if grouped by project and issue custom fields
- Same problem with MySQL, but the problem should the same with all database types.
-
- If you have a custom field for project, which can be used for group by filter (e.g. a list format).
If you try to use this custom fields for group by on time entries this throw an exception: -
20:27 Feature #32424: CommonMark Markdown Text Formatting
- Replaced the now-deprecated @Sanitize@ keywords and updated version references. @HTML::Pipeline@ version must be specified including its patch version because of this (2.14.0 is older than 2.13.2).
-
- The problem was that the overly restricted href URL issue was actually copied from the old Markdown implementation (already reported in #32766). We should distinguish URI safety for automatically loaded resources (like images) and harmle...
-
- In CommonMark formatting patch #32424, I've added @Redmine::Helpers::URL#uri_with_link_safe_scheme?@ method.
If it were applied, the fix for the old Markdown formatting would be: -
16:22 Feature #3816: Allow pasting screenshots from clipboard
- This solution is fine - and it attaches as a file, with a file name.
If you wanted it NOT as an attachment, but to be visible in the body of the ticket -this plugin provides it:
https://www.redmine.org/plugins/redmine_image_clipbo... -
09:33 Feature #2048: Code Review Module
- As Idea, recently bugzilla has integrated an external code review tool (Phabricator) with this "approach":https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html and now a specific section is present in the issue page as show ...
2021-04-16
-
17:24 Patch #35111 (Closed): Russian translation update for 4.2-stable
-
- Heiko Robert wrote:
> -@whitelist[:protocols]["a"] = [@-
Please be warned, this would allow everything, including user-supplied javascript.
The correct fix with the allowlist approach would be: -
13:37 Feature #32424: CommonMark Markdown Text Formatting
- found the issue:
in attachment:0001-CommonMark-Markdown-text-formatter.patch you used @:a@ instead of @"a"@ in line 522
changing to -
- I found your protocol whitelist definition in lib/redmine/wiki_formatting/common_mark/sanitization_filter.rb but that seems not to work as expected. Even when trying to use ftp which is in your whitelist no link will be rendered
-
- Thank you all for your valuable work in providing this patch!
I have issues with non http links using protocols like ssh or scp. We use lot's of them in our wiki pages. Following the commonmark spec for "Autolink":https://spec.commonmar... -
16:29 Patch #35110 (Closed): Lithuanian translation update for 4.2-stable
- In several recent versions of Redmine, new features have not been translated into Lithuanian. Because I still had to do the translations - maybe someone else will find it useful.
-
14:09 Defect #34367: Allowed filename extensions of attachments can be circumvented
- Thank you!
-
- Committed the patch. Thank you for handling this issue.
-
- Setting the target version to 5.0.0.
-
- Committed the patch.
-
- Patch by Go MAEDA.
-
-
-
- Patch by Holger Just.