Feature #13596
closed
Add setting to allow/deny time logging on closed issues
Added by Filou Centrinov almost 13 years ago. Updated 12 months ago.
Description
Time logging should be only possible for issues which are open. May an options is added to the time tracking rights for a role.
Files
| _action_menu.patch (1.12 KB) _action_menu.patch | Pavel Potcheptsov, 2013-11-18 10:00 | ||
| 0001-Adds-setting-to-allow-timelog-on-closed-issues.patch (9.02 KB) 0001-Adds-setting-to-allow-timelog-on-closed-issues.patch | Marius BĂLTEANU, 2024-12-11 20:58 |
Related issues
Updated by Filou Centrinov almost 13 years ago
- Related to Feature #13244: Restrict log time for old days added
Updated by Pavel Potcheptsov over 12 years ago
- File _action_menu.patch _action_menu.patch added
This works for me.
Change issue.status_id to number that points to your Closed issues.
Updated by Toshi MARUYAMA over 9 years ago
- Related to deleted (Feature #13244: Restrict log time for old days)
Updated by Toshi MARUYAMA over 9 years ago
- Related to Feature #13244: Restrict log time for old days added
Updated by Toshi MARUYAMA over 9 years ago
- Related to deleted (Feature #13244: Restrict log time for old days)
Updated by Toshi MARUYAMA over 9 years ago
- Related to Feature #3322: Setting to restrict spent times on future dates added
Updated by Marius BĂLTEANU over 1 year ago
- Related to Feature #13244: Restrict log time for old days added
Updated by Marius BĂLTEANU over 1 year ago
- Assignee set to Marius BĂLTEANU
- Target version set to 6.1.0
A patch has been posted in #13244.
Updated by Marius BĂLTEANU over 1 year ago
- File 0001-Adds-setting-to-allow-timelog-on-closed-issues.patch 0001-Adds-setting-to-allow-timelog-on-closed-issues.patch added
Attached a new patch based on the work made by Jens in #13244.
Updated by Marius BĂLTEANU 12 months ago
- Subject changed from Allow time logging only for open issues to Add setting to allow/deny time logging on closed issues
- Status changed from New to Resolved
- Resolution set to Fixed
Setting added in r23586, you can now configure the desired behaviour.
Updated by Holger Just 12 months ago
- Status changed from Closed to Reopened
Thank you Marius.
On doubt though: in the issue.rb patch in r23586, you refer to Setting.timelog_accept_future_dates?. Shouldn't this refer to Setting.timelog_accept_closed_issues? with a different boolean negation instead, i.e.
# Returns true if user or current user is allowed to log time on the issue
def time_loggable?(user=User.current)
user.allowed_to?(:log_time, project) && (Setting.timelog_accept_closed_issues? || !closed?)
end
Updated by Marius BĂLTEANU 12 months ago
Holger Just wrote in #note-12:
Thank you Marius.
On doubt though: in the
issue.rbpatch in r23586, you refer toSetting.timelog_accept_future_dates?. Shouldn't this refer toSetting.timelog_accept_closed_issues?with a different boolean negation instead, i.e.[...]
Yes, I saw that mistake right after I've committed the change and a test started to failed. The problem is already fixed in r23589.
Updated by Holger Just 12 months ago
- Status changed from Reopened to Closed
I see, thanks. Sorry that I missed that.
Updated by Marius BĂLTEANU 12 months ago
Holger Just wrote in #note-14:
I see, thanks. Sorry that I missed that.
Don't worry, thanks for reviewing the changes!