Redmine

I made a patch (with tests) that adds these 2 useful filters:

1. updated_by: it can be used to find tickets updated or not by specific project users
   Use case: Find all the tickets that have been updated (touched) by me.
2. last_updated_by: it can be used to find tickets that were last updated or not by specific users
   Use case: Find all the tickets that have been last updated by user x (a customer for example).

Both filters apply only on issues with at least one update made after issue creation.

Because the "last_updated_by" filter expects that the issue updated_on date to be equal with last journal created_on date, it was required to make some changes to issues fixtures and journal fixtures in order to match the dates. If i'm wrong with this expectation, please let me know and I'll try to find another solution.

Also, I've added a new journal entry in journal fixtures to test a scenario (with "!" operator). Because of this new journal entry, I changed in issue_test the issue id of the ticket without journals.

I'll add another patch that implements the last_updated_by as column in #6375.

Thanks for submitting the patch, Marius BALTEANU. This is very useful.

It works fine for me and passed all tests. Setting target version to 3.4.0.

Updated the patch to cleanly apply on the current trunk. All the tests pass.

Rebased on r15949 v2 patch with minor fix.

diff --git a/test/unit/query_test.rb b/test/unit/query_test.rb
--- a/test/unit/query_test.rb
+++ b/test/unit/query_test.rb
@@ -29,7 +29,7 @@
            :queries,
            :projects_trackers,
            :custom_fields_trackers,
-           :workflows
+           :workflows, :journals

Updated the patch to cleanly apply on the current trunk.

@Jean-Philippe Lang, is there anything I can do in order to have this committed?

For users who are not allowed to view private notes, these filters can match issues even if the update is not visible to the user.

Eg. user A updates issue X with private notes, user B (who is not allowed to view private notes) filters issues updated by user A and sees issue X in the results. But he won't see any update by user A when looking at the issue history.

Is it an acceptable behaviour?

Jean-Philippe Lang wrote:

For users who are not allowed to view private notes, these filters can match issues even if the update is not visible to the user.

Eg. user A updates issue X with private notes, user B (who is not allowed to view private notes) filters issues updated by user A and sees issue X in the results. But he won't see any update by user A when looking at the issue history.

Is it an acceptable behaviour?

Very good question :)

From my point of view, this is an acceptable behaviour because the privacy of the note is not affected. User B it'll see only that the issue X was updated by user A. Currently, you can see the last update date, but without seeing the respective update in the history:

In the same time, I agree that the behaviour can be a little bit confusing for the users.

My proposal is to implement them as it is and see if the users will complain about it.

Thanks for your feedback Marius.
I think hiding private updates is a better option and was not so difficult to implement without too much changes. It's committed in r16228. I've made a few tests with Postgres and 1M journals without performance issues. Please let know how it works for you.

Sorry for reopening this issue.

I think it would be better to change the position of "Updated by" and "Last updated by" in the filters drop-down. Here is a patch: 17720-change-filter-position.diff

Please see the following images for details.

Before (current implementation):

After:

Committed, thanks.