Redmine

Attached two patches that add the "Project's status" filter to issues and time entries. Beside the filter itself utility, if we add this feature, will allow us to implement #29449 and also, to discuss (I'll add another ticket) the possibility to hide the issues/time entries from closed projects by default (as the closed projects are hidden by default in Projects page).

Fixed in the attached patch.

Sorry for not catching this test fail from the beginning.

Committed. Thank you for improving Redmine.

Hi,
I came from #29449 and just applied these patches to my redmine 3.4 instance:

• 0001-Filter-issues-after-project-status.patch
• 0002-Filter-time-entries-after-project-status.patch
• 0003-Filter-our-issues-from-closed-projects-in-the-follow.patch (from #29449)
• use_status_active_constant.diff (from #29449)

Now that issues from closed project are filtered out from my page as I expected.
However, a "translation missing" error now appears in the filter on the query page:

I find it's because Project::LABEL_BY_STATUS (patch 0001) is not working as expected. (I think I18n is not loaded yet when this hash value gets evaluated)

I can fix this by putting the labels hash into query.rb instead of calling Project::LABEL_BY_STATUS. But is there a way to keep the labels inside the Project model and still be able to use the translations? I'm new to ruby and rails and looking forward to some advice.

diff --git a/app/models/query.rb b/app/models/query.rb
index dc84402..218c560 100644
--- a/app/models/query.rb
+++ b/app/models/query.rb
@@ -573,7 +573,11 @@ class Query < ActiveRecord::Base

   # Returns a scope of project statuses that are available as columns or filters
   def project_statuses_values
-    project_statuses =  Project::LABEL_BY_STATUS
+    project_statuses = {
+      1 => l(:project_status_active),
+      5 => l(:project_status_closed),
+      9 => l(:project_status_archived),
+    }
     # Remove archived status from filters
     project_statuses.delete(9)
     project_statuses.stringify_keys.invert.to_a