Patch #20661
closed
Show visible spent time link for users allowed to view time entries.
Added by Martin Dubé over 10 years ago. Updated about 9 years ago.
Description
With this little change, the spent time is back, but showing only hours visible by the user according to the new "time log visibility" permission.
Files
| show.html.erb.patch (631 Bytes) show.html.erb.patch | Martin Dubé, 2015-09-02 15:25 | ||
| spent-time-issues-index.png (10.8 KB) spent-time-issues-index.png | Go MAEDA, 2017-01-19 13:30 | ||
| spent-time-issues-show.png (17.8 KB) spent-time-issues-show.png | Go MAEDA, 2017-01-19 13:35 | ||
| 20661-show-visible-spent-time.diff (1.23 KB) 20661-show-visible-spent-time.diff | Go MAEDA, 2017-01-19 13:57 |
Related issues
Updated by Toshi MARUYAMA over 10 years ago
- Status changed from New to Needs feedback
There are many "show.html.erb". Which show.html.erb?
Updated by
Updated by Toshi MARUYAMA over 10 years ago
- Status changed from Needs feedback to New
Updated by Go MAEDA about 9 years ago
- Category changed from UI to Time tracking
By this patch, different spent hours value is displayed for each user.
I am worried that it may cause confusion.
Updated by Robert Korulczyk about 9 years ago
Go MAEDA wrote:
By this patch, different spent hours value is displayed for each user.
I am worried that it may cause confusion.
It already work in this way in multiple places (issues list for example) - user can see only his own time log.
Personally I think that much more confusing is situation, where issues list contain more details about issue than issue detail view, and user can't easily see how many hours his spend on the issue.
Updated by Go MAEDA about 9 years ago
- File spent-time-issues-index.png spent-time-issues-index.png added
- File spent-time-issues-show.png spent-time-issues-show.png added
Robert Korulczyk wrote:
Go MAEDA wrote:
By this patch, different spent hours value is displayed for each user.
I am worried that it may cause confusion.It already work in this way in multiple places (issues list for example) - user can see only his own time log.
Thank you for letting me know it. I didn't know. I agree with you now. I think that it is inconsistent.
Updated by Go MAEDA about 9 years ago
Updated the patch.
Also Issue.load_visible_total_spent_hours should be called to show correct value of total_spent_hours.
Updated by Go MAEDA about 9 years ago
- Target version set to Candidate for next minor release
Updated by Go MAEDA about 9 years ago
- Target version changed from Candidate for next minor release to 3.3.3
Let's resolve the inconsistency.
Setting target version to 3.3.3.
Updated by Jean-Philippe Lang about 9 years ago
- Status changed from New to Resolved
- Assignee set to Jean-Philippe Lang
Committed, thanks.
Updated by Jean-Philippe Lang about 9 years ago
- Status changed from Resolved to Closed
Updated by Jean-Philippe Lang about 9 years ago
- Target version changed from 3.3.3 to 3.2.6
Updated by Jean-Philippe Lang almost 9 years ago
- Related to Patch #25526: Revert API change in spent_hours field in issue#show added