Project

General

Profile

Activity

From 2016-01-29 to 2016-01-31

2016-01-31

20:27 Patch #21805: Improve accessibility for icon-only links
Daniel Ritz wrote:
> Anyways, please have a look at v2 of the patch w/o the helpers.
Missed one:
Daniel Ritz
16:40 Patch #21805: Improve accessibility for icon-only links
I don't like the helpers too much myself, but..here's why I did the helpers:
* No need to use @l(:bla)@ twice (one for the invisible text, one for the @title@ attribute)
* Shorter to write
* It's easy to forget the accessible content
...
Daniel Ritz
10:57 Patch #21805: Improve accessibility for icon-only links
I'd prefer not to add specific helper methods for this.
Can't we just use a regular link with the icon-only class and use some styling to hide the label, eg:
Jean-Philippe Lang
14:17 Defect #21900: Moving a page with a child raises an error if target wiki contains a page with the same name as the child
>> May I edit the wiki page?
> ...
I did it. I added some more changes.
Please double-check, since English is not my first language.
Hiroo Hayashi
14:00 Defect #21900: Moving a page with a child raises an error if target wiki contains a page with the same name as the child
Hiroo Hayashi wrote:
> May I edit the wiki page?
Sure
Jean-Philippe Lang
13:00 Defect #21900: Moving a page with a child raises an error if target wiki contains a page with the same name as the child
Good. That is I expected.
[[Submissions]] says
> Submitting a Wiki improvement
> ...
May I edit the wiki page?
Hiroo Hayashi
10:34 Defect #21900: Moving a page with a child raises an error if target wiki contains a page with the same name as the child
After the fix, the last paragraph would be:
You can move a page to another project by specifying the destination project in 'Project'. When moving a page, each child page is also moved unless the destination project contains a page wi...
Jean-Philippe Lang
04:54 Defect #21900: Moving a page with a child raises an error if target wiki contains a page with the same name as the child
Thank you for your prompt fix.
I found this bug because I wanted to know how this function, moving Wiki pages, works.
[[RedmineWikis]] has no description about it yet. #5450 was this only clue, but has little information.
The fol...
Hiroo Hayashi
12:21 Feature #12456 (Closed): Add units in history for estimated time
Committed, thanks. Jean-Philippe Lang
12:19 Feature #4266 (Closed): Display changeset comment on repository diff view.
Feature added. I've made a few changes so that the changeset details on the diff are displayed when the diff is for a single changeset only. Thanks. Jean-Philippe Lang
11:00 Patch #21256 (Closed): Use CSS instead of image_tag() to show icons for better theming support
Daniel Ritz wrote:
> I implemented this in #21805. Please have a look. Maybe the discussion should move to the new patch with this one closed?
Agreed.
Jean-Philippe Lang
10:37 Patch #21378: Include Documents in Projects API
I'd like to improve the documents feature in a near future (directories...). The documents API should be added after that. Jean-Philippe Lang
03:41 Patch #21747 (Closed): Catalan translation
Committed, thanks.
ca.yml changes many words, so I think it is not suitable for stable.
Toshi MARUYAMA
03:39 Patch #21541 (Closed): Russian translation improvement
Committed in trunk, thanks. Toshi MARUYAMA
03:37 Patch #21899 (Closed): Catalan wiki translation for 3.1-stable
Committed in trunk, 3.2-stable, and 3.1-stable. Toshi MARUYAMA
03:36 Patch #21898 (Closed): Catalan wiki translation for 2.6-stable
Committed in trunk, 3.2-stable, 3.1-stable, and 2.6-stable. Toshi MARUYAMA
03:34 Patch #21883 (Closed): Russian wiki translation for 3.2-stable
Committed in trunk, and 3.2-stable. Toshi MARUYAMA
03:34 Patch #21882 (Closed): Russian wiki translation for 3.1-stable
Committed in trunk, 3.2-stable, and 3.1-stable. Toshi MARUYAMA
03:32 Patch #21881 (Closed): Russian wiki translation for 2.6-stable
Committed in trunk, 3.2-stable, 3.1-stable, and 2.6-stable. Toshi MARUYAMA
03:07 Feature #12337 (Closed): Add async file upload support
Implemented by #3957 (Redmine 2.3.0). Go MAEDA

2016-01-30

16:43 Patch #21593 (Resolved): Add class to contextual edit button that relates to heading on wiki pages
3.2.1 will be fine. Jean-Philippe Lang
16:43 Patch #21593 (Closed): Add class to contextual edit button that relates to heading on wiki pages
Committed, thanks. Jean-Philippe Lang
16:38 Patch #21611 (Closed): Do not collect ids of subtree in Query#project_statement
Committed, thanks! Jean-Philippe Lang
16:30 Defect #21263 (Resolved): Wiki lists in the sidebar are broken
Patch committed, thanks for the feedback. Jean-Philippe Lang
14:37 Defect #21263: Wiki lists in the sidebar are broken
Jean-Philippe Lang wrote:
> Daniel Ritz wrote:
> ...
Yeah, pretty much. Thinking about it some more, the minimal fix is better as it allows sidebar content at any level to insert .wiki and formatted text that just works.
Daniel Ritz
07:06 Defect #21263: Wiki lists in the sidebar are broken
Daniel Ritz wrote:
> The proper fix (IMHO) would be to wrap all content of the sidebar (except the wiki) in its own div with a class
Would you do that by adding a div in each view where there is some content for the sidebar?
If so...
Jean-Philippe Lang
16:25 Patch #3551 (Closed): Additional case of USER_FORMAT, #{lastname}#{firstname} without any sperator
Committed, thanks. Jean-Philippe Lang
16:22 Defect #21861 (Closed): typo: s/creditentials/credentials/
Committed, thanks for fixing that. Jean-Philippe Lang
16:19 Patch #21867 (Resolved): Add column `estimated_hours` for CSV import.
Patch committed in r15131, thanks. Jean-Philippe Lang
07:57 Patch #21867: Add column `estimated_hours` for CSV import.
Thanks for the patch.
I am setting target version to 3.2.1 because I think the feature to import estimated hours should have been implemented by #950.
Go MAEDA
16:13 Defect #21900 (Resolved): Moving a page with a child raises an error if target wiki contains a page with the same name as the child
Fixed in r15130, thanks for poiting this out. Jean-Philippe Lang
15:07 Defect #21900 (Closed): Moving a page with a child raises an error if target wiki contains a page with the same name as the child
Project A has Wiki pages, "Wiki-P" and "Wiki-C". "Wiki-C" is a child of "Wiki-P".
Project B has an Wiki page, "Wiki-C".
Hiroo Hayashi
15:35 Feature #21777: Include tmp/sessions/ folder in repository, please?
You can make by "rake tmp:create" and I am afraid of side effect. Toshi MARUYAMA
14:30 Feature #21623: Journalize values that are cleared after project or tracker change
Sure ! Jérôme BATAILLE
04:30 Feature #21623: Journalize values that are cleared after project or tracker change
Could you add test? Toshi MARUYAMA
14:04 Patch #21899 (Closed): Catalan wiki translation for 3.1-stable
From #21747 Toshi MARUYAMA
14:02 Patch #21898 (Closed): Catalan wiki translation for 2.6-stable
From #21747 Toshi MARUYAMA
07:20 Patch #21883 (Closed): Russian wiki translation for 3.2-stable
From https://github.com/redmine/redmine/pull/66 Toshi MARUYAMA
06:47 Patch #21882 (Closed): Russian wiki translation for 3.1-stable
From https://github.com/redmine/redmine/pull/66 Toshi MARUYAMA
06:45 Patch #21881 (Closed): Russian wiki translation for 2.6-stable
From https://github.com/redmine/redmine/pull/66 Toshi MARUYAMA
06:33 Feature #21808: Make the Sidebar collapsible, stateful
Works fine for me. Thanks for this great patch. Sliding motion is pretty good.
Go MAEDA
05:42 Patch #21747 (New): Catalan translation
Toshi MARUYAMA
05:37 Feature #4550: Allow access to files & documents to be configurable for each entry by user role
+1 Anh Le Giang
05:36 Feature #2636: Feature Request: Wiki ACLs (Access control for individual pages)
+ 1 Anh Le Giang
05:10 Feature #8392: Grant access to particular Wiki page
+1 Anh Le Giang
03:39 Patch #21847: Let mobile header be fixed
Deleting the obsolete patch.
I was also wondering if this should maybe assigned to the next minor version already? It is not a tremendously big change, more of an incremental improvement of the (already released) responsive layout.
...
Jan from Planio www.plan.io

2016-01-29

21:56 Patch #10869: Add Full PDF output to issue summary list
With every new version I hope that this feature is implemented.
It would be worth a noteable donation.
Andreas Planegger
20:42 Patch #21747: Catalan translation
You are right. I have just fix this patch ;) Helder Manuel Torres Vieira
05:02 Patch #21747 (Needs feedback): Catalan translation
Your patch is broken. Toshi MARUYAMA
20:22 Feature #21808: Make the Sidebar collapsible, stateful
Thanks for the feedback. Found the problem..the "Redmine 3.2" is why it breaks and shows the horizontal scroll bar. I only tested it on current trunk. To make it work in 3.2, you need this in the CSS as well: Daniel Ritz
18:27 Feature #21808: Make the Sidebar collapsible, stateful
I made the tests on Redmine 3.2.0 with all the plugins removed, plugins_assets folder removed and cache cleared.
To reproduce:
# Open the projects page
# Hide the sidebar
# Observe that the horizontal scroll is available
# Scroll to...
Marius BĂLTEANU
12:46 Feature #21808: Make the Sidebar collapsible, stateful
Marius Balteanu wrote:
> I made more tests and I found the attached issue Screen Shot 2016-01-29 at 00.20.06.png
It looks like like the @<body>@ gets too wide for some reason. What exactly did you do to get to this state? Do you have...
Daniel Ritz
16:27 Feature #21568: Adding support of logic relationship between boolean custom field values and other custom field
Exactly! This issue, and issue #21149, seems to point to similar functionality.
It would be great to have this feature. More complex redmine implementations would be possible with this great feature.
VD DV
15:10 Patch #21847: Let mobile header be fixed
Thank you very much for your feedback. I am uploading an updated patch, which fixes the mentioned problems by setting the z-index to a very high value (9999). Felix Gliesche
09:30 Patch #21847: Let mobile header be fixed
Thanks for the improvement!
But I have experienced some z-order related problem in gantt and calendar. please see the following screenshots.
!21847-gantt.png!
!21847-calendar.png!
Go MAEDA
15:05 Defect #21878 (Closed): ActionView::Template::Error (incompatible character encodings: ASCII-8BIT and UTF-8)
Redmine 2.5.x is not maintained.
You should ask Debian team.
Toshi MARUYAMA
14:57 Defect #21878 (Closed): ActionView::Template::Error (incompatible character encodings: ASCII-8BIT and UTF-8)
Hello,
just in the process of upgrading version 2.5.1.stable (installed on debian wheezy from wheezy backports) to 2.5.2.devel (debian jessie) and now I get the following error in production.log when trying to access the upgraded redm...
Stefan Kuhr
15:00 Defect #21877: "ArgumentError (comparison of Time with BigDecimal failed)" in app/models/setting.rb:229
Oh my, I found this: http://www.redmine.org/boards/2/topics/46006
This fixed the problem in this ticket though the next problem just waited to raise its ugly head: Defect #21878. Just wanted to add this to this ticket in case someone ...
Stefan Kuhr
14:48 Defect #21877 (Closed): "ArgumentError (comparison of Time with BigDecimal failed)" in app/models/setting.rb:229
Redmine 2.5.x is not maintained.
You should ask Debian team.
Toshi MARUYAMA
14:33 Defect #21877 (Closed): "ArgumentError (comparison of Time with BigDecimal failed)" in app/models/setting.rb:229
Hello,
just in the process of upgrading version 2.5.1.stable (installed on debian wheezy from wheezy backports) to 2.5.2.devel (debian jessie) and now I get the following error in production.log when trying to access the upgraded red...
Stefan Kuhr
02:30 Feature #10525: A new button to hide/show the sidebar
I have added full tests in new version (1.0.4)
This plugin has been used for more than 2 years in our company and the button appears correctly in all the pages.
Jérôme BATAILLE
00:38 Defect #21866 (Resolved): Reply to Forum Message results in error.
Issue resolved by upgrading sqlite to the latest available release for CentOS 6.7. @sqlite-3.6.20-1.el6_7.2.x86_64@ Ranjan Das
 

Also available in: Atom