Project

General

Profile

Activity

From 2018-06-02 to 2018-06-04

2018-06-04

23:32 Defect #28946 (Closed): If assignee is locked subtasks don't get copied
Marius BĂLTEANU
23:26 Defect #27863: If version is closed or locked subtasks don't get copied
Attached is a small patch that fixes this issue. Marius BĂLTEANU
17:54 Patch #28943 (Closed): Remove RDoc tags
I was removed :nodoc: from *.rb because yard doesn't support :nodoc: and :nodoc: shows in generated html. Sho HASHIMOTO
12:25 Feature #8095: Allow overriding the default text formatting in each project
+1
Valera Moskalev
06:54 Patch #28940: Use Regexp#match? to reduce allocations of MatchData object
Pavel Rosický wrote:
> I will revert lines with Regexp.escape tomorrow,
Done. I am attaching an updated patch.
Go MAEDA
05:42 Patch #28940: Use Regexp#match? to reduce allocations of MatchData object
I have updated match-adapters.patch. The patch does not work due to syntax errors. "@ActiveRecord::Base.connection.connection.adapter_name@" must be replaced with "@ActiveRecord::Base.connection.adapter_name@" (one extra "@.connection@"). Go MAEDA
03:22 Patch #28940: Use Regexp#match? to reduce allocations of MatchData object
+1
Redmine uses a lot of match methods.
I think it's wonderful that the test will be 5% faster.
Mizuki ISHIKAWA
03:14 Patch #28940: Use Regexp#match? to reduce allocations of MatchData object
You're right. I will revert lines with Regexp.escape tomorrow, but otherwise it should work. Pavel Rosický
02:55 Patch #28940: Use Regexp#match? to reduce allocations of MatchData object
It is a very interesting patch. But MailHandlerTest fails on my environment (Ruby 2.3). Go MAEDA
01:24 Patch #28940 (Closed): Use Regexp#match? to reduce allocations of MatchData object
since Rails 5.1+ we can use match? on a regex class safely even on older rubies
https://github.com/rails/rails/blob/5-1-stable/activesupport/lib/active_support/core_ext/regexp.rb
but the performance benefit is visible only on ruby 2....
Pavel Rosický
04:28 Feature #26618 (Closed): Support of default ActiveRecord I18n scopes in LabelledFormBuilder
Committed the patch. Thank you for your contribution. Go MAEDA
03:31 Patch #28939 (Closed): replace regexp with casecmp
Pavel Rosický wrote:
> I used match? insted in
> ...
Closing this issue because #28940 covers this improvement. Thank you.
Go MAEDA
02:19 Patch #28939 (Resolved): replace regexp with casecmp
ah, sorry. I totaly forgot about this case. I used match? insted in
http://www.redmine.org/issues/28940
so the behaviour won't be changed. Closing this one
Pavel Rosický
01:44 Patch #28939: replace regexp with casecmp
The proposed patch does not work for MySQL adapter because its name is "Mysql2". I think using exact match against adapter names is not a good solution. Go MAEDA
00:46 Patch #28939 (Closed): replace regexp with casecmp
Pavel Rosický

2018-06-03

23:19 Defect #27153: Custom query breaks calendar view with error 500
Addition here for anyone having the same problem and can't or doesn't want to upgrade. The issue is, indeed, the issue_hot_buttons plugin (or at least it was for me). Which is a really useful addition to redmine that I didn't want to los... Matthew Paul
11:45 Patch #16313: Allow to link to an anchor of the current wikipage
Here is a patch for "Wiki formatting" documents. Go MAEDA
07:00 Patch #27090 (Closed): Show the number of attachments on wiki pages
Merged to 3.4-stable branch. Go MAEDA
06:58 Patch #27090 (Reopened): Show the number of attachments on wiki pages
This change is very small but useful. I think it should be delivered as soon as possible. Go MAEDA
06:38 Defect #28693 (Closed): Irrelevant permission is required to access some tabs in project settings page
Committed. Thank you all for contributing to the Redmine project. Go MAEDA
03:26 Defect #28693 (Resolved): Irrelevant permission is required to access some tabs in project settings page
Go MAEDA
01:47 Feature #19732 (Closed): create subtask from mail
You will be able to set "Parent issue" attribute by email in Redmine 4.0.0. Please see #27070 for the detail. Go MAEDA

2018-06-02

09:28 Patch #28505 (Closed): Update pg gem to 1.0
Committed. Thank you all for the contribution. Go MAEDA
08:09 Patch #28504 (Closed): Update mysql2 gem to 0.5.0
Committed. Thank you for your contribution.
And I have updated the wiki page.
http://www.redmine.org/projects/redmine/wiki/RedmineInstall/diff?utf8=%E2%9C%93&version=291&version_from=290&commit=View+differences
Go MAEDA
05:54 Patch #28932 (Closed): [Rails 5.2] image_tag no longer generates default alt text
Committed. Thank you for the patch. Go MAEDA
04:21 Feature #25807: Upgrade to roadie-rails 1.2
Cleared target version because the gem was updated to 1.3 for Redmine 4.0.0 by #28929. Go MAEDA
04:19 Patch #28929 (Closed): Update roadie-rails to ~> 1.3.0
Committed. Thank you for your contribution. Go MAEDA
03:58 Patch #28929: Update roadie-rails to ~> 1.3.0
Pavel Rosický wrote:
> Dropped support for Rubunius and JRuby.
> ...
I think there is no problem because Redmine does not support both Rubinius and JRuby.
Go MAEDA
03:18 Defect #28879 (Closed): Download of Task
Please use forums for question after reading "How to request help":http://www.redmine.org/boards/2/topics/667.
Go MAEDA
00:38 Patch #28934 (Closed): Support migration context for plugins
https://github.com/rails/rails/commit/a2827ec9811b5012e8e366011fd44c8eb53fc714#diff-8d3c44120f7b67ff79e2fbe6a40d0ad6L1005 Pavel Rosický
 

Also available in: Atom