Project

General

Profile

Activity

From 2019-08-17 to 2019-08-19

2019-08-19

22:54 Feature #31505: Mark edited journal notes as "Edited"
Updated the patch to apply cleanly on the current trunk. Should include this in version:"4.1.0"? Marius BĂLTEANU
22:18 Feature #31925: Per role visibility settings for project custom fields
Tests pass: https://gitlab.com/redmine-org/redmine/pipelines/77163012 Marius BĂLTEANU
22:18 Feature #31925 (Closed): Per role visibility settings for project custom fields
Extracted the patch from #23997.
Marius BĂLTEANU
18:06 Defect #31900: Problem with tickets issued by rdm-mailhandler on redmine 4.0.4
I've sent the mail as requested. Gerhard Kronstorfer
15:59 Defect #31900: Problem with tickets issued by rdm-mailhandler on redmine 4.0.4
Gerhard Kronstorfer wrote:
> When I send a mail with a picture the picture is lost and the rest of the mail produceses a ticket with the same problems like with the original rdm-mailhandler.rb:
I will try to debug the issue. Could yo...
Go MAEDA
11:14 Defect #31900: Problem with tickets issued by rdm-mailhandler on redmine 4.0.4
The latest version of rdm-mailhandler.rb solves only a part of the problem.
When I send a normel mail (with no picture) the new version works perfect:
Gerhard Kronstorfer
05:16 Defect #31900: Problem with tickets issued by rdm-mailhandler on redmine 4.0.4
Could you try using the latest rdm-mailhandler.rb?: https://www.redmine.org/projects/redmine/repository/revisions/18317/entry/trunk/extra/mail_handler/rdm-mailhandler.rb
Perhaps the problem you are experiencing is related to #31549.
Go MAEDA
17:18 Defect #31924: Paging misses some entries
Gah, not markdown and I can't edit the original...
Also the example code was broken:
Attie Grande
17:15 Defect #31924 (Closed): Paging misses some entries
I've just been using the API to batch-update a large number of time entries (moving toggl ID from a comment into a custom field), and I noticed that a handful of records were not retrieved via `time_entries.json` (and thus weren't update... Attie Grande
16:42 Feature #31881: Add "behind-schedule" CSS class to issues
Here is a patch. Go MAEDA
08:17 Feature #23997: Per role visibility settings for version custom fields
Looks good to me! Jens Krämer
07:16 Feature #23997: Per role visibility settings for version custom fields
Marius BALTEANU wrote:
> Working on it, I've observed an inconsistent behaviour (which I consider it a defect/security issue), the project custom fields not visible for normal users are still visible in project settings for those users ...
Go MAEDA
02:14 Feature #30419: Drop support for MySQL 5.5
I think it is premature to drop support for MySQL 5.5.
* CentOS 7 bundles MariaDB 5.5.60. The support for CentOS ends on 2024-06-30
* The latest version of ActiveRecord 6.0.0 still supports MySQL 5.5.8: https://github.com/rails/rails...
Go MAEDA

2019-08-18

17:04 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading
Rails 6 is released: https://weblog.rubyonrails.org/2019/8/18/this-week-in-rails-rails-6-is-released-sass-rails-6-improved-mysql2-error-and-more/ Marius BĂLTEANU
16:34 Feature #31231: Better handling of HTML tables when creating an issue from an email
Updated the patch for the current trunk (r18375). Go MAEDA
15:33 Feature #31921: Changes to properly support 4 byte characters (emoji) when database is MySQL
Thanks for your detailed response, I totally missed that note and now I understand the problem.
I've removed @collation@ from default settings.
Marius BĂLTEANU
04:19 Feature #31921: Changes to properly support 4 byte characters (emoji) when database is MySQL
As mentioned in #19742#note-3, the collation utf8mb4_unicode_ci is really problematic for Japanese users. I think it is better to leave it to users without setting a default value. At least, we should not set utf8mb4_unicode_ci as the de... Go MAEDA
14:49 Defect #31870 (Closed): Remove deprecated .zIndex() method
Committed the patch. Thank you for your contribution. Go MAEDA
12:52 Feature #29663: Select a JavaScript library to handle tags
Another library is https://slimselectjs.com which seems to be a very good candidate from my tests.
Marius BĂLTEANU
06:04 Patch #31441: Show elements titles using jQuery UI tooltips
Marius BALTEANU wrote:
> Go Maeda, is it better if we remove the title the from gantt issue subject?
I agree.
But I would like to suggest another option. How about setting "Assignee (Status)" instead of removing the subject? The a...
Go MAEDA
05:28 Feature #31859 (Closed): Per role visibility settings for spent time custom fields
Marius BALTEANU wrote:
> In order to restore the previous behaviour, I see 2 options:
> ...
Committed the second patch in r18376. Thanks.
Go MAEDA

2019-08-17

21:29 Feature #31859: Per role visibility settings for spent time custom fields
Hi There,
thanks a lot once again for all the work here...
I was just about to try to apply the patch in our prod redmine and found this new comment, which I'm afraid do not understand fully.
Does that mean I should wait with th...
Jenda Benda
11:53 Feature #31859 (Reopened): Per role visibility settings for spent time custom fields
The patch changed also the location where @<%= call_hook(:"view_custom_fields_form_#{@custom_field.type.to_s.underscore}", :custom_field => @custom_field, :form => f) %>@ is rendered.
Before this patch, the hook was rendered inside th...
Marius BĂLTEANU
18:20 Patch #19742 (Closed): RedmineInstall: MySQL: collation_database
[[RedmineInstall]] was updated in the mean time. Marius BĂLTEANU
18:12 Defect #28774 (Closed): Internal Error when Submit the Description with Vietnamese in Unicode fonts
Marius BĂLTEANU
18:10 Feature #31921 (Closed): Changes to properly support 4 byte characters (emoji) when database is MySQL
Currently, Redmine with MySQL as database doesn't support very well 4 byte characters (for ex: emojis) and you need some experience with MySQL in order to properly configure MySQL (and Redmine) to support those characters. Because of thi... Marius BĂLTEANU
16:08 Feature #1237: Add support for two-factor authentication
the fifth patch of the series actually adds a new feature on top of this so I created a separate issue for it: #31920 Jens Krämer
16:05 Feature #1237: Add support for two-factor authentication
I apologize, uploading files on an ipad is still a problem unfortunately :)
Jens Krämer
16:01 Feature #1237: Add support for two-factor authentication
Jens Krämer wrote:
> I rebased the patch series on top of current master and added an integration test covering the basic activation / totp and backup code functionality. I also fixed the above problem by making the account deletion lin...
Marius BĂLTEANU
15:47 Feature #1237: Add support for two-factor authentication
I rebased the patch series on top of current master and added an integration test covering the basic activation / totp and backup code functionality. I also fixed the above problem by making the account deletion link more explicit.
Jens Krämer
16:07 Feature #31920 (Closed): Require 2FA only for certain user groups
This patch, which should be applied on top of those from #1237, adds a flag to groups so 2FA can be globally optional, but required for certain groups of users. Jens Krämer
12:26 Patch #31441: Show elements titles using jQuery UI tooltips
Go Maeda, is it better if we remove the title the from gantt issue subject? Marius BĂLTEANU
11:08 Feature #31231: Better handling of HTML tables when creating an issue from an email
Very nice feature, but it doesn't apply cleanly on the current trunk. Can you update the patch? I would like to add support for lists (<ul>) as well. Marius BĂLTEANU
06:26 Patch #31919 (Closed): Update roadie-rails gem (~> 2.1.0)
Committed. Go MAEDA
05:56 Patch #31919: Update roadie-rails gem (~> 2.1.0)
roadie-rails 1.3.0 does not support Rails 6.
roadie-rails.gemspec:
Go MAEDA
05:49 Patch #31919 (Closed): Update roadie-rails gem (~> 2.1.0)
Go MAEDA
04:25 Patch #31855 (Closed): Speed up workflow edit page rendering
Committed the patch. It improves the rendering speed significantly. Thanks! Go MAEDA
04:03 Patch #31320 (Closed): Set an appropriate default type in New custom field page depending on the current tab
Marius BALTEANU wrote:
> An issue was reported in #31896.
Fixed in r18372.
Go MAEDA
04:02 Defect #31896 (Closed): Admin screen - "New custom field" button does not work if there are no custom fields
Committed the fix. Thank you all for reporting and fixing this issue. Go MAEDA
03:34 Defect #31917 (Closed): Tracker management and auto close issues
Please use forums for questions. Reading "How to request help":http://www.redmine.org/boards/2/topics/667 may be helpful for you. Go MAEDA
 

Also available in: Atom