Project

General

Profile

Activity

From 2020-08-28 to 2020-08-30

2020-08-30

17:50 Defect #33930 (Closed): 500 error when attempting to create custom field enumeration with empty name
When editing the list of possible values for a key/value custom field type, clicking "Add" with the field empty will lead to a HTTP 500 error from Redmine. An example stack trace is attached. The error is confirmed on current master.
...
Felix Schäfer
16:03 Defect #33766: #31355 breaks project tree
Hello,
I can confirm this issue and I have also very much projects with subprojects...
The dropdown view is also on my redmine as described and very confusing...
Waiting for 4.2.0 is there any release date?
Roland M
16:00 Patch #33929 (Closed): Encrypt / decrypt TOTP secret keys with `rake db:encrypt` / `rake db:decrypt`
Secret keys for two-factor authentication stored in @User#twofa_totp_key@ are encrypted if @database_cipher_key@ is set in @config/configuration.yml@. So, @rake db:encrypt@ and @rake db:decrypt@ should also support @User#twofa_totp_key@. Go MAEDA
15:02 Defect #33926: Rake tasks "db:encrypt" and "db:decrypt" may fail due to validation error
Added test code. Go MAEDA
10:32 Defect #33926 (Closed): Rake tasks "db:encrypt" and "db:decrypt" may fail due to validation error
@encrypt_all@ and @decrypt_all@ methods in @lib/redmine/ciphering.rb@ are expected to skip validation when saving an object. But they don't because of typo in parameter name.
It may cause a failure to run @rake db:encrypt@ or @rake db...
Go MAEDA
12:42 Defect #33925: ArgumentError in lib/redmine/twofa/base.rb after updating a source file in development mode
Thank you for catching this bug. The patch looks good to me. Felix Schäfer
09:23 Defect #33925 (Closed): ArgumentError in lib/redmine/twofa/base.rb after updating a source file in development mode
The attached patch attachment:fix-2fa-argument-error.patch fixes the error described below. The error occurs in development mode. No problem in production mode.
Steps to reproduce:
1. Run Redmine in development mode (@bin/rails s@)...
Go MAEDA
09:39 Patch #33923 (Closed): Japanese translation update (r19993)
Committed the patch. Go MAEDA
04:48 Patch #33923 (Closed): Japanese translation update (r19993)
Updated strings for two-factor authentication added by #1237. Go MAEDA
09:39 Revision 19994 (svn): Japanese translation update (#33923).
Patch by Go MAEDA. Go MAEDA

2020-08-29

09:31 Feature #1237 (Closed): Add support for two-factor authentication
Committed the patches from Planio. Thank you for your great contribution. Go MAEDA
09:30 Revision 19993 (svn): Update locales (#1237).
Go MAEDA
09:25 Revision 19992 (svn): RuboCop: Disable Rails/FilePath and Style/ClassVars in lib/redmine/twofa.rb (#1237).
Go MAEDA
09:07 Revision 19991 (svn): Integration test for 2fa auth (#1237).
Patch by Jens Krämer. Go MAEDA
08:51 Revision 19990 (svn): Backup codes for 2fa auth (#1237).
Patch by Felix Schäfer. Go MAEDA
08:37 Revision 19989 (svn): Adds a setting to disable/enable/require 2fa auth (#1237).
Patch by Felix Schäfer. Go MAEDA
08:21 Revision 19988 (svn): Adds two factor authentication support (#1237).
Patch by Felix Schäfer. Go MAEDA
07:54 Revision 19987 (svn): RuboCop: Update .rubocop_todo.yml
Go MAEDA

2020-08-28

10:17 Defect #33289: Updating time tracking activities in project setting may take too long time
Thank you for your analysis.
If SQL is executed 66 times, it will take time to update.
Is it possible to improve it?
shigeo teraoka
09:48 Defect #33289: Updating time tracking activities in project setting may take too long time
It seems that processing https://www.redmine.org/projects/redmine/repository/revisions/19983/entry/trunk/app/models/enumeration.rb#L150 takes a long time.
The following SQL is executed every time one setting is changed.
If you have ...
Mizuki ISHIKAWA
05:46 Feature #33918: Add documentation for #29473
Especially should be made clear where this feature is and isn't available. All forms? From all active form elements? Mischa The Evil
05:36 Feature #33918 (Closed): Add documentation for #29473
This feature should be documented on [[RedmineKeyboardNavigation]]. Mischa The Evil
02:01 Feature #29473 (Closed): Submit a form with Ctrl+Enter / Command+Return
Committed the patch. Thank you for improving Redmine. Go MAEDA
02:01 Revision 19986 (svn): Submit a form with Ctrl+Enter / Command+Return (#29473).
Patch by Mizuki ISHIKAWA. Go MAEDA
01:32 Feature #33906: Upgrade Rails to 5.2.4.5
Go MAEDA wrote:
> Mischa The Evil wrote:
> ...
I do not, though given the remaining[1] history, I think Marius should be able to tell this.
fn1. the last update of the file in r19803 destroyed the file's prior history in SCM.
Mischa The Evil
 

Also available in: Atom