Project

General

Profile

Activity

From 2020-10-21 to 2020-10-23

2020-10-23

10:39 Patch #34071: Handle AuthSourceExceptions in User.try_to_login
The patch also fixes an issue that Redmine might return 500 error and HTML body against an API request. Go MAEDA
08:23 Feature #15340: Custom field referencing other tickets
+1 Fabien Durand
08:22 Feature #7849: custom issue relation types
+1 Fabien Durand
03:31 Patch #32531 (Closed): Update RuboCop Rails to 2.9
Updated ruboCop Rails to 2.8 in r20172. Go MAEDA
02:55 Patch #32531 (Reopened): Update RuboCop Rails to 2.9
The latest version is 2.8.1.
https://rubygems.org/gems/rubocop-rails/versions/2.8.1
Since Redmine dropped support for Ruby 2.3 (#34142), we can update rubocop-rails to 2.8 that requires Ruby >= 2.4.0.
Go MAEDA
03:30 Revision 20172 (svn): Update RuboCop Rails to 2.8 (#32531).
Go MAEDA
02:47 Patch #32530 (Closed): Update RuboCop to 1.12
Updated RuboCop to 1.0 in r20171. Go MAEDA
02:47 Revision 20171 (svn): Update RuboCop to 1.0 (#32530).
Go MAEDA
02:30 Revision 20170 (svn): Update .rubocop_todo.yml (#32530).
Go MAEDA
02:17 Revision 20169 (svn): RuboCop: Set TargetRubyVersion to 2.4 (#34142).
Go MAEDA
02:13 Patch #34150 (Closed): Use match? instead of =~ when MatchData is not used
Committed the patch. Go MAEDA
02:13 Revision 20168 (svn): Use match? instead of =~ when MatchData is not used (#34150).
Patch by Go MAEDA. Go MAEDA
00:04 Defect #27780: Case-insensitive matching fails for Unicode filenames when referring to attachments in text formatting
Setting the target version to 4.2.0. Go MAEDA

2020-10-22

16:30 Defect #27780: Case-insensitive matching fails for Unicode filenames when referring to attachments in text formatting
Added test code to Амир Мусин's patch. Go MAEDA
16:18 Revision 20167 (svn): use with_settings at IssuesControllerTest#test_show_should_not_disclose_relations_to_invisible_issues
Toshi MARUYAMA
16:18 Revision 20166 (svn): shorten long line of test/unit/issue_test.rb
Toshi MARUYAMA
16:18 Revision 20165 (svn): shorten long line of TimeEntryQueryTest
Toshi MARUYAMA
16:18 Revision 20164 (svn): shorten long line of test/unit/query_test.rb
Toshi MARUYAMA
16:18 Revision 20163 (svn): shorten long line of lib/redmine.rb
Toshi MARUYAMA
16:18 Revision 20162 (svn): shorten long line of app/models/document.rb
Toshi MARUYAMA
16:17 Revision 20161 (svn): shorten long line of lib/redmine/default_data/loader.rb
Toshi MARUYAMA
16:17 Revision 20160 (svn): shorten long line of app/models/wiki_content_version.rb
Toshi MARUYAMA
16:17 Revision 20159 (svn): shorten long line of app/models/journal.rb
Toshi MARUYAMA
16:17 Revision 20158 (svn): shorten long line of app/models/attachment.rb
Toshi MARUYAMA
16:17 Revision 20157 (svn): shorten long line of NewsController
Toshi MARUYAMA
16:17 Revision 20156 (svn): shorten long line of test/integration/lib/redmine/menu_manager_test.rb
Toshi MARUYAMA
11:25 Patch #34153 (Closed): Use sum instead of inject(0, :+)
@Array#sum@ introduced in Ruby 2.4 is much faster than @Enumerable#inject@. Go MAEDA
09:14 Feature #31500: Ruby 2.7 support
Enziin System wrote:
> Redmine run passed all tests on Ruby 2.7.2, isn't it?
Yes. Redmine on Ruby 2.7.2 passes all tests without warnings.
Go MAEDA
09:10 Feature #31500: Ruby 2.7 support
Ok, thanks!
In the above comment, you said "I think it is no problem to use Ruby 2.7.2 now"
Redmine run passed all tests on Ruby 2.7.2, isn't it?
Enziin System
08:12 Defect #34151 (Closed): Description Field is mandatory but not marked an such
> Sorry must be a local issue
Thank you for reporting that. Closing.
Go MAEDA
08:04 Defect #34151 (Resolved): Description Field is mandatory but not marked an such
Sorry must be a local issue Christian Zabanski
07:56 Defect #34151 (Closed): Description Field is mandatory but not marked an such
Christian Zabanski
04:42 Patch #34122: Store inline autocomplete data sources in a JS variable
+1
The change makes views clearner.
Go MAEDA
04:34 Revision 20155 (svn): Fix RuboCop offense Style/RedundantCapitalW due to r20154 (#34142).
Go MAEDA
04:17 Patch #34150 (Closed): Use match? instead of =~ when MatchData is not used
@String#match?@ was added in Ruby 2.4. you can replace @=~@ with faster @String#match?@ or @Regexp#match?@ when MatchData generated by `=~` is not necessary.
The attached patch changes such @=~@ to @mach?@. I generated the patch with ...
Go MAEDA

2020-10-21

18:55 Defect #34149 (New): Russian names for months in wrong declension
for path Nikolay Nowitsky
04:52 Defect #27780: Case-insensitive matching fails for Unicode filenames when referring to attachments in text formatting
Go MAEDA wrote:
> Go MAEDA wrote:
> ...
It is not necessary now because the trunk dropped support for Ruby 2.3 (#34142).
Go MAEDA
04:43 Feature #34142 (Closed): Drop Ruby 2.3 support
Committed the change. Go MAEDA
04:41 Revision 20154 (svn): Drop Ruby 2.3 support (#34142).
Go MAEDA
 

Also available in: Atom