Activity
From 2020-10-24 to 2020-10-26
2020-10-26
-
22:09 Defect #34165: RuboCop warns Layout/SpaceInsideBlockBraces and Layout/SpaceInsideHashLiteralBraces due to r20189 and r20190
- Toshi, how do you want to proceed on this? I agree with Go Maeda, there are too many warnings in the current trunk and for sure we won't touch all those files in order to fix them.
Rubocop log output: https://gitlab.com/redmine-org/r... -
22:05 Patch #16069: Allow configuration of API limit instead of hardcoding at 100
- The final result of the patch series posted by vzvu 3k6k and Mizuki looks good to me and all the tests pass: https://gitlab.com/redmine-org/redmine/-/pipelines/207877707
I propose to evaluate this for 4.2.0, but we should have Jean-Ph... -
08:10 Patch #16069: Allow configuration of API limit instead of hardcoding at 100
- vzvu 3k6k wrote:
> Go MAEDA wrote:
> ...
The attached patch adds validation, though it may not be the best way to write it. -
19:38 Feature #7322: add ability to filter the activity page
- +1 by Tracker
-
16:39 Defect #22819: Internal Error while create new issue
- Hi, Im working with version 3.0.2 with Rails 4.2.1. and resolve this problem, but I have a new problem when delete an Issue.
In log I can see this error -
14:36 Revision 20204 (svn): use with_settings at IssuesControllerTest#test_index_with_project_and_subprojects
-
14:36 Revision 20203 (svn): fix source indent of IssuesControllerTransactionTest
-
14:35 Revision 20202 (svn): fix source indent of DocumentsControllerTest
-
14:35 Revision 20201 (svn): fix source indent of test/unit/query_test.rb
-
14:35 Revision 20200 (svn): fix source indent of test/unit/query_test.rb
-
14:35 Revision 20199 (svn): fix source indent of test/unit/lib/redmine/menu_manager/menu_helper_test.rb
-
14:35 Revision 20198 (svn): fix source indent of RolesControllerTest
-
14:35 Revision 20197 (svn): fix source indent of SysControllerTest
-
14:35 Revision 20196 (svn): fix source indent of ImportsControllerTest
-
14:35 Revision 20195 (svn): fix source indent of ApplicationHelperTest
-
14:34 Revision 20194 (svn): fix source indent of lib/redmine/scm/adapters/filesystem_adapter.rb
-
14:34 Revision 20193 (svn): fix source indent of lib/redmine/scm/adapters/bazaar_adapter.rb
-
12:58 Defect #33881: No email notifications for status changes triggered by fixing keywords in repository commits.
- Same here. I digged a little bit deeper:
When I manually trigger fetching the git commits by going to the repositories page, then email sending of status changes triggered by a commit works fine. If the commits are fetched by the redm... -
10:07 Defect #34167: when i put if condition and update any field the if condition field lost data
- 0
the issue is solved replace disable to readonly -
08:49 Defect #34167: when i put if condition and update any field the if condition field lost data
- when i put if statement filed note is cleared after update any field
-
07:39 Patch #34169 (Closed): MessagesControllerTest#test_post_new randomly fails
- MessagesControllerTest # test_post_new test fails (trunk)
2020-10-25
-
23:10 Defect #34167 (Closed): when i put if condition and update any field the if condition field lost data
-
10:43 Patch #34166 (Closed): Fix wrong comment for Mailer.deliver_lost_password
- Fixed.
-
10:40 Patch #34166 (Closed): Fix wrong comment for Mailer.deliver_lost_password
-
10:42 Revision 20192 (svn): Fix wrong comment for Mailer.deliver_account_activated (#34166).
-
08:10 Defect #8714 (Closed): mail-address parsing in app/models/mail_handler.rb (create_user_from_email) barks on names with Umlauts
- Go MAEDA wrote:
> The following test works fine on Redmine 4.0. Does anyone still experience this issue?
> ...
I cannot reproduce the issue with Redmine 3.4, 4.0, and 4.1. I think we can close this issue. -
08:04 Defect #32315 (Closed): Impossible to validate API key without modifying anything
- Fixed in Redmine 4.1.0 (#30086).
You can check if an API is correct or incorrect by sending GET request. The API key is incorrect if HTTP status code is 401.
-
07:24 Defect #33529 (Closed): New issue / updating issue email notification receiving delay....
- Redmine sends out mail immediately, so I think it is a problem with the mail servers involved in the delivery.
-
04:43 Patch #34061: Update locales for Vietnamese language
- +1
-
04:10 Defect #34165 (Closed): RuboCop warns Layout/SpaceInsideBlockBraces and Layout/SpaceInsideHashLiteralBraces due to r20189 and r20190
- RuboCops displays huge numbers of warnings in the latest trunk.
This is because someone changed .ruboco.yml by committing r20189 and r20190. Those can be disabled again by reverting the two commits. -
02:37 Feature #33902 (Closed): Server-Handler for GIF
- Go MAEDA wrote:
> The reason for sending images with a "Content-Disposition: attachment" is to fix a security flaw "CVE-2017-15574":https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-15574. The change was made in r16285.
Closing... -
02:01 Revision 20191 (svn): Store inline autocomplete data sources in a JS variable (#34122).
- Patch by Marius BALTEANU.
-
02:01 Patch #34122 (Closed): Store inline autocomplete data sources in a JS variable
- Committed the patch. Thank you.
2020-10-24
-
17:17 Revision 20190 (svn): restore r18857 lost by r20171 (#32530)
-
17:17 Revision 20189 (svn): restore r18851 lost by r20171 (#32530)
-
16:40 Revision 20188 (svn): use with_settings at IssuesControllerTest#test_index_with_project
-
16:40 Revision 20187 (svn): fix source indent of lib/redmine/scm/adapters/filesystem_adapter.rb
-
16:40 Revision 20186 (svn): fix source indent of RepositorySubversionTest
-
16:40 Revision 20185 (svn): fix source indent of lib/redmine/scm/adapters/subversion_adapter.rb
-
16:40 Revision 20184 (svn): fix source indent of TrackersControllerTest
-
16:40 Revision 20183 (svn): fix source indent of QueriesControllerTest
-
16:39 Revision 20182 (svn): fix source indent of TimelogControllerTest
-
16:39 Revision 20181 (svn): shorten long line of app/models/time_entry.rb
-
16:39 Revision 20180 (svn): shorten long line of GanttsController
-
16:39 Revision 20179 (svn): shorten long line of VersionsController
-
16:39 Revision 20178 (svn): shorten long line of ProjectsController
-
16:39 Revision 20177 (svn): shorten long line of test/unit/issue_test.rb
-
10:55 Feature #33802: Sub task feature without creating a new issue
- You can use Custom Workflow Plugin and Write small Ruby Code to create these items.
I use this Feature in our instance -
10:16 Feature #33894: Automatically set done ratio to 100% when closing a issue
- Thank you for posting the patch but I think the behavior that status is set to 100% on the edit page is sometimes problematic.
Suppose the following senario.
1. A user mistakenly select "Closed" status. The done ratio is immediatel... -
09:41 Feature #33894: Automatically set done ratio to 100% when closing a issue
- It turned out that a condition in `done_ratio_editable?` was wrong.
I have attached a fixed patch. -
10:02 Patch #16069: Allow configuration of API limit instead of hardcoding at 100
- Looks good. We've wrote a patch based on Domingo Galdos' one (Patch 0001) with Juno NISHIZAKI, sanak and me on Redmine patch meeting 4th.
The changes are as follows:
* Added a test. (Patch 0002)
* Moved the configuration value form ... -
08:50 Patch #34161 (Closed): Replace gsub with tr, delete, or squeeze
- Committed.
-
08:14 Patch #34161 (Closed): Replace gsub with tr, delete, or squeeze
- @String#tr@, @String#delete@, and @String#squeeze@ are faster than @String#gsub@.
https://docs.rubocop.org/rubocop-performance/cops_performance.html#performancestringreplacement
https://github.com/JuanitoFatas/fast-ruby#stringgsub-vs... -
08:46 Revision 20176 (svn): Replace gsub with tr, delete, or squeeze (#34161).
-
07:42 Patch #34160 (Closed): Replace Hash#merge! with Hash#[]=
- Done.
-
07:24 Patch #34160 (Closed): Replace Hash#merge! with Hash#[]=
- @Hash#[]=@ is faster than @Hash#merge!@.
https://docs.rubocop.org/rubocop-performance/cops_performance.html#performanceredundantmerge
https://github.com/JuanitoFatas/fast-ruby#hashmerge-vs-hash-code
Replacement can be done with Ru... -
07:33 Revision 20175 (svn): Replace Hash#merge! with Hash#[]= (#34160).
-
04:19 Patch #34159 (Closed): Update RuboCop Performance to 1.10
- Committed the patch.
-
03:54 Patch #34159 (Closed): Update RuboCop Performance to 1.10
- Since Redmine dropped the support for Ruby 2.3, we can update RuboCop Performance from 1.5 to 1.8.
-
04:19 Revision 20174 (svn): Update RuboCop Performance to 1.8 (#34159).
-
03:41 Patch #34071: Handle AuthSourceExceptions in User.try_to_login
- Setting the target version to 4.2.0.
-
03:39 Patch #34153 (Closed): Use sum instead of inject(0, :+)
- Committed the patch.
-
03:39 Revision 20173 (svn): Use sum instead of inject(0, :+) (#34153).
- Patch by Go MAEDA.