Activity
From 2020-12-02 to 2020-12-04
2020-12-04
-
21:00 Defect #34397 (Closed): PDF thumbnail to PNG failing on ruby 2.5
- We have Redmine 4.1.1 hosted on an ubuntu server but whenever we attach PDFs, the thumbnails show up as 404 broken links despite it appearing that it is set up correctly:
!info.png!
All image attachments do show thumbnails correctl... -
15:00 Revision 20575 (svn): use with_settings at MailHandlerControllerTest#test_should_not_allow_with_wrong_key
-
14:59 Revision 20574 (svn): add empty line after guard clause to lib/redmine/twofa/base.rb
-
14:59 Revision 20573 (svn): add empty line after guard clause to lib/redmine/menu_manager.rb
-
14:59 Revision 20572 (svn): add empty line after guard clause to lib/redmine/i18n.rb
-
14:59 Revision 20571 (svn): add empty line after guard clause to lib/redmine/helpers/gantt.rb
-
14:59 Revision 20570 (svn): shorten long line of Query#add_custom_fields_filters
-
14:59 Revision 20569 (svn): shorten long line of lib/redmine/database.rb
-
14:59 Revision 20568 (svn): fix source indent of lib/redmine/default_data/loader.rb
-
14:58 Revision 20567 (svn): fix source indent of test/unit/lib/redmine/unified_diff_test.rb
-
14:58 Revision 20566 (svn): fix source indent of test/unit/repository_bazaar_test.rb
-
14:58 Revision 20565 (svn): fix source indent of test/unit/project_nested_set_concurrency_test.rb
-
14:58 Revision 20564 (svn): add Layout/ClosingParenthesisIndentation excluding files to .rubocop.yml
-
08:02 Feature #34303: Allow to add subtask from context menu
- The concept proposed by Maeda worked fine on my environment (trunk@20562).
I have made the test code for 34303-poc.patch and attach it. -
07:57 Defect #34326: CSV import raises an exception if CSV header has empty columns
- Setting the target version to 4.2.0.
-
01:11 Defect #34326: CSV import raises an exception if CSV header has empty columns
- Go MAEDA wrote:
> Yuichi HARADA wrote:
> ...
Thank you for your point. I think it's good because you can detect test failures without changing the test. -
01:56 Feature #34307: Create custom field by copy
- The patch for #note-1 was incomplete and I will reattach it.
-
01:03 Feature #34307: Create custom field by copy
- I made a patch to copy the custom field and attach it.
I confirmed that this patch works fine on latest trunk@20562. -
01:40 Defect #33355 (Closed): TypeError when attempting to update a user with a blank email address
-
01:40 Revision 20563 (svn): Merged r20562 from trunk to 4.1-stable (#33355).
2020-12-03
-
16:14 Defect #33355 (Resolved): TypeError when attempting to update a user with a blank email address
- Committed the patch.
-
16:14 Revision 20562 (svn): TypeError when attempting to update a user with a blank email address (#33355).
- Patch by Go MAEDA.
-
16:06 Defect #33952: Spent time details are displayed in incorrect order when sorted by week and date
- I have slightly updated the test code.
Setting the target version to 4.1.2. -
15:12 Defect #34326: CSV import raises an exception if CSV header has empty columns
- Yuichi HARADA wrote:
> I created a patch. No exception is raised if there are blank columns in the CSV header.
> ...
Thank you for the patch. I think the test can be simplified by putting the blank column at the end. -
14:20 Revision 20561 (svn): use with_settings at MailHandlerControllerTest#test_should_not_allow_with_api_disabled
-
14:20 Revision 20560 (svn): add space after comma to lib/redmine/export/pdf/issues_pdf_helper.rb
-
14:20 Revision 20559 (svn): shorten long line of ApplicationHelperTest
-
14:20 Revision 20558 (svn): shorten long line of test/unit/mailer_test.rb
-
14:20 Revision 20557 (svn): shorten long line of test/unit/lib/redmine/notifiable_test.rb
-
14:19 Revision 20556 (svn): shorten long line of test/unit/workflow_transition_test.rb
-
14:19 Revision 20555 (svn): fix source indent of test/integration/account_test.rb
-
14:19 Revision 20554 (svn): fix source indent of test/integration/admin_test.rb
-
14:19 Revision 20553 (svn): fix source indent of test/unit/mailer_test.rb
-
14:19 Revision 20552 (svn): fix source indent of test/unit/mail_handler_test.rb
-
14:19 Revision 20551 (svn): fix source indent of test/integration/api_test/issues_test.rb
-
14:19 Revision 20550 (svn): fix source indent of test/integration/api_test/projects_test.rb
-
11:20 Feature #8568: add ability to designate default watchers by tracker/project
- Would it be interesting to close (reject?) the issue and redirect the users/reporters to a Redmine plugin, or another way to do the job (as Jie Lio suggested)?
-
09:20 Defect #34297: Subprojects issues are not displayed on main project when all subprojects are closed
- Go MAEDA wrote:
> I have confirmed the reported behavior. If there are one or more open subprojects, issues in closed subprojects are visible in a parent project's issues list. However, if all subprojects are closed, all issues from sub... -
09:15 Feature #34369: Implementation of great added value for the Redmine System
- +1000
-
08:35 Defect #34375: "is not" operator for Subproject filter incorrectly excludes closed subprojects
- The issue is caused at source:branches/4.1-stable/app/models/query.rb#L886
-
06:58 Defect #34375 (Closed): "is not" operator for Subproject filter incorrectly excludes closed subprojects
- "is not" operator for Subproject is expected to exclude only given projects, however, it actually excludes closed projects as well.
Suppose the following project tree.
2020-12-02
-
23:00 Feature #34369 (New): Implementation of great added value for the Redmine System
- Without this impelmentation. The system is compromised. A simple matter to resolve. I am not a Ruby programmer but there is a whole community of users waiting for this implementation
Good night ! I have already positioned myself on Re... -
22:48 Patch #34119 (Closed): Fix selenium chrome options so files are downloaded to tmp/downloads in system tests
- Committed the fix. Thank you.
-
09:48 Patch #34119: Fix selenium chrome options so files are downloaded to tmp/downloads in system tests
- Updated the patch for the current trunk.
-
22:48 Revision 20549 (svn): Fix selenium chrome options so files are downloaded to tmp/downloads in system tests (#34119).
- Patch by Jens Krämer.
-
16:52 Feature #9059: Custom fields should be editable based on role not only for admin
- I need it too!
-
15:13 Defect #34367 (Closed): Allowed filename extensions of attachments can be circumvented
- In #20008, Redmine introduced the ability to restrict the allowed extensions of attachment filenames.
This check is not exhaustive though, meaning it is easily possible to subvert the restriction. There are two ways how a user can sti... -
15:07 Revision 20548 (svn): RuboCop: Fix Layout/SpaceInsideBlockBraces due to r20547 (#34071).
-
15:00 Feature #33658: robots.txt: disallow crawling login, register, and lost password form
- Looks good to me, thanks!
-
09:34 Feature #33658: robots.txt: disallow crawling login, register, and lost password form
- Holger Just wrote:
> Redmine already generates a @robots.txt@ in @welcome#robots@. Wouldn't this be better suited there, specifically in source:trunk/app/views/welcome/robots.text.erb so that we have a single location where we define be... -
14:56 Patch #34071 (Closed): Handle AuthSourceExceptions in User.try_to_login
- Committed the patch. Thank you for your contribution.
-
14:56 Revision 20547 (svn): Changes User.try_to_login to catch and log AuthSourceExceptions, and introduces User.try_to_login! replicating the original behavior (#34071).
- Patch by Jens Krämer.
-
14:32 Revision 20546 (svn): use with_settings at MailHandlerControllerTest#test_should_respond_with_422_if_not_created
-
14:32 Revision 20545 (svn): shorten long line of QueriesHelper
-
14:32 Revision 20544 (svn): fix source indent of test/integration/api_test/api_test.rb
-
14:31 Revision 20543 (svn): fix source indent of test/integration/api_test/attachments_test.rb
-
14:31 Revision 20542 (svn): fix source indent of AttachmentFieldFormatTest
-
14:31 Revision 20541 (svn): fix source indent of test/unit/repository_git_test.rb
-
14:31 Revision 20540 (svn): fix source indent of GitAdapterTest
-
14:31 Revision 20539 (svn): fix source indent of test/integration/repositories_git_test.rb
-
14:31 Revision 20538 (svn): fix source indent of MercurialAdapterTest
-
14:31 Revision 20537 (svn): fix source indent of lib/redmine/scm/adapters/mercurial_adapter.rb
-
14:30 Revision 20536 (svn): fix source indent of test/unit/repository_mercurial_test.rb
-
14:30 Revision 20535 (svn): fix source indent of lib/redmine/access_keys.rb
-
09:37 Feature #24766: Custom fields grouping
- +1
-
08:57 Defect #34338 (Closed): issue export button disappear
- Thank you for your feedback. Closing.
-
04:33 Feature #34258 (Closed): Create tracker by copy
- Go MAEDA wrote:
> The test randomly fails due to r20492.
Committed the fix in r20534.
-
04:32 Revision 20534 (svn): Fix random test failure due to r20492 (#34258).
-
04:28 Defect #34357 (Closed): Fix Capybara::Ambiguous: Ambiguous match, found 2 elements matching visible link or button "eCookbook"
- Committed the fix as a part of #32944. Thank you.
-
04:27 Revision 20533 (svn): Fix Capybara::Ambiguous: Ambiguous match, found 2 elements matching visible link or button "eCookbook" (#32944, #34357).
- Patch by Marius BALTEANU.