Redmine

I'm seeing the same problem in Redmine 2.2.1.
In my Database the spent time values is for example 0.1, but the pdf export displays 0.100000001490116.

Maybe this relates to the float_max like #12680?

Daniel Felix wrote:

Maybe this relates to the float_max like #12680?

• 0.1 -> IEEE754 Single precision 32-bit
• 999999999999999999999999999999 -> IEEE754 Single precision 32-bit

UPDATE: No. It does not relate to #12680.

Please, could you fix this with redmine 2.3?

Filou Centrinov wrote:

UPDATE: No. It does not relate to #12680.

Why not? It seems for me to be again some floating point error, which we've encounter many times in different systems.

Daniel Felix wrote:

Why not? It seems for me to be again some floating point error, which we've encounter many times in different systems.

The difference is: In #12680 the number is too big, so the floating precision can not be provided. In this issue we are within the floating precision, so the correct presentation should be provided.

The problem is internal caused by displaying a value with a higher precision then the value originaly had. So 0.1 becomes 0.100000001490116, because the type of variable had a precision of 32bit that allows only 8 positions after decimal point. Therefore this problem can easly fixed by: "%.2f" % value
See: pdf.rb.patch

In /lib/redmine/i18n.rb is a function called l_hours to format hours into a value+label string. If this function would'nt be used in /app/view/issues/show.html.erb you get the same effect of displayed spent time.

So l_hours fixes the same "bug", but with an additional label.

Please fix this. It's a small fix. ... or make it to a candidate.

• 3.50h
• 1.25h
• 0.30h (I think I've entered "0:20")

• 5.05 with Web User Interface (HTML) --> good
• 5.050000011920929 with PDF-Export --> chould be improved
• "spent_hours":5.050000011920929 with REST API (JSON) using http://myhost/redmine/issues/1234.json --> chould be improved

You can see by following change.

diff --git a/app/views/issues/_attributes.html.erb b/app/views/issues/_attributes.html.erb
--- a/app/views/issues/_attributes.html.erb
+++ b/app/views/issues/_attributes.html.erb
@@ -63,7 +63,7 @@
 <% end %>

 <% if @issue.safe_attribute? 'estimated_hours' %>
-<p><%= f.text_field :estimated_hours, :size => 3, :disabled => !@issue.leaf?, :required => @issue.required_attribute?('estimated_hours') %> <%= l(:field_hours) %></p>
+<p><%= f.text_field :estimated_hours, :size => 6, :disabled => !@issue.leaf?, :required => @issue.required_attribute?('estimated_hours') %> <%= l(:field_hours) %></p>
 <% end %>

 <% if @issue.safe_attribute?('done_ratio') && @issue.leaf? && Issue.use_field_for_done_ratio? %>

Tested on 3.3.1, still occurs.

Problem still exists in Redmine 3.3.2, but could fix it here:
/lib/redmine/export/pdf/issues_pdf_helper.rb

Search for

if value.is_a?(Date)
    format_date(value)
elsif value.is_a?(Time)
    format_time(value)
else
    value
end

and replace by

if value.is_a?(Date)
    format_date(value)
elsif value.is_a?(Time)
    format_time(value)
elsif value.is_a?(Float)
    sprintf "%.2f", value
else
    value
end

We might want some test coverage added if there isn't any yet, as Jean-Baptiste already suggested.

Marius, thank you for adding a test. But I encountered the following error. Could you look into it?

$ ruby test/unit/lib/redmine/export/pdf/issues_pdf_test.rb
Run options: --seed 32491

# Running:

F

Failure:
IssuesPdfHelperTest#test_fetch_row_values_should_round_float_values [test/unit/lib/redmine/export/pdf/issues_pdf_test.rb:32]:
--- expected
+++ actual
@@ -1 +1 @@
-["2", "Add ingredients categories", "4.34"]
+["2", "Add ingredients categories", "0.00"]

bin/rails test test/unit/lib/redmine/export/pdf/issues_pdf_test.rb:23

Finished in 0.658523s, 1.5185 runs/s, 1.5185 assertions/s.
1 runs, 1 assertions, 1 failures, 0 errors, 0 skips

A fix for issues_pdf_test was submitted as #28233. I committed the fix in r17212.