Feature #202

Textilization of Documents, News and Timelog-entry comments

Added by Warren Harris over 6 years ago. Updated over 1 year ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Text formatting
Target version:-
Resolution:

Description

I've noticed another missing textilization:

Under projects/list_documents page, documents are listed with
a preview of their descriptions. However, the descriptions are
not textilized. When the description is shown under the documents/show
page, it is correctly textilized.

news-summ.patch Magnifier (1.92 KB) Warren Harris, 2008-02-03 10:56

doc-descr.patch Magnifier (725 Bytes) Warren Harris, 2008-02-03 10:56

textilize-document-description_r3084.patch Magnifier - Patch against trunk at r3084. (663 Bytes) Mischa The Evil, 2009-11-22 22:34

textilize-news-summary_r3084.patch Magnifier - Patch against trunk at r3084. (1.2 KB) Mischa The Evil, 2009-11-22 22:34

textilize-timelog-entry-comment_r3084.patch Magnifier - Patch against trunk at r3084. (581 Bytes) Mischa The Evil, 2009-11-22 22:34

long_and_textilized_time_entry_comments.patch Magnifier (4.23 KB) Gustavo Gama, 2010-03-19 15:49


Related issues

Related to Defect #3740: Code syntax highlighting not working in Document page Closed 2009-08-14
Related to Defect #5104: Description of document not wikified on documents index Closed 2010-03-17
Related to Patch #258: Textilize document snippet on overview and activity page New
Related to Feature #8668: make project overview text input fully wiki input text en... Closed 2011-06-22 2013-03-24
Related to Feature #1179: Optionally allow Text and Long Text custom fields support... Closed 2008-05-05
Duplicated by Defect #3406: Documents view does not parse textile syntax, while detai... Closed 2009-05-22
Duplicated by Patch #221: Textilized timelog comments Closed 2007-06-26
Duplicated by Patch #4579: Missing Textilization on Document Index Closed 2010-01-14
Duplicated by Patch #3815: Format links in Timelog Closed 2009-09-03
Duplicated by Feature #3810: Link to SCM Revision from Time Tracking Summary Closed 2009-09-02
Duplicated by Feature #4627: Wiki style Formatting in a few places Closed 2010-01-22
Duplicated by Defect #6038: wiki formatting in spent time comments Closed 2010-08-05

Associated revisions

Revision 3602
Added by Jean-Philippe Lang over 4 years ago

Adds text formatting to documents index (#202).

History

#1 Updated by Warren Harris over 6 years ago

Here's another one... seems like there's no reason the news
summary shouldn't also be textilized. (patch included)

#2 Updated by Mischa The Evil over 4 years ago

  • Category set to Text formatting

Just a bump on the issue. Plus is seems slightly related to issue #3740.

#3 Updated by Mischa The Evil over 4 years ago

  • Subject changed from another missing textilization to Textilization of Documents and News

Changed subject only.

#4 Updated by Mischa The Evil over 4 years ago

  • Tracker changed from Defect to Feature

#5 Updated by Mischa The Evil over 4 years ago

Warren Harris wrote:

[...] When the description is shown under the documents/show
page, it is correctly textilized [...]

Except that syntax-highlighting isn't working in that specific case: see issue #3740.

#6 Updated by Mischa The Evil over 4 years ago

I'll make a summary of several different changes regarding proposals to render content as being "textilized":

1. I'll start with the initial request: At the documents page (at http://host.domain.tld/projects/projectfoo/documents) documents are listed with a preview of their descriptions. However, the descriptions are not textilized.
When the description is shown under the documents/show page (at http://host.domain.tld/documents/1), it is correctly textilized.

(patch; textilize-document-description_r3084.patch)

2. Lateron in the journal of this issue the textilisation of the news summary is also proposed and patched.

(patch; textilize-news-summary_r3084.patch)

3. I've now also merged issue #221 into this issue. It's basically a simple request to render the timelog-entry comments also textilized.

(patch; textilize-timelog-entry-comment_r3084.patch)

I've rebased all three patches against the latest trunk and attached them to this issue. I'll close/update issue #221 as being a (partial) duplicate of this issue (patch #221 does some more then what the issue's description says, which is only textilisation of the timelog-comment).

Can a Redmine Lead decide which of the patches will be implemented (in future) and decline the ones that aren't get integrated?

#7 Updated by Mischa The Evil over 4 years ago

Mischa The Evil wrote:

[...] several different changes regarding proposals to render content as being "textilized":

1. [...] (patch; textilize-document-description_r3084.patch) [...]

2. [...] (patch; textilize-news-summary_r3084.patch [...]

3. [...] (patch; textilize-timelog-entry-comment_r3084.patch [...]

[...]

Can a Redmine Lead decide which of the patches will be implemented (in future) and decline the ones that aren't get integrated?

My personal proposal would be to only merge the patch for number 3. That one seems to provide the most useable UI-enhancement with a small change without any unwanted side-effects.
Number 2 seems to has a slight side-effect on the project-overview block and the news index view where trailing new-lines are added. Number 1 seems a good start considering related issue #3740 but therefor also seems to have a higher severity when integrating it in the current state of Redmine (before 0.9 feature freeze).

NB: With all these patches there exists a chance that the users enter comments with markup which /could/ make the UI break. It should be handled with care. This might also be a good reason to decline all off the three patches...

#8 Updated by Jean-Philippe Lang over 4 years ago

Text formatting on documents index added in r3602.

#9 Updated by Gustavo Gama over 4 years ago

I'm attaching a improved (imho) version of Micha's third patch (the one that deals with time entry comments).

It 'textilizes' time entry comments and removes the length restriction. Also, the form text_fields to enter the time entries were replaced by text_areas's.

#10 Updated by Terence Mill about 3 years ago

related with #8668 - missing WIki full textile for project overview

#11 Updated by Ivan Cenov over 1 year ago

Terence Mill wrote:

related with #8668 - missing WIki full textile for project overview

Not missing on present day.

News are textilized
time entry comment are not textilized

#12 Updated by Mischa The Evil over 1 year ago

Ivan Cenov wrote:

Terence Mill wrote:

related with #8668 - missing WIki full textile for project overview

Not missing on present day.

I've updated #8668 accordingly. Thanks for mentioning it.

Ivan Cenov wrote:

News are textilized

News items are indeed textilized, but not the news summary.

#13 Updated by Dipan Mehta over 1 year ago

+1. This is very useful.

When is this likely to be fully accomplished?

Also available in: Atom PDF