Patch #26091
closed
Allow to filter by any visible version on the global issues view
Added by Holger Just almost 7 years ago. Updated almost 6 years ago.
Description
Currently, the global issues view only allows to filter by system-shared versions but not e.g. for versions shared to some projects or not stared at all.
Since the global issue view is often used as a quick filter to check what is happening in all projects, filtering by any visible version would allow to drill down from there instead of having to first select the correct parent project and then starting the filter there. Also, with saved shared queries, a common starting point is the global issue view instead of individual projects.
The attached patch removes the restriction to only allow filtering by system-shared versions. Instead, it allows filtering by any version visible to the current user.
Files
| 0001-Allow-to-filter-by-all-versions-on-the-global-issue-.patch (829 Bytes) 0001-Allow-to-filter-by-all-versions-on-the-global-issue-.patch | Holger Just, 2017-06-02 17:52 | ||
| test_for_26091.patch (1.52 KB) test_for_26091.patch | Marius BĂLTEANU, 2018-06-29 09:10 |
Related issues
Updated by Mischa The Evil almost 7 years ago
- Target version set to Unplanned backlogs
I find this a nice addition indeed. Setting target to unplanned.
Updated by Holger Just almost 7 years ago
Updated by Go MAEDA almost 7 years ago
The proposed behavior is also consistent with #24769 (user type custom field).
Updated by Go MAEDA almost 7 years ago
Mischa The Evil wrote:
I find this a nice addition indeed. Setting target to unplanned.
I think we can merge this patch right now. Mischa, what do you think about setting target version to 3.4.0? Is it OK with you?
Updated by Marius BĂLTEANU almost 7 years ago
Go MAEDA wrote:
Mischa The Evil wrote:
I find this a nice addition indeed. Setting target to unplanned.
I think we can merge this patch right now. Mischa, what do you think about setting target version to 3.4.0? Is it OK with you?
My two cents:
I'm in favor to set the version:3.5.0 in order to have the 3.4.0 released as soon as possible.
Updated by Robert Schneider almost 7 years ago
My two cents:
I'm in favor to set the version:3.5.0 in order to have the 3.4.0 released as soon as possible.
Oh, yes please! Good idea. 3.4.0 matured enough. I have started a discussion about that Why don't you just release 3.4.0? since we are waiting so long now.
My two cents. Total now: 4 cents ;-)
Updated by Holger Just almost 7 years ago
Not to spoil anything here, but this patch here won't result in any delay in getting 3.4.0 released. It is a tiny patch which helps resolve (together with #24769, #25501 and #26023) some inconsistencies in the way the global filters work. It takes about 5 minutes of work to merge (and backport) this and several of the other already assigned patches.
In general, there's no gain from having tiny patches wait for the next release. Instead, the release is (probably) only delayed by the larger open issues which still take some thinking, or review plus whatever JPL already has in his sleeves.
Updated by Robert Schneider almost 7 years ago
Holger, I'm happy about any new Redmine feature! If it's really such a small task applying that patch, then they should do it. I'm just a bit afraid that there is actually more to do. Already the communication here has to be done, thinking about it, creating a test, ... There should be a point where new things get added to the next version, otherwise 3.4.0 might be released next year ;-) Now I shut up.
Updated by Toshi MARUYAMA almost 7 years ago
- Related to Defect #26023: Category filter only shows categories of current project added
Updated by Go MAEDA almost 7 years ago
- Target version changed from Unplanned backlogs to 4.1.0
As mentioned in #26091#note-2 and #26091#note-3, the behaviour of this patch is consistent with #25501 and #24769. They were already delivered in 3.4.0.
I am setting target version to 4.1.0.
Updated by Go MAEDA almost 6 years ago
- Status changed from New to Closed
- Target version changed from 4.1.0 to 4.0.0
Committed. Thank you for improving Redmine.
Updated by Marius BĂLTEANU almost 6 years ago
- Status changed from Closed to Reopened
- Assignee set to Marius BĂLTEANU
I'm reopening and assigning this to me because I would like to add a test for this feature.
Updated by Marius BĂLTEANU almost 6 years ago
- File test_for_26091 added
- Assignee changed from Marius BĂLTEANU to Go MAEDA
Here is the updated test.
Updated by Marius BĂLTEANU almost 6 years ago
- File deleted (
test_for_26091.patch)
Updated by Marius BĂLTEANU almost 6 years ago
- File deleted (
test_for_26091.patch)
Updated by Marius BĂLTEANU almost 6 years ago
- File test_for_26091.patch test_for_26091.patch added
Better test name.
Updated by Go MAEDA almost 6 years ago
- Assignee changed from Go MAEDA to Marius BĂLTEANU
Marius BALTEANU wrote:
Better test name.
Sorry, I have committed the previous patch. Do you think I should change the test name?
Updated by Marius BĂLTEANU almost 6 years ago
Go MAEDA wrote:
Marius BALTEANU wrote:
Better test name.
Sorry, I have committed the previous patch. Do you think I should change the test name?
I think the new name of the test reflects better what is tested inside it. Also, we should remove the blank line from the end of the test (line 628).
Me sorry because I didn't pay enough attention when I've updated the patch.
Updated by Marius BĂLTEANU almost 6 years ago
- Assignee changed from Marius BĂLTEANU to Go MAEDA
Updated by Go MAEDA almost 6 years ago
- Status changed from Reopened to Closed
Committed. Thank you all for the contribution.
Updated by Marius BĂLTEANU almost 6 years ago
- Related to Defect #3869: Filter using Target Version loses 'Target Version' part of the filter when applied across all tickets. added