Feature #26575

Add update info at the bottom of the wiki page

Added by Go MAEDA about 1 year ago. Updated 26 days ago.

Status:ReopenedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Wiki
Target version:4.0.0
Resolution:Fixed

Description

wiki-update-info@2x.png (32.3 KB) Go MAEDA, 2017-07-30 02:41

26575_add_links_to_user_and_to_date.patch Magnifier (521 Bytes) Marius BALTEANU, 2017-08-06 15:31

after.png (57.3 KB) Marius BALTEANU, 2017-08-06 15:32

before.png (56.4 KB) Marius BALTEANU, 2017-08-06 15:32

redmine_wiki_version.png (22.2 KB) Alexander Ryabinovskiy, 2018-09-18 16:12

redmine-3_4@2x.png (68.8 KB) Go MAEDA, 2018-09-24 07:42

redmine-4_0-without-icon@2x.png (57.4 KB) Go MAEDA, 2018-09-24 07:42

redmine-4_0-with-icon@2x.png (82.1 KB) Go MAEDA, 2018-09-24 07:42

Associated revisions

Revision 16905
Added by Jean-Philippe Lang about 1 year ago

Add update info at the bottom of the wiki page.

Revision 16906
Added by Jean-Philippe Lang about 1 year ago

Adds label_x_revisions string to locales.

Revision 17388
Added by Jean-Philippe Lang 4 months ago

Add links to the user name and date on wiki update info (#26575).

Patch by Marius BALTEANU.

Revision 17509
Added by Jean-Philippe Lang 27 days ago

User label_revision instead of label_version for wiki edits (#26575).

Revision 17510
Added by Jean-Philippe Lang 27 days ago

Remove link to current version, already present in the page breadcrumb (#26575).

Revision 17513
Added by Jean-Philippe Lang 27 days ago

Use label_revision instead of label_version for wiki edits (#26575).

History

#1 Updated by Go MAEDA about 1 year ago

  • Category set to Wiki
  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version set to 4.0.0

Implemented in r16905.

#2 Updated by Marius BALTEANU about 1 year ago

I propose to add some links to the user name and date (for consistency with other screens).

Before:

After:

#3 Updated by Go MAEDA about 1 year ago

Marius BALTEANU wrote:

I propose to add some links to the user name and date (for consistency with other screens).

+1
time_tag is really needed to know detailed updated time.

#4 Updated by Toshi MARUYAMA about 1 year ago

  • Status changed from Resolved to New

#5 Updated by Yasukazu Nagatomi 4 months ago

+1

#6 Updated by Bernhard Rohloff 4 months ago

+1

#7 Updated by Jean-Philippe Lang 4 months ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Patch committed, thanks.

#8 Updated by Alexander Ryabinovskiy about 1 month ago

Hello.
I am trying to translate "label_x_revisions" in .yml and I have a question.
Why did you called this label "revisions" (like in "Repository" module) but not "versions" (like in wiki history) ?

#9 Updated by Go MAEDA about 1 month ago

  • Status changed from Closed to Reopened

#10 Updated by Jean-Philippe Lang 27 days ago

  • Status changed from Reopened to Closed

Wiki history now uses "Revisions" only.

#11 Updated by Go MAEDA 27 days ago

I think that showing the familiar "history" icon is better. If there is the icon, users can find the important link easily and can understand that the "X revisions" is the link that they used to call "History" link.

Without the icon, users may not be able to find this feature and misunderstand that "History" has been removed.

Index: app/views/wiki/show.html.erb
===================================================================
--- app/views/wiki/show.html.erb        (revision 17516)
+++ app/views/wiki/show.html.erb        (working copy)
@@ -74,7 +74,7 @@
 <% if User.current.allowed_to?(:view_wiki_edits, @project) %>
 <p class="wiki-update-info">
   <%= wiki_content_update_info(@content) %>
- · <%= link_to l(:label_x_revisions, :count => @content.version), {:action => 'history', :id => @page.title} %>
+ · <%= link_to l(:label_x_revisions, :count => @content.version), {:action => 'history', :id => @page.title}, {:class => 'icon icon-history'} %>
 </p>
 <% end %>

Redmine 3.4:
We had an icon beside the History link.

The current trunk (Redmine 3.4.6.devel.17516):
"History" was changed to "X revisions" and the icon was removed.

The current trunk with the proposing patch:
Adding the icon is intuitive and consistent with older versions.

#12 Updated by Erik E 26 days ago

Would it be confusing/a problem to keep the "History" button above? I think the information below is a great addition, but the button on the top would allow easy access to the history (without the need to scroll down)- and all other "control" elements are there, too.

As an imho: In that case I'd drop the icon below, I think it looks more elegant. But I am not an UI/UX expert ;-)

Also available in: Atom PDF