Project

General

Profile

Activity

From 2019-10-20 to 2019-10-22

2019-10-22

22:43 Feature #32311: Filter Issues by multiple issue_id doesn't support space character or semicolon/dash as the separator
It is the expected behaviour and I'm not sure that we should support more delimiters. Marius BĂLTEANU
22:38 Defect #32322 (Needs feedback): changes made to filter/column/groupby is not saved to session cookie
On which tab do you refer? The filter options are saved in the session only for issues, for time entries not (you can... Marius BĂLTEANU
09:31 Defect #32322 (Needs feedback): changes made to filter/column/groupby is not saved to session cookie
changes made to filter/column/groupby is not saved to session cookie, after the browser is closed and restarted, the ... Taine Woo
22:34 Defect #32314: Notification for "Only for things I watch or I'm involed in" not works
pasquale [:dedalus] wrote:
> Marius BALTEANU wrote:
> > Do you use any plugin?
>
> yes, but I have also tried wi...
Marius BĂLTEANU
09:27 Defect #32314: Notification for "Only for things I watch or I'm involed in" not works
Marius BALTEANU wrote:
> Please see [[Submissions]].
Redmine version 4.0.5.stable
Ruby versio...
pasquale [:dedalus]
09:23 Defect #32314: Notification for "Only for things I watch or I'm involed in" not works
Marius BALTEANU wrote:
> Do you use any plugin?
yes, but I have also tried with a fresh installation without plug...
pasquale [:dedalus]
09:20 Defect #32314: Notification for "Only for things I watch or I'm involed in" not works
Do you use any plugin? Please see [[Submissions]]. Marius BĂLTEANU
09:06 Defect #32314: Notification for "Only for things I watch or I'm involed in" not works
I have verified that not works also settings:
* Only for things I watch or I am assigned to;
* Only for things I wa...
pasquale [:dedalus]
22:30 Defect #32318 (Closed): Redmine 4.0 can not be installed in a sub-URI any more
Robert Auer wrote:
> Actually, there is a way:
>
> * Set environment variable RAILS_RELATIVE_URL_ROOT=/redmine
>...
Marius BĂLTEANU
11:57 Defect #32318 (Resolved): Redmine 4.0 can not be installed in a sub-URI any more
Actually, there is a way:
* Set environment variable RAILS_RELATIVE_URL_ROOT=/redmine
* Adapt config/environment....
Robert Auer
08:00 Defect #32318 (Closed): Redmine 4.0 can not be installed in a sub-URI any more
Hi!
I tried to upgrade my Redmine-installation from 3.4 to 4.0. Until now it was configured to run in the sub-URI ...
Robert Auer
18:06 Revision 18839 (svn): code cleanup: rubocop: fix Layout/SpaceBeforeComma in lib/redmine/export/pdf.rb
Toshi MARUYAMA
18:06 Revision 18838 (svn): code cleanup: rubocop: fix Layout/SpaceBeforeComma in test/helpers/application_helper_test.rb
Toshi MARUYAMA
17:55 Revision 18837 (svn): code cleanup: rubocop: fix Style/ParenthesesAroundCondition in lib/redmine/helpers/gantt.rb
Toshi MARUYAMA
17:54 Revision 18836 (svn): code cleanup: rubocop: fix Style/ParenthesesAroundCondition in lib/diff.rb
Toshi MARUYAMA
17:54 Revision 18835 (svn): code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/wiki_page.rb
Toshi MARUYAMA
17:54 Revision 18834 (svn): code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/time_entry.rb
Toshi MARUYAMA
17:54 Revision 18833 (svn): code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/query.rb
Toshi MARUYAMA
17:54 Revision 18832 (svn): code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/project.rb
Toshi MARUYAMA
17:54 Revision 18831 (svn): code cleanup: rubocop: fix Layout/AccessModifierIndentation in app/controllers/wiki_controller.rb
Toshi MARUYAMA
17:53 Revision 18830 (svn): code layout clean up app/models/role.rb
Toshi MARUYAMA
17:53 Revision 18829 (svn): code cleanup: rubocop: fix Layout/AccessModifierIndentation in app/models/role.rb
Toshi MARUYAMA
17:35 Revision 18828 (svn): code cleanup: rubocop: fix Lint/NestedMethodDefinition in test/unit/lib/redmine/menu_manager/menu_helper_test.rb
Toshi MARUYAMA
17:35 Revision 18827 (svn): fix random test failure of ProjectQueryTest (#29482)
Toshi MARUYAMA
16:12 Defect #32307 (Closed): AttachmentsControllerTest#test_thumbnail_for_pdf_should_be_png fails if ImageMagick convert is not available
Committed the patch as a part of #22481. Go MAEDA
16:12 Revision 18826 (svn): Skip AttachmentsControllerTest#test_thumbnail_for_pdf_should_be_png when ImageMagick convert is not available (#32307, #22481).
Patch by Go MAEDA. Go MAEDA
15:50 Defect #32172 (Closed): Warning "constant Loofah::HTML5::WhiteList is deprecated"
rails-html-sanitizer 1.3.0 has been released on October 6th and this issue was fixed. Go MAEDA
15:44 Revision 18825 (svn): code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in app/controllers/timelog_controller.rb
Toshi MARUYAMA
15:44 Revision 18824 (svn): code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in app/controllers/messages_controller.rb
Toshi MARUYAMA
15:43 Revision 18823 (svn): code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in app/controllers/boards_controller.rb
Toshi MARUYAMA
15:43 Revision 18822 (svn): code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/helpers/application_helper.rb
Toshi MARUYAMA
14:42 Patch #32308 (Closed): Rubocop: Performance/RedundantBlockCall: Use yield instead of block.call.
Fixed, thanks. Toshi MARUYAMA
14:32 Patch #32308: Rubocop: Performance/RedundantBlockCall: Use yield instead of block.call.
... Toshi MARUYAMA
14:41 Revision 18821 (svn): code cleanup: rubocop: fix Performance/RedundantBlockCall in app/controllers/application_controller.rb
Toshi MARUYAMA
14:41 Revision 18820 (svn): code cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/scm/adapters/abstract_adapter.rb
Toshi MARUYAMA
14:40 Revision 18819 (svn): code cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/views/builders.rb
Toshi MARUYAMA
14:40 Revision 18818 (svn): rubocop: add new detected files to Performance/RedundantBlockCall (#32308)
Toshi MARUYAMA
14:40 Revision 18817 (svn): use "class << self" syntax for Redmine::Views::Builders#for (#32308)
Toshi MARUYAMA
14:40 Revision 18816 (svn): use "if block_given?" instead of "if block" in lib/redmine/views/builders.rb (#32308)
Toshi MARUYAMA
14:40 Revision 18815 (svn): use "if block_given?" instead of "if block" in lib/redmine/views/builders/structure.rb (#32308)
Toshi MARUYAMA
14:16 Revision 18814 (svn): code cleanup: rubocop: fix Performance/RedundantBlockCall in test/functional/repositories_git_controller_test.rb
Toshi MARUYAMA
14:10 Revision 18813 (svn): code cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/views/builders/structure.rb
Toshi MARUYAMA
14:10 Revision 18812 (svn): code cleanup: rubocop: fix Performance/RedundantBlockCall in test/unit/lib/redmine/views/builders/json_test.rb
Toshi MARUYAMA
14:09 Revision 18811 (svn): code cleanup: rubocop: fix Performance/RedundantBlockCall in test/unit/lib/redmine/views/builders/xml_test.rb
Toshi MARUYAMA
13:41 Revision 18810 (svn): code cleanup: rubocop: fix Layout/CommentIndentation and Layout/MultilineArrayBraceLayout in test/unit/lib/redmine/wiki_formatting/markdown_formatter_test.rb
Toshi MARUYAMA
13:41 Revision 18809 (svn): rubocop: remove test/helpers/application_helper_test.rb from Layout/CaseIndentation and Layout/IndentHeredoc fixed by previous revisions
Toshi MARUYAMA
13:40 Revision 18808 (svn): code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_syntax_highlight
Toshi MARUYAMA
13:40 Revision 18807 (svn): code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_non_closing_pre_blocks_should_be_closed
Toshi MARUYAMA
13:40 Revision 18806 (svn): code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_pre_content_should_not_parse_wiki_and_redmine_links
Toshi MARUYAMA
13:40 Revision 18805 (svn): code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_pre_tags
Toshi MARUYAMA
13:40 Revision 18804 (svn): code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_syntax_highlight_ampersand_in_textile
Toshi MARUYAMA
13:40 Revision 18803 (svn): code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_inline_images_inside_tags
Toshi MARUYAMA
13:39 Revision 18802 (svn): code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_table_of_content
Toshi MARUYAMA
13:39 Revision 18801 (svn): code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_table_of_content_should_generate_unique_anchors
Toshi MARUYAMA
13:39 Revision 18800 (svn): code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_table_of_content_should_contain_included_page_headings
Toshi MARUYAMA
13:39 Revision 18799 (svn): code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_section_edit_links
Toshi MARUYAMA
13:31 Revision 18798 (svn): code cleanup: rubocop: fix Style/MultipleComparison in lib/redmine/scm/adapters/git_adapter.rb
Toshi MARUYAMA
13:31 Revision 18797 (svn): code cleanup: rubocop: fix Style/UnneededSort in test/unit/repository_git_test.rb
Toshi MARUYAMA
13:30 Revision 18796 (svn): code cleanup: rubocop: fix Style/UnneededInterpolation in lib/redmine/scm/adapters/git_adapter.rb
Toshi MARUYAMA
13:30 Revision 18795 (svn): code cleanup: rubocop: fix Layout/MultilineArrayBraceLayout in app/models/setting.rb
Toshi MARUYAMA
13:30 Revision 18794 (svn): code cleanup: rubocop: fix Layout/AccessModifierIndentation in app/models/setting.rb
Toshi MARUYAMA
13:30 Revision 18793 (svn): code cleanup: rubocop: fix Layout/AlignArray in lib/redmine/default_data/loader.rb
Toshi MARUYAMA
13:30 Revision 18792 (svn): code cleanup: rubocop: fix Layout/AlignArray in app/models/setting.rb
Toshi MARUYAMA
12:01 Defect #31085: Hosting redmine at a suburl doesn't work anymore in 4.0
Found a solution for my problem, see https://www.redmine.org/issues/32318#note-1 Robert Auer
09:36 Feature #32321 (Closed): Issue filter: new filter: Author's Group
Thank you for suggesting a new feature but I found the same feature request. Closing this issue as a duplicate of #7867. Go MAEDA
09:11 Feature #32321 (Closed): Issue filter: new filter: Author's Group
There is a filter as "Asignee's Group", and it would be better to have filter "Author's Group". Taine Woo
09:33 Defect #14753: Remember issue filter for each project
+1
i think it's better to save the changes to filters/columns/groupby to session cookie or something related.
Taine Woo
09:08 Patch #32320 (Closed): Simplified Chinese translation for label_tomorrow, label_next_week, label_next_month, and permission_edit_own_issues
Translated four strings.... Go MAEDA
07:37 Feature #32317 (New): Issue filter: locale: label_issue: confusing the Issue and IssueID
From the Issue Filter, the "Issue" actually should be "IssueID", but displayed as "Issue".
Anyway it will confuse us...
Taine Woo
07:06 Feature #29482 (Closed): Query system for Projects page
Marius BALTEANU wrote:
> Attached two new patches:
> 1. Fixes the problem, including broken JS which doesn't hide u...
Go MAEDA
05:15 Feature #29482: Query system for Projects page
Go MAEDA wrote:
> Bernhard Rohloff wrote:
> > There is a small flaw in the query save form. The labels on the @Disp...
Bernhard Rohloff
01:14 Feature #29482: Query system for Projects page
Bernhard Rohloff wrote:
> There is a small flaw in the query save form. The labels on the @Display results@ section ...
Go MAEDA
07:04 Revision 18791 (svn): Removes duplicated 'group_by' id (#29482).
Patch by Marius BALTEANU. Go MAEDA
07:03 Revision 18790 (svn): Fix display type in query form view (#29482).
Patch by Marius BALTEANU. Go MAEDA
06:27 Patch #32316 (Closed): Traditional Chinese translation (to r18788)
Committed the patch. Thank you.
By the way, do you think your translations can be used also in zh.yml after conver...
Go MAEDA
04:14 Patch #32316 (Closed): Traditional Chinese translation (to r18788)
* New tags added
** setting_project_list_defaults, label_display_type, label_display_type_list, label_display_type_b...
ChunChang (Nagaharu) Lo
06:11 Revision 18789 (svn): Traditional Chinese translation update (#32316).
Patch by ChunChang Lo. Go MAEDA
05:25 Patch #32196: Allow import time entries for other users
+1
I think option 2 is the better one, too.
Bernhard Rohloff
04:02 Defect #32309 (Closed): settings error in 4.0.5.devel.18786
Thank you for the feedback. Closing. Go MAEDA
03:54 Defect #32309: settings error in 4.0.5.devel.18786
Hi,
Never mind. Just grabbed revision 18788 and the /setting works again (don't know why. i didn't do anything.)
ChunChang (Nagaharu) Lo
03:34 Defect #32309: settings error in 4.0.5.devel.18786
Hello,
this error occurs in the /settings page and the redmine instance doesn't install any 3rd-party plugins.
ChunChang (Nagaharu) Lo
04:01 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
Mischa The Evil wrote:
> IMHO this should be fixed at the root in either sprockets itself or Redmine somehow.
Pro...
Go MAEDA
03:34 Patch #32297 (Closed): Remove code for unsupported versions of Rails from open_id_authentication
Committed. Go MAEDA
03:34 Revision 18788 (svn): Remove code for unsupported versions of Rails from open_id_authentication (#32297).
Patch by Go MAEDA. Go MAEDA

2019-10-21

23:07 Feature #31505: Mark edited journal notes as "Edited"
Updated to apply cleanly on the current trunk. Marius BĂLTEANU
23:05 Feature #29482: Query system for Projects page
Bernhard Rohloff wrote:
> There is a small flaw in the query save form. The labels on the @Display results@ section ...
Marius BĂLTEANU
18:31 Feature #29482 (Reopened): Query system for Projects page
There is a small flaw in the query save form. The labels on the @Display results@ section are overlapping each other.... Bernhard Rohloff
09:33 Feature #29482: Query system for Projects page
Go MAEDA wrote:
> Marius BALTEANU wrote:
> > Please commit the below change in order to prevent a random test failu...
Marius BĂLTEANU
09:21 Feature #29482 (Closed): Query system for Projects page
Marius BALTEANU wrote:
> Please commit the below change in order to prevent a random test failure:
Committed in r...
Go MAEDA
09:11 Feature #29482 (Reopened): Query system for Projects page
Please commit the below change in order to prevent a random test failure:... Marius BĂLTEANU
22:12 Defect #32315: Impossible to validate API key without modifying anything
Try, for example: ... Nathan Cutler
22:09 Defect #32315 (Closed): Impossible to validate API key without modifying anything
AFAICT the Redmine API has no way of validating whether a given API key is valid, short of actually attempting a writ... Nathan Cutler
22:10 Feature #5977: "check status" feature to verify validity of Redmine installation and API access key
Related ticket: #32315 Nathan Cutler
22:07 Feature #5977: "check status" feature to verify validity of Redmine installation and API access key
AFAICT the Redmine API has no way of validating whether a given API key is valid, short of actually attempting a writ... Nathan Cutler
20:26 Feature #27988: Option to configure which trackers can be set as subtasks for each tracker
Hi Marius,
Thank you for the great patch! But I encounter a bug. I have the following setup: Tracker "Parent" has ...
Dong Phan
19:15 Defect #32314 (Closed): Notification for "Only for things I watch or I'm involed in" not works
I have updated my redmine installation from 3.4.2 release to last 4.0.5. After this update, I no longer receive e-mai... pasquale [:dedalus]
17:26 Feature #24766: Custom fields grouping
+1
Vassilis Chryssos
15:47 Feature #32311: Filter Issues by multiple issue_id doesn't support space character or semicolon/dash as the separator
/\A[+-]?\d+(\D[+-]?\d+)*\z/
digit separated by one non-digit
/\A[+-]?\d+(\D*\d+)*\z/
digit separated by any no...
Taine Woo
15:25 Feature #32311: Filter Issues by multiple issue_id doesn't support space character or semicolon/dash as the separator
app/models/query.rb
line 417, replace the "," as "\D" can use any non-numeric characters as separator.
Taine Woo
09:35 Feature #32311: Filter Issues by multiple issue_id doesn't support space character or semicolon/dash as the separator
If the value of the issue_id is "1,2,3" in the filter, the query executes successfully.
If the value of the issue_id...
Taine Woo
09:20 Feature #32311 (New): Filter Issues by multiple issue_id doesn't support space character or semicolon/dash as the separator
Issues -> Filter -> Issue
statement "is", input the filter value as multiple ids, such as "1,2,3".
It only suppor...
Taine Woo
13:57 Defect #25130: support of agglutinative languages like Hungarian/Magyar
Will you ever accept my patches, please?
Greg T wrote:
> When _x_hours_ and _x_days_ are *not* used for a referen...
Greg T
13:32 Patch #32308: Rubocop: Performance/RedundantBlockCall: Use yield instead of block.call.
there are a few other cases Pavel Rosický
08:40 Patch #32308: Rubocop: Performance/RedundantBlockCall: Use yield instead of block.call.
All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/90121225 Marius BĂLTEANU
01:32 Patch #32308: Rubocop: Performance/RedundantBlockCall: Use yield instead of block.call.
Caused by r18777. Go MAEDA
09:53 Feature #32312 (New): Disable auto selecting in top right Project filter
Add configuration point to be able to disable autoswitching project while viewing issue Yury Vashinko
09:20 Revision 18787 (svn): Fix random test failure of ProjectQueryTest (#29482).
Patch by Marius BALTEANU. Go MAEDA
08:24 Defect #32309 (Needs feedback): settings error in 4.0.5.devel.18786
@libs/js/iframe.js@ is not part of Redmine core. Marius BĂLTEANU
06:19 Defect #32309: settings error in 4.0.5.devel.18786
I was not able to reproduce the problem with Redmine 4.0.5.devel.18786.
Could you describe details of how to repro...
Go MAEDA
05:52 Defect #32309 (Closed): settings error in 4.0.5.devel.18786
Hello,
Just get the lastest version from subversion and the settings page is broken....
ChunChang (Nagaharu) Lo
03:19 Feature #32302: Filter projects after bookmarks
The patch works fine and passed all tests.
Marius BALTEANU wrote:
> Here is the patch, I think we can commit it a...
Go MAEDA
02:58 Patch #32297: Remove code for unsupported versions of Rails from open_id_authentication
Setting the target version to 4.1.0. Go MAEDA

2019-10-20

17:25 Patch #32308 (Closed): Rubocop: Performance/RedundantBlockCall: Use yield instead of block.call.
... Marius BĂLTEANU
17:04 Feature #32302: Filter projects after bookmarks
Here is the patch, I think we can commit it as part of #29482 and #31355. Marius BĂLTEANU
01:13 Feature #32302: Filter projects after bookmarks
Since we already have "<< my projects >>" in Project filter, the filter seems the right place to add "<< my bookmarks... Go MAEDA
15:14 Defect #32307 (Closed): AttachmentsControllerTest#test_thumbnail_for_pdf_should_be_png fails if ImageMagick convert is not available
To reproduce it, set invalid value to imagemagick_convert_command in configuration.yml and run attachments_controller... Go MAEDA
14:26 Feature #32306 (Closed): Add a link to projects administration page on projects page
This patch adds a link to the projects administration page (/admin/projects) on the projects page in order to improve... Go MAEDA
14:23 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
Mischa The Evil wrote:
> Pavel Rosický wrote:
> > [...]
>
> How do you generate these numbers? On what system? C...
Pavel Rosický
11:16 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
Mischa The Evil wrote:
> Go MAEDA wrote:
> > Mischa The Evil wrote:
> > > # Are you sure everything needed by the ...
Go MAEDA
09:56 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
Pavel Rosický wrote:
> [...]
How do you generate these numbers? On what system? Can you remove @active_storage@ a...
Mischa The Evil
09:21 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
Go MAEDA your patch improves startup time and memory consumtion.... Pavel Rosický
07:09 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
Go MAEDA wrote:
> Mischa The Evil wrote:
> > # Are you sure everything needed by the core is indeed loaded with thi...
Mischa The Evil
11:10 Feature #973: Assign different status sets and workflows for separate projects
+1 Luis Blasco
10:52 Patch #32303 (Closed): Japanese translation update (r18784)
Committed the patch. Go MAEDA
02:25 Patch #32303 (Closed): Japanese translation update (r18784)
Translated strings added by #29482.... Go MAEDA
10:52 Revision 18786 (svn): Japanese translation update (#32303).
Patch by Go MAEDA. Go MAEDA
07:29 Defect #32305 (New): Use of notextile tag disables Redmine revision links
As observed [yet] only on redmine.org (see #29482#note-90 and #29482#note-91), comments (in this case issue notes) ha... Mischa The Evil
06:52 Defect #32293: Redmine does not start if optional openid gems are not installed
I don't think that this low priority issue alone justifies dropping OpenID support in Redmine altogether. I think tha... Mischa The Evil
06:35 Feature #29482 (Closed): Query system for Projects page
Mischa The Evil wrote:
> <notextile>@</notextile>Go MAEDA: Can you also remove the remaining @label_show_closed_proj...
Go MAEDA
06:21 Feature #29482 (Reopened): Query system for Projects page
<notextile>@</notextile>Go MAEDA: Can you also remove the remaining @label_show_closed_projects@ strings from the oth... Mischa The Evil
06:32 Revision 18785 (svn): Remove label_show_closed_projects from all translation files (#29482).
The string has been removed from en.yml in r18761. Go MAEDA
01:32 Revision 18784 (svn): Update locales (#29482).
Go MAEDA
 

Also available in: Atom