Activity
From 2017-05-26 to 2017-05-28
2017-05-28
-
15:58 Defect #26055: Three issues with Redmine::SyntaxHighlighting::CodeRay.language_supported?
- Added the patches.
-
15:40 Defect #26055 (Closed): Three issues with Redmine::SyntaxHighlighting::CodeRay.language_supported?
- h2. Issues
While reviewing/researching #25634 (and in its extend, r16501 & r16502 for #25503), I noticed three issues with the implementation - both pre and post r16568:
# @Redmine::SyntaxHighlighting::CodeRay.language_supported?@ in... -
15:44 Defect #25634 (Reopened): Highlight language aliases are no more supported
- Reopened in light of #26055.
-
08:12 Defect #23912 (Resolved): No validation error when date value is invalid in time entries filter
- It seems to be fixed in r15649. "Date is invalid" error is displayed as expected.
-
04:46 Defect #26051: Please correct the vulnerability of imagemagick(CVE-2017-9098)
- Sahya, thank you for reporting this issue so quickly.
I think that Redmine 3.3.2 / 3.2.5 (released on 2017-01-07) and later are not affected with the vulnerability because they don't process Utah RLE images. By the change introduced i...
2017-05-27
-
18:29 Patch #24268 (Closed): Wrong German translation of logging time error message
- Committed in trunk r16580, thanks.
-
16:48 Defect #23912: No validation error when date value is invalid in time entries filter
- Considering that the issue reproduces on Redmine version:3.3.3, but not in the current trunk, I think that we can mark this defect as fixed in version:3.4.0.
-
16:42 Defect #23912: No validation error when date value is invalid in time entries filter
- I cannot reproduce on the current trunk (r16578). If I use the following query:
-
16:31 Defect #9090: Issue view does not show spent time if hours are zero
- Currently, you can add a spent time with 0 hours which is shown in time_entries#index, but not in the issue page (the defect reported in this ticket).
Because I don't see any real reason to allows spent time with 0 hours, I made a ... -
12:21 Feature #7769 (Closed): Sortable columns in issue lists on "My page"
- Thanks.
-
12:20 Defect #25687 (Closed): Bad translation in french for indentation
- Fix committed.
-
12:14 Defect #21375: Working external URL prefixes (protocols and 'www' host part) not documented in wiki syntax
- Mischa The Evil wrote:
> Shouldn't we document the following ones explicitly too?
Sure, could you prepare a patch for that? -
11:20 Defect #5385 (Closed): Status filter should show statuses related to project trackers only
- Patch applied, thanks. I've also updated the time entry query in order to show the same trackers and statuses.
-
10:53 Defect #25794: Mass-deleted attachments are not represented correctly in email notifications
- This defect is related to a feature added in 3.4.0, it should not appear in the changelog.
-
10:49 Defect #25794: Mass-deleted attachments are not represented correctly in email notifications
- Setting target version to put this issue in changelog.
-
10:46 Defect #25794 (Closed): Mass-deleted attachments are not represented correctly in email notifications
- Fixed in r16573 by sending the notification after commit.
-
10:51 Defect #25760 (Resolved): Clicking custom field label should not check the first option
- This is fixed in r16574 for boolean and list custom fields that are rendered as check boxes.
Thanks for pointing this out. -
10:41 Patch #25861 (Resolved): CSV Importer - handle UndefinedConversionErrors
-
09:58 Patch #25861: CSV Importer - handle UndefinedConversionErrors
- Jean-Philippe Lang wrote:
> Maybe we could simply rescue @EncodingError@ which is the base class for encoding errors?
I agree, caching EncodingError is better. We can simplify the code and catch all errors caused by iconv.
-
09:51 Patch #25861 (Needs feedback): CSV Importer - handle UndefinedConversionErrors
- Go MAEDA wrote:
> We can reproduce the problem with the test in attachment:0001-adds-failing-test-case-for-import-with-wrong-encodin.patch. Setting target version to 3.2.7.
The test passes for me with ruby 2.0 (I would get a Encoding... -
10:36 Defect #25634 (Closed): Highlight language aliases are no more supported
-
09:53 Defect #25634 (Resolved): Highlight language aliases are no more supported
- Patch committed, thanks.
-
10:34 Defect #25791 (Resolved): Bypass Tracker role-based permissions when copying issues
- Fixed in r16569.
-
09:56 Defect #26051: Please correct the vulnerability of imagemagick(CVE-2017-9098)
- How do you think we should do?
-
08:45 Defect #26051 (Closed): Please correct the vulnerability of imagemagick(CVE-2017-9098)
- Please correct the vulnerability of imagemagick(CVE-2017-9098)
https://access.redhat.com/security/cve/cve-2017-9098 -
09:36 Patch #25745 (Closed): Optimize Gantt Charts for mobile screens
-
09:34 Patch #25653 (Closed): Fix NoMethodError on HEAD requests to AccountController#register
-
09:33 Defect #25829 (Closed): mysql2 0.3 gem doesn't properly close connections
-
06:05 Defect #21021 (Closed): Copying a Redmine issue does not allow change of Status
- Fixed by #23610 for upcoming Redmine 3.4.0.
Issue status is reset to default when an issue is copied and you can choose from all allowed statuses for a new issue. -
05:49 Defect #10348 (Closed): Wrong issue statuses assignment during issue copy
- Toshi MARUYAMA wrote:
> Can we close this issue by fixed #23610?
You are right. Fixed by #23610.
This problem never happen in upcoming Redmine 3.4.0 because issue status is reset to default when an issue is copied. -
05:37 Feature #23301 (New): Allow "Custom queries" to be shared across projects
2017-05-26
-
13:34 Defect #25634: Highlight language aliases are no more supported
- Thanks for the patch. I had indeed missed the alias names for Coderay.
Looks good to me! -
12:57 Feature #26035: More visually consistent download links
- Jan from Planio www.plan.io wrote:
> I am sorry, I failed to mention that #25999 and therefore #25988 are required for this patch to apply cleanly.
Thanks, the patch works fine now.
This small patch makes #25988 and #25999 even bett... -
10:24 Feature #26035: More visually consistent download links
- Go MAEDA wrote:
> I think that the improvement is fairly useful but unfortunately the patch cannot be applied to the current trunk (r16559) cleanly. Could you tell me how can I apply them?
I am sorry, I failed to mention that #25999 ... -
12:31 Defect #25702 (Needs feedback): Exporting wiki page with specific table to PDF causes 500
- I cannot reproduce.
!1.png!