Project

General

Profile

Activity

From 2018-04-06 to 2018-04-08

2018-04-08

15:46 Defect #26636 (Closed): Rails 5: "Page not found" error when accessing a page of a plugin in production mode
Second fix committed, thanks. Jean-Philippe Lang
15:24 Defect #28264 (Closed): Global and public custom queries are shown as editable to non administrators in projects
Fixed by using a slightly different fix in r17292 with test included.
Thanks for pointing this out.
Jean-Philippe Lang
14:14 Feature #3322: Setting to restrict spent times on future dates
Another update with two fixes:
- take into account the time zone of the time entry author and not of the current user.
- apply the validation only when the spent on date was changed (to follow the implementation from #24005).
Marius BĂLTEANU
14:07 Feature #27985: Support of gem pg 1.0.0 (PostgreSQL)
Go Maeda, sorry for not finding this ticket. Marius BĂLTEANU
14:06 Feature #27985 (Closed): Support of gem pg 1.0.0 (PostgreSQL)
Go MAEDA
14:01 Patch #28505 (Closed): Update pg gem to 1.0
Rails 5.1.5 supports pg gem 1.0
https://github.com/rails/rails/blob/v5.1.6/activerecord/CHANGELOG.md#rails-515-february-14-2018
Unfortunately, I can't run the test suite on PG as database engine.
Marius BĂLTEANU
13:57 Patch #28504 (Closed): Update mysql2 gem to 0.5.0
Rails 5.1.6 supports mysql2 gem 0.5*
https://github.com/rails/rails/blob/v5.1.6/activerecord/CHANGELOG.md#rails-516-march-29-2018
All tests passed on my local environment.
Marius BĂLTEANU
13:39 Feature #27849: Ruby 2.5 support
Redmine is now tested with Ruby 2.5.
http://www.redmine.org/builds/
!{width: 1024px; border: 1px solid #ccc;}.redmine-build-status@2x.png!
Go MAEDA
10:43 Defect #27968: Image filename for HDPI monitors (image@2x.jpg) are misrecognized as email address
Go MAEDA wrote:
> I think more image extensions such as "bmp" and "jpe" should be supported. Please see source:tags/3.4.5/app/helpers/application_helper.rb#L713
> ...
Perfect, thanks for pointing me to that line, I didn't know about it.
Marius BĂLTEANU
10:39 Defect #27968: Image filename for HDPI monitors (image@2x.jpg) are misrecognized as email address
Marius BALTEANU wrote:
> Go Maeda, what do you think about restoring only the following patterns: (.*@2x\.(png|jpg|gif|jpeg))?
I think more image extensions such as "bmp" and "jpe" should be supported. Please see source:tags/3.4.5/a...
Go MAEDA
10:00 Defect #27968: Image filename for HDPI monitors (image@2x.jpg) are misrecognized as email address
Go Maeda, what do you think about restoring only the following patterns: (.*@2x\.(png|jpg|gif|jpeg))?
In this way, formats like:
- logo@2x.png: it'll be restored to string
- logo@2x.us: it'll link to mailto:logo@2x.us
- logo@2x.jp...
Marius BĂLTEANU
10:32 Defect #28502 (Closed): Support issue[assigned_to_id]=me when prefilling issues
h2. Current situation
This works:
* http://demo.redmine.org/issues.xml?assigned_to_id=me shows all issues assigned my account
* http://demo.redmine.org/issues/new?issue[assigned_to_id]=336461 create a new ticket, assigned to account...
Ceesjan Luiten
09:39 Defect #26507 (Confirmed): "attachment:filename" link syntax would not work if the file name contains "@"
Marius BĂLTEANU
09:27 Defect #26507: "attachment:filename" link syntax would not work if the file name contains "@"
Updated the patch to apply cleanly against current trunk (r17286). Marius BĂLTEANU
09:39 Defect #26892 (Confirmed): Link to user in wiki syntax only works when login is written in lower case
Marius BĂLTEANU
09:38 Defect #26892: Link to user in wiki syntax only works when login is written in lower case
Attached is a patch that fixes this issue and it should be applied after #26443. Marius BĂLTEANU
09:22 Defect #26443: User link syntax (user:login) doesn't work for logins consisting of an email adress
Updated the patch to apply cleanly against current trunk (r17286). Marius BĂLTEANU
00:28 Patch #28494: Recalculate issue priority position names if default value changed
Confirmed the problem, setting target version to 4.1.0. Go MAEDA

2018-04-07

16:47 Patch #28493 (Reopened): Persian translation update and improvements
Attached patch fixes month names. Ebrahim Mohammadi
14:14 Patch #28493 (Closed): Persian translation update and improvements
Committed, thanks for your contribution! Jean-Philippe Lang
13:15 Feature #3322: Setting to restrict spent times on future dates
Go MAEDA wrote:
> I am very looking forward Mischa's work. Aside from it, I found that Marius's patch may not work depending on time zones.
> ...
I've fixed the issue, thanks for feedback.
I'm attaching the patch here for those who...
Marius BĂLTEANU
12:27 Defect #22975 (Closed): Moving a wiki page to a different project should refresh parent page list
Committed. Thank you for improving Redmine. Go MAEDA
11:55 Patch #7418: Redmine Persian Translation
See #28493. Ebrahim Mohammadi
11:31 Defect #27884 (Closed): RTL wiki class broken in Redmine 3.2.6
bidi-override removed in r17280. Jean-Philippe Lang
11:18 Defect #27884 (Reopened): RTL wiki class broken in Redmine 3.2.6
Hooman Valibeigi
11:11 Defect #27884: RTL wiki class broken in Redmine 3.2.6
Jean-Philippe Lang wrote:
> The wiki class is fixed by r17260.
You forgot to fix the unicode-bidi:bidi-override; value, must be unicode-bidi:normal; or left unset. bidi-override rotates the English words in a RTL context, therefore w...
Hooman Valibeigi
09:08 Defect #27884 (Closed): RTL wiki class broken in Redmine 3.2.6
The wiki class is fixed by r17260.
> I've just noticed that HTML emails sent from Redmine will contain class="wiki-class-rtl" for RTL text, which is not supposed to work because email clients have no access to Redmine css.
Please o...
Jean-Philippe Lang
10:09 Defect #26857 (Closed): Fix for CVE-2015-9251 in JQuery 1.11.1
Committed, thanks. Jean-Philippe Lang
09:56 Defect #28302 (Closed): Security notification when changing password on password forgotten is empty
Committed. Thanks for pointing this out. Jean-Philippe Lang
09:46 Defect #25299 (Closed): Markdown pre-block could derive incorrect wiki sections
Committed, thanks. Jean-Philippe Lang
09:30 Defect #28208 (Closed): Anonymous icon is wrongly displayed when assignee is a group
Committed, thanks. Jean-Philippe Lang
09:12 Defect #28501 (Closed): Update copyright year to 2018
Go MAEDA
08:41 Patch #28154 (Closed): Support for lastnames with spaces in user autocompleters
Committed. Thank you for the improvement. Go MAEDA
02:33 Defect #28180 (Closed): Role-base cross-project issue query visibility calculated incorrectly
Committed. Thank you for your contribution. Go MAEDA

2018-04-06

19:38 Defect #17068: When copying subtasks with relations between them self's are lost
I Created a patch against 3.4 stable to implement copying subtask interrelations.
It applies cleanly to master.
I have been unable to test on master yet due to issues with updating rails (dependency problems for actionpack-xml_parser. ...
Robert Beckett
18:33 Feature #15296: Include image thumbnails with PDF export
Is there any solution to this? Eric Prandovszky
 

Also available in: Atom