Project

General

Profile

Activity

From 2018-12-07 to 2018-12-09

2018-12-09

23:23 Patch #30167 (New): Replace ajax-indicator with a waiting cursor
I honestly think that getting rid of "loading" modal and remaking the responsible JS line to append a waiting cursor to the body tag, then setting back to normal once loaded could be a good little improvement to the UI.
IMHO it's also o...
Anonymous
18:38 Defect #30164: Missing images in a wiki page are not visualized
symmetrical issue to #30165 Darko Palic
18:21 Defect #30164 (Confirmed): Missing images in a wiki page are not visualized
Right now if a wiki page has referenced a image/picture, it is not visualizing the lack of the attached binary.
It would be great to add a image reference like this https://upload.wikimedia.org/wikipedia/commons/e/e4/Comic_image_missing...
Darko Palic
18:38 Defect #30165 (New): Non used images in Wiki pages are not easily to identify
Attached images to a wiki page can get an orphan, if the content of the wiki page was changed.
Sadly redmine wiki does not provide any way to identify orphaned files/images in wiki pages.
This is a symmetrical issue to #30164
Darko Palic
17:41 Patch #30163 (Closed): Remove unnecessary tests in test/unit/initializers/patches_test.rb
There are tests for ActiveSupport::HashWithIndifferentAccess in test/unit/initializers/patches_test.rb. Now we can remove those tests safely.
The tests were added in r13115 to test a patch that was added as a workaround for regression...
Go MAEDA
16:58 Defect #30161: Incorrect supported Ruby version in doc/INSTALL
Jean-Philippe Lang wrote:
> ruby 2.2 is no longer maintained: https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/
> ...
I am in favor of dropping support for Ruby 2.2. It is not very important to support 4 years...
Go MAEDA
16:50 Defect #30161: Incorrect supported Ruby version in doc/INSTALL
ruby 2.2 is no longer maintained: https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/
Shouldn't we require ruby 2.3?
Jean-Philippe Lang
13:51 Defect #30161 (Closed): Incorrect supported Ruby version in doc/INSTALL
Redmine 4.0 (Rails 5.2) requires Ruby 2.2.2 or later, but doc/INSTALL states Ruby 2.2.1 or later. Go MAEDA
16:01 Patch #30162 (Closed): Wiki page collapse block image is not displayed in exported PDF
Wiki page collapse block image is not displayed in exported PDF.
I wrote collapse_block_pdf.patch.
!collapse.png!
* Sample Text
Jun NAITOH
10:34 Feature #30118: Ruby 2.6 support
ruby2.6-rc1 is added to the CI server: http://www.redmine.org/builds Jean-Philippe Lang
09:38 Revision 17718 (svn): Test failure with SQLite3.
ActiveRecord::RecordNotUnique: SQLite3::ConstraintException: UNIQUE constraint failed: custom_fields_trackers.custom_field_id, custom_fields_trackers.tracker_id: INSERT INTO "custom_fields_trackers" ("custom_field_id", "tracker_id") VALU... Jean-Philippe Lang
08:38 Redmine 4.0.0, 3.4.7 and 3.3.9 released
Thanks to the many people who contributed to Redmine since last year, I'm glad to announce that Redmine 4.0.0 is now available for download. It brings [[Changelog_4_0#400-2018-12-09|more than 200 changes]] including:
* a major change to...
Jean-Philippe Lang
07:41 Revision 17717 (svn): tagged version 4.0.0
Jean-Philippe Lang
07:40 Revision 17716 (svn): tagged version 3.4.7
Jean-Philippe Lang
07:40 Revision 17715 (svn): tagged version 3.3.9
Jean-Philippe Lang
07:39 Revision 17714 (svn): Wrong tag
Jean-Philippe Lang
07:37 Revision 17713 (svn): tagged version 3.4.7
Jean-Philippe Lang
07:37 Revision 17712 (svn): Merged 17711 to 4.0-stable.
Jean-Philippe Lang
07:36 Revision 17711 (svn): CHANGELOG for 4.0.0.
Jean-Philippe Lang
07:36 Revision 17710 (svn): Updates for 3.4.7 release.
Jean-Philippe Lang
07:36 Revision 17709 (svn): Updates for 3.3.9 release.
Jean-Philippe Lang
07:21 Revision 17708 (svn): Merged r17707 to 4.0-stable (#30137).
Jean-Philippe Lang
05:35 Patch #30137 (Closed): Remove rails-html-sanitizer from Gemfile
Committed. Go MAEDA
03:40 Patch #30137: Remove rails-html-sanitizer from Gemfile
It was introduced in r15105. Go MAEDA
03:38 Patch #30137 (Closed): Remove rails-html-sanitizer from Gemfile
Redmine installs rails-html-sanitizer to ensure that not to use vulnerable versions prior to 1.0.3.
But it is not necessary any longer because Rails "actionview 5.2.2":https://rubygems.org/gems/actionview/versions/5.2.2 requires rails...
Go MAEDA
05:34 Revision 17707 (svn): Remove rails-html-sanitizer from Gemfile (#30137).
Go MAEDA
03:14 Revision 17706 (svn): Ruby 2.6: Don't explicitly install rdoc gem (#30118).
Go MAEDA
02:07 Defect #30125: Can't be distinguished when deleting multiple attachments with the same file name in one action.
* Environment Jun NAITOH
01:35 Patch #30136 (Closed): Brazilian translation update
Committed. Thank you for updating the translation. Go MAEDA
01:35 Revision 17705 (svn): Merged r17704 from trunk to 4.0-stable (#30136).
Go MAEDA
01:33 Revision 17704 (svn): Brazilian translation update (#30136).
Patch by Patrick Kaminski. Go MAEDA

2018-12-08

23:00 Patch #30136 (Closed): Brazilian translation update

Translated *error_token_expired*.
Patrick Kaminski
15:41 Defect #27283: Failed to run "rake db:migrate" command against clean database on MySQL 5.7
Removing the target version because I think this issue is a part of #23630.
The bug only existed in the trunk while migrating to Rails 5 and was not included in past releases, therefore it is not necessary to add this issue to the cha...
Go MAEDA
10:34 Revision 17703 (svn): Merged r17702.
Jean-Philippe Lang
09:56 Defect #30121 (Confirmed): Projects API should not return invisible trackers
Confirmed the problem. Thank you for catching and reporting this. Go MAEDA
08:24 Revision 17702 (svn): Random test failure.
Jean-Philippe Lang
07:51 Revision 17701 (svn): Set stable version.
Jean-Philippe Lang
07:51 Revision 17700 (svn): Merged r17699.
Jean-Philippe Lang
07:50 Revision 17699 (svn): Bump version to 4.0.0
Jean-Philippe Lang
07:46 Revision 17698 (svn): Created 4.0-stable branch.
Jean-Philippe Lang
07:41 Patch #30119: Update Rails to 5.2.2
Marius BALTEANU wrote:
> All tests pass: https://gitlab.com/marius-balteanu/redmine/-/jobs/131249362
r17697 fixes tests for SQLite3
Jean-Philippe Lang
07:40 Revision 17697 (svn): Tests broken for SQLite3 (#30119).
Jean-Philippe Lang
07:36 Feature #27313: More custom queries on My page
We should probably load content asynchronously before raising the number of queries that can be displayed. Jean-Philippe Lang
07:04 Feature #9068: New button : "Submit modification without notification"
Jérôme BATAILLE wrote:
> * What is an issue for you ? that modifications are made without notifications ?
Yes.
A user watches objects to receive *all* notifications. Temporarily disabling notifications by a user who updates the ob...
Go MAEDA
06:51 Revision 17696 (svn): Don't explicitly install csv gem in Ruby 2.6 (#30118).
Redmine installs csv gem since r17245 as a workaround for a bug of csv 1.0.0 which is bundled with Ruby 2.5 (see #28112). But in Ruby 2.6, installing the gem is not necessary because the bundled csv gem was updated to 3.0. Go MAEDA
06:37 Defect #30125 (Confirmed): Can't be distinguished when deleting multiple attachments with the same file name in one action.
* When attachment file names are the same.
!same_name_attachments.png!
* I can not distinguish files I want to delete.
!delete.png!
Jun NAITOH

2018-12-07

22:41 Feature #29824: Add user initials when Gravatar is disabled
Inserting the improved code for testing, if somebody has time, by all means feel free to share feedback.
Known problems:
* I didn't yet figure out how to force stretch text along the size of the avatar block.
* Works almost everywhere...
Anonymous
13:39 Defect #30121 (Closed): Projects API should not return invisible trackers
Currently projects API returns all trackers, assigned to given project. This is inconsistency with web view, which shows only trackers, visible to the user. They are the only usable to current user anyways.
This is invoked like this: pr...
Alex Stanev
13:16 Feature #9068: New button : "Submit modification without notification"
Hi,
* This is a common case in our company, when you don't want to bother users when cleaning issues for exemple.
* What is an issue for you ? that modifications are made without notifications ?
Perhaps we could add a mention in the...
Jérôme BATAILLE
08:56 Feature #9068: New button : "Submit modification without notification"
-1
I am against this feature. With this feature, a user can secretly update issues without noticing watchers. I think this is a big problem.
Go MAEDA
12:24 Defect #8742: % done in parent task is incorrect
So maybe it's time to close it. Anonymous
10:40 Patch #30119 (Closed): Update Rails to 5.2.2
Committed. Thanks. Go MAEDA
10:03 Patch #30119: Update Rails to 5.2.2
All tests pass: https://gitlab.com/marius-balteanu/redmine/-/jobs/131249362 Marius BĂLTEANU
09:05 Patch #30119 (Closed): Update Rails to 5.2.2
https://weblog.rubyonrails.org/2018/12/4/Rails-5-2-2-has-been-released/ Marius BĂLTEANU
10:40 Revision 17695 (svn): Update Rails to 5.2.2 (#30119).
Patch by Marius BALTEANU. Go MAEDA
10:19 Defect #30120 (Closed): Add missing fixture for reports_controller_test
Committed. Thanks. Go MAEDA
10:04 Defect #30120 (Closed): Add missing fixture for reports_controller_test
Running test/functional/reports_controller_test.rb in isolation will fail because of a missing fixtures. I've detected the issue here: https://gitlab.com/marius-balteanu/redmine/-/jobs/130977733 Marius BĂLTEANU
10:18 Revision 17694 (svn): Add missing fixture for reports_controller_test (#30120).
Patch by Marius BALTEANU. Go MAEDA
09:37 Feature #30118: Ruby 2.6 support
Go MAEDA wrote:
> The current trunk r17686 passed tests (but I skipped LDAP and rmagick tests) in ruby 2.6.0preview2.
I made a branch on the GitLab CI to track the test results until Ruby 2.6 is released.
* Branch: https://gitlab.c...
Marius BĂLTEANU
09:06 Feature #30118: Ruby 2.6 support
The current trunk r17686 passed tests (but I skipped LDAP and rmagick tests) in ruby 2.6.0preview2. Go MAEDA
08:15 Feature #30118 (Closed): Ruby 2.6 support
Ruby 2.6 is going to be released on 2018-12-25.
https://bugs.ruby-lang.org/projects/ruby-trunk/roadmap#2.6
Go MAEDA
02:39 Defect #28636 (Closed): Cannot find an issue from a closed subproject when search scope is Project and its subprojects
Committed the patch. Thank you for catching and fixing this issue.
I didn't commit the fix to 3.3-stable branch because a test failed.
Go MAEDA
01:54 Revision 17693 (svn): Merged r17692 from trunk to 3.4-stable (#28636).
Go MAEDA
00:21 Revision 17692 (svn): Include closed projects in search for scope subprojects (#28636).
Patch by Marius BALTEANU. Go MAEDA
 

Also available in: Atom