Project

General

Profile

Activity

From 2021-02-15 to 2021-02-17

2021-02-17

15:20 Feature #33820: Auto complete wiki page links
I found a security issue.
Auto complete for wiki pages should not suggest pages that the current user cannot view. The current patch always shows wiki pages even if the current user does not have "View wiki".
Go MAEDA
14:48 Patch #32530: Update RuboCop to 1.12
Updated RuboCop to 1.10 in r20751. Go MAEDA
14:47 Revision 20751 (svn): Update RuboCop to 1.10.0 (#32530).
Go MAEDA
14:38 Revision 20750 (svn): Update .rubocop_todo.yml (#32530).
Go MAEDA
13:38 Revision 20749 (svn): Reverts r20190.
Go MAEDA
13:35 Revision 20748 (svn): Reverts r20488 and r20189.
Go MAEDA
13:24 Patch #34750 (Closed): Remove unsupported encodings ISO-2022-KR and ISCII91 from Setting::ENCODINGS
Committed the patch. Go MAEDA
13:24 Revision 20747 (svn): Remove unsupported encodings ISO-2022-KR and ISCII91 from Setting::ENCODINGS (#34750).
Patch by Go MAEDA. Go MAEDA

2021-02-16

14:51 Feature #34695: Allow editing the issue description immediately (issue editing form)
Yuuki NARA wrote:
> +1
> ...
Thanks, I will check this plugin out.
Soltész András
14:17 Feature #34695: Allow editing the issue description immediately (issue editing form)
+1
I also agree with this feature.
Currently it is possible with this plugin.
https://github.com/Ilogeek/redmine_issue_dynamic_edit
Yuuki NARA
10:51 Patch #34750: Remove unsupported encodings ISO-2022-KR and ISCII91 from Setting::ENCODINGS
Setting the target version to 4.2.0. Go MAEDA
01:25 Patch #34750: Remove unsupported encodings ISO-2022-KR and ISCII91 from Setting::ENCODINGS
Go MAEDA wrote:
> Iconv library used in Redmine 2.6 and earlier supported these two encodings, but @String#encode@ used in Redmine 3.0 and later does not.
This is not correct. Redmine from 2.3 to 2.6 uses Iconv only when it runs on R...
Go MAEDA
08:21 Feature #2024: gantt chart editing
Mizuki ISHIKAWA wrote:
> I applied the patch of #2024#note-123 and tried to make it work.
Thank you for giving it a try.
---
Yuichi HARADA wrote:
> ...
I incorporated a patch created with #34694#note-3.
Yuichi HARADA

2021-02-15

17:11 Patch #34750 (Closed): Remove unsupported encodings ISO-2022-KR and ISCII91 from Setting::ENCODINGS
ISO-2022-KR and ISCII91 are no longer supported by Ruby. These encodings should be removed from @Setting::ENCODINGS@ constant.
Iconv library used in Redmine 2.6 and earlier supported these two encodings, but @String#encode@ used in Re...
Go MAEDA
08:55 Defect #34694: Progress bar for a shared version on gantt disappears when the tree is collapsed and then expanded
Yuichi HARADA wrote:
> I also confirmed.
> ...
I could get the number of the current rows, so I remade the patch.
Yuichi HARADA
07:51 Defect #34641: When editing an issue, the Log time and/or Add notes does not show or hide dynamically
Marius BALTEANU wrote:
> What do you think if we update the entire "edit" form instead of only "form"? In this way, we fix this issue for all three affected blocks: log time, add notes and add attachments and we simplify the code, as we...
Yuichi HARADA
06:36 Defect #34743: Hooks for queries helper
Hi Go MAEDA,
thanks for responding.
Here is a list of some plugins which overwrites query helper methods:
* "redmine_multiprojects_issue":https://github.com/nanego/redmine_multiprojects_issue
* "redmine_checklists":https://www....
Alexander Meindl
02:53 Defect #34743: Hooks for queries helper
Alexander Meindl wrote:
> Plugin developers very often overwrite queries helper _column_value_ and _column_content_.
Could you show me some plugins that do that?
Go MAEDA
03:30 Patch #34745 (Closed): Remove unused i18n key "text_min_max_length_info"
Committed the patch. Go MAEDA
03:29 Revision 20746 (svn): Remove unused i18n key "text_min_max_length_info" (#34745).
Patch by Go MAEDA. Go MAEDA
01:29 Feature #33820: Auto complete wiki page links
Marius BALTEANU wrote:
> Mizuki, can you add a system tests for this? you should have enough examples.
I have attached a patch with system test added.
There are already tests to check that tributes work on other pages, so I'm only a...
Mizuki ISHIKAWA
 

Also available in: Atom